* [PATCH v2] cpufreq: hisilicon: add acpu driver
@ 2015-03-26 11:48 ` Leo Yan
0 siblings, 0 replies; 8+ messages in thread
From: Leo Yan @ 2015-03-26 11:48 UTC (permalink / raw)
To: Rafael J . Wysocki, Viresh Kumar, linux-pm, linux-arm-kernel,
Dan Zhao, zhenwei.wang, mohaoju, Haojian Zhuang, Wei Xu
Cc: Leo Yan
Add acpu driver for hisilicon SoC, acpu is application processor
subsystem. Currently the acpu has the coupled clock domain for two
clusters, so this driver will directly use cpufreq-dt driver as
backend.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
drivers/cpufreq/Kconfig.arm | 9 ++++++++
drivers/cpufreq/Makefile | 1 +
drivers/cpufreq/hisi-acpu-cpufreq.c | 43 +++++++++++++++++++++++++++++++++++++
3 files changed, 53 insertions(+)
create mode 100644 drivers/cpufreq/hisi-acpu-cpufreq.c
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 1b06fc4..4f3dbc8 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -108,6 +108,15 @@ config ARM_HIGHBANK_CPUFREQ
If in doubt, say N.
+config ARM_HISI_ACPU_CPUFREQ
+ tristate "Hisilicon ACPU CPUfreq driver"
+ depends on ARCH_HISI && CPUFREQ_DT
+ select PM_OPP
+ help
+ This enables the hisilicon ACPU CPUfreq driver.
+
+ If in doubt, say N.
+
config ARM_IMX6Q_CPUFREQ
tristate "Freescale i.MX6 cpufreq support"
depends on ARCH_MXC
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index 82a1821..6b7a3f0 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -59,6 +59,7 @@ arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS4X12_CPUFREQ) += exynos4x12-cpufreq.o
arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS5250_CPUFREQ) += exynos5250-cpufreq.o
obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
+obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
obj-$(CONFIG_ARM_IMX6Q_CPUFREQ) += imx6q-cpufreq.o
obj-$(CONFIG_ARM_INTEGRATOR) += integrator-cpufreq.o
obj-$(CONFIG_ARM_KIRKWOOD_CPUFREQ) += kirkwood-cpufreq.o
diff --git a/drivers/cpufreq/hisi-acpu-cpufreq.c b/drivers/cpufreq/hisi-acpu-cpufreq.c
new file mode 100644
index 0000000..2c7a705
--- /dev/null
+++ b/drivers/cpufreq/hisi-acpu-cpufreq.c
@@ -0,0 +1,43 @@
+/*
+ * Hisilicon Platforms Using ACPU CPUFreq Support
+ *
+ * Copyright (c) 2015 Hisilicon Limited.
+ * Copyright (c) 2015 Linaro Limited.
+ *
+ * Leo Yan <leo.yan@linaro.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+
+static int __init hisi_acpu_cpufreq_driver_init(void)
+{
+ struct platform_device_info devinfo = { .name = "cpufreq-dt", };
+ struct platform_device *pdev;
+
+ if (!of_machine_is_compatible("hisilicon,hi6220"))
+ return -ENODEV;
+
+ pdev = platform_device_register_full(&devinfo);
+ return PTR_ERR_OR_ZERO(pdev);
+}
+module_init(hisi_acpu_cpufreq_driver_init);
+
+MODULE_AUTHOR("Leo Yan <leo.yan@linaro.org>");
+MODULE_DESCRIPTION("Hisilicon acpu cpufreq driver");
+MODULE_LICENSE("GPL v2");
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2] cpufreq: hisilicon: add acpu driver
@ 2015-03-26 11:48 ` Leo Yan
0 siblings, 0 replies; 8+ messages in thread
From: Leo Yan @ 2015-03-26 11:48 UTC (permalink / raw)
To: linux-arm-kernel
Add acpu driver for hisilicon SoC, acpu is application processor
subsystem. Currently the acpu has the coupled clock domain for two
clusters, so this driver will directly use cpufreq-dt driver as
backend.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
drivers/cpufreq/Kconfig.arm | 9 ++++++++
drivers/cpufreq/Makefile | 1 +
drivers/cpufreq/hisi-acpu-cpufreq.c | 43 +++++++++++++++++++++++++++++++++++++
3 files changed, 53 insertions(+)
create mode 100644 drivers/cpufreq/hisi-acpu-cpufreq.c
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 1b06fc4..4f3dbc8 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -108,6 +108,15 @@ config ARM_HIGHBANK_CPUFREQ
If in doubt, say N.
+config ARM_HISI_ACPU_CPUFREQ
+ tristate "Hisilicon ACPU CPUfreq driver"
+ depends on ARCH_HISI && CPUFREQ_DT
+ select PM_OPP
+ help
+ This enables the hisilicon ACPU CPUfreq driver.
+
+ If in doubt, say N.
+
config ARM_IMX6Q_CPUFREQ
tristate "Freescale i.MX6 cpufreq support"
depends on ARCH_MXC
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index 82a1821..6b7a3f0 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -59,6 +59,7 @@ arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS4X12_CPUFREQ) += exynos4x12-cpufreq.o
arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS5250_CPUFREQ) += exynos5250-cpufreq.o
obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
+obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
obj-$(CONFIG_ARM_IMX6Q_CPUFREQ) += imx6q-cpufreq.o
obj-$(CONFIG_ARM_INTEGRATOR) += integrator-cpufreq.o
obj-$(CONFIG_ARM_KIRKWOOD_CPUFREQ) += kirkwood-cpufreq.o
diff --git a/drivers/cpufreq/hisi-acpu-cpufreq.c b/drivers/cpufreq/hisi-acpu-cpufreq.c
new file mode 100644
index 0000000..2c7a705
--- /dev/null
+++ b/drivers/cpufreq/hisi-acpu-cpufreq.c
@@ -0,0 +1,43 @@
+/*
+ * Hisilicon Platforms Using ACPU CPUFreq Support
+ *
+ * Copyright (c) 2015 Hisilicon Limited.
+ * Copyright (c) 2015 Linaro Limited.
+ *
+ * Leo Yan <leo.yan@linaro.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+
+static int __init hisi_acpu_cpufreq_driver_init(void)
+{
+ struct platform_device_info devinfo = { .name = "cpufreq-dt", };
+ struct platform_device *pdev;
+
+ if (!of_machine_is_compatible("hisilicon,hi6220"))
+ return -ENODEV;
+
+ pdev = platform_device_register_full(&devinfo);
+ return PTR_ERR_OR_ZERO(pdev);
+}
+module_init(hisi_acpu_cpufreq_driver_init);
+
+MODULE_AUTHOR("Leo Yan <leo.yan@linaro.org>");
+MODULE_DESCRIPTION("Hisilicon acpu cpufreq driver");
+MODULE_LICENSE("GPL v2");
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] cpufreq: hisilicon: add acpu driver
2015-03-26 11:48 ` Leo Yan
@ 2015-03-26 13:24 ` Viresh Kumar
-1 siblings, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2015-03-26 13:24 UTC (permalink / raw)
To: Leo Yan
Cc: Rafael J . Wysocki, linux-pm, linux-arm-kernel, Dan Zhao,
zhenwei.wang, mohaoju, Haojian Zhuang, Wei Xu
On 26 March 2015 at 17:18, Leo Yan <leo.yan@linaro.org> wrote:
> Add acpu driver for hisilicon SoC, acpu is application processor
> subsystem. Currently the acpu has the coupled clock domain for two
> clusters, so this driver will directly use cpufreq-dt driver as
> backend.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> drivers/cpufreq/Kconfig.arm | 9 ++++++++
> drivers/cpufreq/Makefile | 1 +
> drivers/cpufreq/hisi-acpu-cpufreq.c | 43 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 53 insertions(+)
> create mode 100644 drivers/cpufreq/hisi-acpu-cpufreq.c
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1b06fc4..4f3dbc8 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -108,6 +108,15 @@ config ARM_HIGHBANK_CPUFREQ
>
> If in doubt, say N.
>
> +config ARM_HISI_ACPU_CPUFREQ
> + tristate "Hisilicon ACPU CPUfreq driver"
> + depends on ARCH_HISI && CPUFREQ_DT
> + select PM_OPP
> + help
> + This enables the hisilicon ACPU CPUfreq driver.
> +
> + If in doubt, say N.
> +
> config ARM_IMX6Q_CPUFREQ
> tristate "Freescale i.MX6 cpufreq support"
> depends on ARCH_MXC
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index 82a1821..6b7a3f0 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -59,6 +59,7 @@ arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS4X12_CPUFREQ) += exynos4x12-cpufreq.o
> arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS5250_CPUFREQ) += exynos5250-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> +obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
> obj-$(CONFIG_ARM_IMX6Q_CPUFREQ) += imx6q-cpufreq.o
> obj-$(CONFIG_ARM_INTEGRATOR) += integrator-cpufreq.o
> obj-$(CONFIG_ARM_KIRKWOOD_CPUFREQ) += kirkwood-cpufreq.o
> diff --git a/drivers/cpufreq/hisi-acpu-cpufreq.c b/drivers/cpufreq/hisi-acpu-cpufreq.c
> new file mode 100644
> index 0000000..2c7a705
> --- /dev/null
> +++ b/drivers/cpufreq/hisi-acpu-cpufreq.c
> @@ -0,0 +1,43 @@
> +/*
> + * Hisilicon Platforms Using ACPU CPUFreq Support
> + *
> + * Copyright (c) 2015 Hisilicon Limited.
> + * Copyright (c) 2015 Linaro Limited.
> + *
> + * Leo Yan <leo.yan@linaro.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> +#include <linux/err.h>
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +
> +static int __init hisi_acpu_cpufreq_driver_init(void)
> +{
> + struct platform_device_info devinfo = { .name = "cpufreq-dt", };
> + struct platform_device *pdev;
> +
> + if (!of_machine_is_compatible("hisilicon,hi6220"))
> + return -ENODEV;
> +
> + pdev = platform_device_register_full(&devinfo);
> + return PTR_ERR_OR_ZERO(pdev);
> +}
> +module_init(hisi_acpu_cpufreq_driver_init);
> +
> +MODULE_AUTHOR("Leo Yan <leo.yan@linaro.org>");
> +MODULE_DESCRIPTION("Hisilicon acpu cpufreq driver");
> +MODULE_LICENSE("GPL v2");
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2] cpufreq: hisilicon: add acpu driver
@ 2015-03-26 13:24 ` Viresh Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2015-03-26 13:24 UTC (permalink / raw)
To: linux-arm-kernel
On 26 March 2015 at 17:18, Leo Yan <leo.yan@linaro.org> wrote:
> Add acpu driver for hisilicon SoC, acpu is application processor
> subsystem. Currently the acpu has the coupled clock domain for two
> clusters, so this driver will directly use cpufreq-dt driver as
> backend.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> drivers/cpufreq/Kconfig.arm | 9 ++++++++
> drivers/cpufreq/Makefile | 1 +
> drivers/cpufreq/hisi-acpu-cpufreq.c | 43 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 53 insertions(+)
> create mode 100644 drivers/cpufreq/hisi-acpu-cpufreq.c
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1b06fc4..4f3dbc8 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -108,6 +108,15 @@ config ARM_HIGHBANK_CPUFREQ
>
> If in doubt, say N.
>
> +config ARM_HISI_ACPU_CPUFREQ
> + tristate "Hisilicon ACPU CPUfreq driver"
> + depends on ARCH_HISI && CPUFREQ_DT
> + select PM_OPP
> + help
> + This enables the hisilicon ACPU CPUfreq driver.
> +
> + If in doubt, say N.
> +
> config ARM_IMX6Q_CPUFREQ
> tristate "Freescale i.MX6 cpufreq support"
> depends on ARCH_MXC
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index 82a1821..6b7a3f0 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -59,6 +59,7 @@ arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS4X12_CPUFREQ) += exynos4x12-cpufreq.o
> arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS5250_CPUFREQ) += exynos5250-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> +obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
> obj-$(CONFIG_ARM_IMX6Q_CPUFREQ) += imx6q-cpufreq.o
> obj-$(CONFIG_ARM_INTEGRATOR) += integrator-cpufreq.o
> obj-$(CONFIG_ARM_KIRKWOOD_CPUFREQ) += kirkwood-cpufreq.o
> diff --git a/drivers/cpufreq/hisi-acpu-cpufreq.c b/drivers/cpufreq/hisi-acpu-cpufreq.c
> new file mode 100644
> index 0000000..2c7a705
> --- /dev/null
> +++ b/drivers/cpufreq/hisi-acpu-cpufreq.c
> @@ -0,0 +1,43 @@
> +/*
> + * Hisilicon Platforms Using ACPU CPUFreq Support
> + *
> + * Copyright (c) 2015 Hisilicon Limited.
> + * Copyright (c) 2015 Linaro Limited.
> + *
> + * Leo Yan <leo.yan@linaro.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> +#include <linux/err.h>
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +
> +static int __init hisi_acpu_cpufreq_driver_init(void)
> +{
> + struct platform_device_info devinfo = { .name = "cpufreq-dt", };
> + struct platform_device *pdev;
> +
> + if (!of_machine_is_compatible("hisilicon,hi6220"))
> + return -ENODEV;
> +
> + pdev = platform_device_register_full(&devinfo);
> + return PTR_ERR_OR_ZERO(pdev);
> +}
> +module_init(hisi_acpu_cpufreq_driver_init);
> +
> +MODULE_AUTHOR("Leo Yan <leo.yan@linaro.org>");
> +MODULE_DESCRIPTION("Hisilicon acpu cpufreq driver");
> +MODULE_LICENSE("GPL v2");
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] cpufreq: hisilicon: add acpu driver
2015-03-26 11:48 ` Leo Yan
@ 2015-03-26 14:13 ` Sudeep Holla
-1 siblings, 0 replies; 8+ messages in thread
From: Sudeep Holla @ 2015-03-26 14:13 UTC (permalink / raw)
To: Leo Yan, Viresh Kumar, linux-pm, linux-arm-kernel, Dan Zhao,
zhenwei.wang, mohaoju, Haojian Zhuang, Wei Xu
Cc: Rafael J . Wysocki, Sudeep Holla
On 26/03/15 11:48, Leo Yan wrote:
> Add acpu driver for hisilicon SoC, acpu is application processor
> subsystem. Currently the acpu has the coupled clock domain for two
> clusters, so this driver will directly use cpufreq-dt driver as
> backend.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> drivers/cpufreq/Kconfig.arm | 9 ++++++++
> drivers/cpufreq/Makefile | 1 +
> drivers/cpufreq/hisi-acpu-cpufreq.c | 43 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 53 insertions(+)
> create mode 100644 drivers/cpufreq/hisi-acpu-cpufreq.c
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1b06fc4..4f3dbc8 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -108,6 +108,15 @@ config ARM_HIGHBANK_CPUFREQ
>
> If in doubt, say N.
>
> +config ARM_HISI_ACPU_CPUFREQ
> + tristate "Hisilicon ACPU CPUfreq driver"
> + depends on ARCH_HISI && CPUFREQ_DT
> + select PM_OPP
> + help
> + This enables the hisilicon ACPU CPUfreq driver.
> +
> + If in doubt, say N.
> +
> config ARM_IMX6Q_CPUFREQ
> tristate "Freescale i.MX6 cpufreq support"
> depends on ARCH_MXC
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index 82a1821..6b7a3f0 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -59,6 +59,7 @@ arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS4X12_CPUFREQ) += exynos4x12-cpufreq.o
> arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS5250_CPUFREQ) += exynos5250-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> +obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
> obj-$(CONFIG_ARM_IMX6Q_CPUFREQ) += imx6q-cpufreq.o
> obj-$(CONFIG_ARM_INTEGRATOR) += integrator-cpufreq.o
> obj-$(CONFIG_ARM_KIRKWOOD_CPUFREQ) += kirkwood-cpufreq.o
> diff --git a/drivers/cpufreq/hisi-acpu-cpufreq.c b/drivers/cpufreq/hisi-acpu-cpufreq.c
> new file mode 100644
> index 0000000..2c7a705
> --- /dev/null
> +++ b/drivers/cpufreq/hisi-acpu-cpufreq.c
> @@ -0,0 +1,43 @@
> +/*
> + * Hisilicon Platforms Using ACPU CPUFreq Support
> + *
> + * Copyright (c) 2015 Hisilicon Limited.
> + * Copyright (c) 2015 Linaro Limited.
> + *
> + * Leo Yan <leo.yan@linaro.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> +#include <linux/err.h>
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +
> +static int __init hisi_acpu_cpufreq_driver_init(void)
> +{
> + struct platform_device_info devinfo = { .name = "cpufreq-dt", };
> + struct platform_device *pdev;
> +
> + if (!of_machine_is_compatible("hisilicon,hi6220"))
> + return -ENODEV;
> +
> + pdev = platform_device_register_full(&devinfo);
> + return PTR_ERR_OR_ZERO(pdev);
Since you are not using anything other than name, you can simplify it
further by something like:
platform_device_register_simple("cpufreq-dt", -1, NULL, 0)
And IMO it need not be a separate driver too, you can add this in mach
if it exists(i.e. arm32 though not recommended) or clock code that
registers cpu clock. Thoughts ?
Regards,
Sudeep
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2] cpufreq: hisilicon: add acpu driver
@ 2015-03-26 14:13 ` Sudeep Holla
0 siblings, 0 replies; 8+ messages in thread
From: Sudeep Holla @ 2015-03-26 14:13 UTC (permalink / raw)
To: linux-arm-kernel
On 26/03/15 11:48, Leo Yan wrote:
> Add acpu driver for hisilicon SoC, acpu is application processor
> subsystem. Currently the acpu has the coupled clock domain for two
> clusters, so this driver will directly use cpufreq-dt driver as
> backend.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> drivers/cpufreq/Kconfig.arm | 9 ++++++++
> drivers/cpufreq/Makefile | 1 +
> drivers/cpufreq/hisi-acpu-cpufreq.c | 43 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 53 insertions(+)
> create mode 100644 drivers/cpufreq/hisi-acpu-cpufreq.c
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1b06fc4..4f3dbc8 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -108,6 +108,15 @@ config ARM_HIGHBANK_CPUFREQ
>
> If in doubt, say N.
>
> +config ARM_HISI_ACPU_CPUFREQ
> + tristate "Hisilicon ACPU CPUfreq driver"
> + depends on ARCH_HISI && CPUFREQ_DT
> + select PM_OPP
> + help
> + This enables the hisilicon ACPU CPUfreq driver.
> +
> + If in doubt, say N.
> +
> config ARM_IMX6Q_CPUFREQ
> tristate "Freescale i.MX6 cpufreq support"
> depends on ARCH_MXC
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index 82a1821..6b7a3f0 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -59,6 +59,7 @@ arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS4X12_CPUFREQ) += exynos4x12-cpufreq.o
> arm-exynos-cpufreq-$(CONFIG_ARM_EXYNOS5250_CPUFREQ) += exynos5250-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> +obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
> obj-$(CONFIG_ARM_IMX6Q_CPUFREQ) += imx6q-cpufreq.o
> obj-$(CONFIG_ARM_INTEGRATOR) += integrator-cpufreq.o
> obj-$(CONFIG_ARM_KIRKWOOD_CPUFREQ) += kirkwood-cpufreq.o
> diff --git a/drivers/cpufreq/hisi-acpu-cpufreq.c b/drivers/cpufreq/hisi-acpu-cpufreq.c
> new file mode 100644
> index 0000000..2c7a705
> --- /dev/null
> +++ b/drivers/cpufreq/hisi-acpu-cpufreq.c
> @@ -0,0 +1,43 @@
> +/*
> + * Hisilicon Platforms Using ACPU CPUFreq Support
> + *
> + * Copyright (c) 2015 Hisilicon Limited.
> + * Copyright (c) 2015 Linaro Limited.
> + *
> + * Leo Yan <leo.yan@linaro.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> +#include <linux/err.h>
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +
> +static int __init hisi_acpu_cpufreq_driver_init(void)
> +{
> + struct platform_device_info devinfo = { .name = "cpufreq-dt", };
> + struct platform_device *pdev;
> +
> + if (!of_machine_is_compatible("hisilicon,hi6220"))
> + return -ENODEV;
> +
> + pdev = platform_device_register_full(&devinfo);
> + return PTR_ERR_OR_ZERO(pdev);
Since you are not using anything other than name, you can simplify it
further by something like:
platform_device_register_simple("cpufreq-dt", -1, NULL, 0)
And IMO it need not be a separate driver too, you can add this in mach
if it exists(i.e. arm32 though not recommended) or clock code that
registers cpu clock. Thoughts ?
Regards,
Sudeep
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] cpufreq: hisilicon: add acpu driver
2015-03-26 14:13 ` Sudeep Holla
@ 2015-03-27 2:02 ` Leo Yan
-1 siblings, 0 replies; 8+ messages in thread
From: Leo Yan @ 2015-03-27 2:02 UTC (permalink / raw)
To: Sudeep Holla
Cc: Viresh Kumar, linux-pm, linux-arm-kernel, Dan Zhao, zhenwei.wang,
mohaoju, Haojian Zhuang, Wei Xu, Rafael J . Wysocki
hi Sudeep,
Thanks for reviewing.
On Thu, Mar 26, 2015 at 02:13:38PM +0000, Sudeep Holla wrote:
>
> On 26/03/15 11:48, Leo Yan wrote:
> >+static int __init hisi_acpu_cpufreq_driver_init(void)
> >+{
> >+ struct platform_device_info devinfo = { .name = "cpufreq-dt", };
> >+ struct platform_device *pdev;
> >+
> >+ if (!of_machine_is_compatible("hisilicon,hi6220"))
> >+ return -ENODEV;
> >+
> >+ pdev = platform_device_register_full(&devinfo);
> >+ return PTR_ERR_OR_ZERO(pdev);
>
> Since you are not using anything other than name, you can simplify it
> further by something like:
> platform_device_register_simple("cpufreq-dt", -1, NULL, 0)
Will use this way and resend patch.
> And IMO it need not be a separate driver too, you can add this in mach
> if it exists(i.e. arm32 though not recommended) or clock code that
> registers cpu clock. Thoughts ?
This driver will be firstly used for hikey board w/t ARMv8 SoC and i
prefer de-couple the cpufreq driver w/t clk driver. w/t this cpufreq
driver, we can easily enhance it and init SoC's specific operations
for later more hisilicon SoCs.
Thanks,
Leo Yan
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2] cpufreq: hisilicon: add acpu driver
@ 2015-03-27 2:02 ` Leo Yan
0 siblings, 0 replies; 8+ messages in thread
From: Leo Yan @ 2015-03-27 2:02 UTC (permalink / raw)
To: linux-arm-kernel
hi Sudeep,
Thanks for reviewing.
On Thu, Mar 26, 2015 at 02:13:38PM +0000, Sudeep Holla wrote:
>
> On 26/03/15 11:48, Leo Yan wrote:
> >+static int __init hisi_acpu_cpufreq_driver_init(void)
> >+{
> >+ struct platform_device_info devinfo = { .name = "cpufreq-dt", };
> >+ struct platform_device *pdev;
> >+
> >+ if (!of_machine_is_compatible("hisilicon,hi6220"))
> >+ return -ENODEV;
> >+
> >+ pdev = platform_device_register_full(&devinfo);
> >+ return PTR_ERR_OR_ZERO(pdev);
>
> Since you are not using anything other than name, you can simplify it
> further by something like:
> platform_device_register_simple("cpufreq-dt", -1, NULL, 0)
Will use this way and resend patch.
> And IMO it need not be a separate driver too, you can add this in mach
> if it exists(i.e. arm32 though not recommended) or clock code that
> registers cpu clock. Thoughts ?
This driver will be firstly used for hikey board w/t ARMv8 SoC and i
prefer de-couple the cpufreq driver w/t clk driver. w/t this cpufreq
driver, we can easily enhance it and init SoC's specific operations
for later more hisilicon SoCs.
Thanks,
Leo Yan
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-27 2:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-26 11:48 [PATCH v2] cpufreq: hisilicon: add acpu driver Leo Yan
2015-03-26 11:48 ` Leo Yan
2015-03-26 13:24 ` Viresh Kumar
2015-03-26 13:24 ` Viresh Kumar
2015-03-26 14:13 ` Sudeep Holla
2015-03-26 14:13 ` Sudeep Holla
2015-03-27 2:02 ` Leo Yan
2015-03-27 2:02 ` Leo Yan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.