* [PATCH 1/1] cpufreq: exynos5440: Fix potential NULL pointer dereference
@ 2013-09-18 5:14 Sachin Kamat
2013-09-18 5:36 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2013-09-18 5:14 UTC (permalink / raw)
To: cpufreq; +Cc: linux-pm, rjw, viresh.kumar, sachin.kamat, amit.daniel, patches
If 'dvfs_info' is NULL (due to devm_kzalloc failure) the failure
error message would try to dereference it. Use 'pdev' instead.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/cpufreq/exynos5440-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c
index d514c15..be5380e 100644
--- a/drivers/cpufreq/exynos5440-cpufreq.c
+++ b/drivers/cpufreq/exynos5440-cpufreq.c
@@ -457,7 +457,7 @@ err_free_table:
opp_free_cpufreq_table(dvfs_info->dev, &dvfs_info->freq_table);
err_put_node:
of_node_put(np);
- dev_err(dvfs_info->dev, "%s: failed initialization\n", __func__);
+ dev_err(&pdev->dev, "%s: failed initialization\n", __func__);
return ret;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] cpufreq: exynos5440: Fix potential NULL pointer dereference
2013-09-18 5:14 [PATCH 1/1] cpufreq: exynos5440: Fix potential NULL pointer dereference Sachin Kamat
@ 2013-09-18 5:36 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2013-09-18 5:36 UTC (permalink / raw)
To: Sachin Kamat
Cc: cpufreq, linux-pm, Rafael J. Wysocki, Amit Daniel Kachhap,
Patch Tracking
On 18 September 2013 10:44, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> If 'dvfs_info' is NULL (due to devm_kzalloc failure) the failure
> error message would try to dereference it. Use 'pdev' instead.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/cpufreq/exynos5440-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c
> index d514c15..be5380e 100644
> --- a/drivers/cpufreq/exynos5440-cpufreq.c
> +++ b/drivers/cpufreq/exynos5440-cpufreq.c
> @@ -457,7 +457,7 @@ err_free_table:
> opp_free_cpufreq_table(dvfs_info->dev, &dvfs_info->freq_table);
> err_put_node:
> of_node_put(np);
> - dev_err(dvfs_info->dev, "%s: failed initialization\n", __func__);
> + dev_err(&pdev->dev, "%s: failed initialization\n", __func__);
> return ret;
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-18 5:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-18 5:14 [PATCH 1/1] cpufreq: exynos5440: Fix potential NULL pointer dereference Sachin Kamat
2013-09-18 5:36 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.