From: Viresh Kumar <viresh.kumar@linaro.org>
To: Lan Tianyu <lantianyu1986@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Patch Tracking <patches@linaro.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
"linux-kernel@vger kernel org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 02/34] cpufreq: acpi: remove calls to cpufreq_notify_transition()
Date: Fri, 16 Aug 2013 13:29:58 +0530 [thread overview]
Message-ID: <CAKohpom7yk3Zq5JABZ6T+Z_AcMn5G1hoswZK8T=viYv0fp0mcg@mail.gmail.com> (raw)
In-Reply-To: <CAOLK0pyVDSc6x1u8Ro6ng1dH8ELqc3P9jPHamgiXBn6sWDgm8w@mail.gmail.com>
On 16 August 2013 13:24, Lan Tianyu <lantianyu1986@gmail.com> wrote:
> Sorry for misoperation.
No Problem...
> One concern. Target() callback may return before changing
> cpufreq actually due to some check failures. After this change, prechange
> event will be triggered when these check failures take place. I am not sure
> whether this should be took into account.
Yes, if you see the first patch of this series, it takes this into
account.. In case
target() failed and returned an error, we simply notify the POST CHANGE
notification with old frequencies instead of new ones. I believe that would be
enough..
This is exactly what acpi-cpufreq and others are doing currently.
Hope I answered your question well?
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/34] cpufreq: acpi: remove calls to cpufreq_notify_transition()
Date: Fri, 16 Aug 2013 13:29:58 +0530 [thread overview]
Message-ID: <CAKohpom7yk3Zq5JABZ6T+Z_AcMn5G1hoswZK8T=viYv0fp0mcg@mail.gmail.com> (raw)
In-Reply-To: <CAOLK0pyVDSc6x1u8Ro6ng1dH8ELqc3P9jPHamgiXBn6sWDgm8w@mail.gmail.com>
On 16 August 2013 13:24, Lan Tianyu <lantianyu1986@gmail.com> wrote:
> Sorry for misoperation.
No Problem...
> One concern. Target() callback may return before changing
> cpufreq actually due to some check failures. After this change, prechange
> event will be triggered when these check failures take place. I am not sure
> whether this should be took into account.
Yes, if you see the first patch of this series, it takes this into
account.. In case
target() failed and returned an error, we simply notify the POST CHANGE
notification with old frequencies instead of new ones. I believe that would be
enough..
This is exactly what acpi-cpufreq and others are doing currently.
Hope I answered your question well?
--
viresh
next prev parent reply other threads:[~2013-08-16 8:00 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 2:24 [PATCH 00/34] CPUFreq: Move freq change notifications out of drivers Viresh Kumar
2013-08-16 2:36 ` Viresh Kumar
2013-08-16 2:24 ` Viresh Kumar
2013-08-16 2:24 ` Viresh Kumar
2013-08-16 2:24 ` [PATCH 01/34] cpufreq: move freq change notifications to cpufreq core Viresh Kumar
2013-08-16 2:36 ` Viresh Kumar
2013-08-16 2:24 ` Viresh Kumar
2013-08-16 2:24 ` Viresh Kumar
2013-08-16 2:24 ` [PATCH 02/34] cpufreq: acpi: remove calls to cpufreq_notify_transition() Viresh Kumar
2013-08-16 2:24 ` Viresh Kumar
[not found] ` <CAOLK0pz7e8nQVnZY0a-j_Fd_kFOqF8ZS4tRfYw1S+25Lv8GoFQ@mail.gmail.com>
[not found] ` <CAOLK0pyVDSc6x1u8Ro6ng1dH8ELqc3P9jPHamgiXBn6sWDgm8w@mail.gmail.com>
2013-08-16 7:59 ` Viresh Kumar [this message]
2013-08-16 7:59 ` Viresh Kumar
2013-08-16 7:59 ` Viresh Kumar
2013-08-16 15:30 ` Lan Tianyu
2013-08-16 15:30 ` Lan Tianyu
2013-08-16 15:30 ` Lan Tianyu
2013-08-16 2:25 ` [PATCH 03/34] cpufreq: arm_big_little: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 04/34] cpufreq: at32ap: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 5:58 ` Hans-Christian Egtvedt
2013-08-16 5:58 ` Hans-Christian Egtvedt
2013-08-16 2:25 ` [PATCH 05/34] cpufreq: blackfin: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 06/34] cpufreq: cpu0: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 07/34] cpufreq: cris: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2017-10-10 7:57 ` Jesper Nilsson
2017-10-10 7:57 ` Jesper Nilsson
2017-10-10 7:57 ` Jesper Nilsson
2017-10-10 9:13 ` Viresh Kumar
2017-10-10 9:13 ` Viresh Kumar
2017-10-10 9:13 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 08/34] cpufreq: davinci: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 09/34] cpufreq: dbx500: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 10/34] cpufreq: e_powersaver: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 11/34] cpufreq: elanfreq: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 12/34] cpufreq: exynos: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 13/34] cpufreq: exynos5440: set CPUFREQ_NO_NOTIFICATION flag Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-18 10:54 ` amit daniel kachhap
2013-08-18 10:54 ` amit daniel kachhap
2013-08-18 21:57 ` Kukjin Kim
2013-08-18 21:57 ` Kukjin Kim
2013-08-19 3:42 ` amit daniel kachhap
2013-08-19 3:42 ` amit daniel kachhap
2013-08-19 4:40 ` Viresh Kumar
2013-08-19 4:40 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 14/34] cpufreq: ia64-acpi: remove calls to cpufreq_notify_transition() Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 15/34] cpufreq: imx6q: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 16/34] cpufreq: kirkwood: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 17/34] cpufreq: longhaul: set CPUFREQ_NO_NOTIFICATION flag Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 18/34] cpufreq: loongson2: remove calls to cpufreq_notify_transition() Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 19/34] cpufreq: maple: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 20/34] cpufreq: omap: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 21/34] cpufreq: p4-clockmod: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 22/34] cpufreq: pasemi: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 23/34] cpufreq: pmac: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 24/34] cpufreq: powernow: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 25/34] cpufreq: ppc: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 26/34] cpufreq: pxa: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 27/34] cpufreq: s3c: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 28/34] cpufreq: s5pv210: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 29/34] cpufreq: sa11x0: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 30/34] cpufreq: sc520: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 31/34] cpufreq: sparc: " Viresh Kumar
2013-08-16 2:37 ` Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 32/34] cpufreq: SPEAr: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 33/34] cpufreq: speedstep: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 34/34] cpufreq: tegra: " Viresh Kumar
2013-08-16 2:25 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKohpom7yk3Zq5JABZ6T+Z_AcMn5G1hoswZK8T=viYv0fp0mcg@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=lantianyu1986@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.