From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel
Date: Tue, 4 Apr 2017 08:39:28 +0100 [thread overview]
Message-ID: <CAKv+Gu-3MiGYS=Eh0zfMp41ah6B==HbLFVSh7+kHX_hfHTut-Q@mail.gmail.com> (raw)
In-Reply-To: <20170404073504.GI16309@linaro.org>
On 4 April 2017 at 08:35, AKASHI Takahiro <takahiro.akashi@linaro.org> wrote:
> On Tue, Apr 04, 2017 at 06:14:55AM -0000, David Woodhouse wrote:
>>
>> > On Mon, Apr 03, 2017 at 09:18:12AM +0100, David Woodhouse wrote:
>> >>
>> >> You still have typos here.
>> >
>> > I'd like to defer to the maintainers whether we prefer MiB over MB.
>>
>> It is not really a matter of preference. One is correct; the other is not.
>>
>> While simple errors can of course be forgiven, I cannot understand why you
>> would deliberately repeat an error once it has been pointed out to you.
>
> Because I think that people sometimes use those two interchangeably.
> So I said I would defer to the maintainers.
>
I have to agree with Akashi-san here: while you are technically
correct, the reality is that the MiB is not as widely adopted as you
suggest, and there is no ambiguity whatsoever in this particular case
(i.e., when referring to blocks of RAM), so I feel it is somewhat
counterproductive to confuse reviewers by stating 'You still have
typos here.' without specifying that it is MiB vs MB that you are
actually referring to.
These patches are complex enough as they are, so could we *please*
focus on the things that matter?
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
David Woodhouse <dwmw2@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
James Morse <james.morse@arm.com>,
Geoff Levand <geoff@infradead.org>,
Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
Dave Young <dyoung@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Pratyush Anand <panand@redhat.com>,
Sameer Goel <sgoel@codeaurora.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Mark Salter <msalter@redhat.com>
Subject: Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel
Date: Tue, 4 Apr 2017 08:39:28 +0100 [thread overview]
Message-ID: <CAKv+Gu-3MiGYS=Eh0zfMp41ah6B==HbLFVSh7+kHX_hfHTut-Q@mail.gmail.com> (raw)
In-Reply-To: <20170404073504.GI16309@linaro.org>
On 4 April 2017 at 08:35, AKASHI Takahiro <takahiro.akashi@linaro.org> wrote:
> On Tue, Apr 04, 2017 at 06:14:55AM -0000, David Woodhouse wrote:
>>
>> > On Mon, Apr 03, 2017 at 09:18:12AM +0100, David Woodhouse wrote:
>> >>
>> >> You still have typos here.
>> >
>> > I'd like to defer to the maintainers whether we prefer MiB over MB.
>>
>> It is not really a matter of preference. One is correct; the other is not.
>>
>> While simple errors can of course be forgiven, I cannot understand why you
>> would deliberately repeat an error once it has been pointed out to you.
>
> Because I think that people sometimes use those two interchangeably.
> So I said I would defer to the maintainers.
>
I have to agree with Akashi-san here: while you are technically
correct, the reality is that the MiB is not as widely adopted as you
suggest, and there is no ambiguity whatsoever in this particular case
(i.e., when referring to blocks of RAM), so I feel it is somewhat
counterproductive to confuse reviewers by stating 'You still have
typos here.' without specifying that it is MiB vs MB that you are
actually referring to.
These patches are complex enough as they are, so could we *please*
focus on the things that matter?
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-04-04 7:39 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 6:48 [PATCH v34 00/14] arm64: add kdump support AKASHI Takahiro
2017-03-28 6:48 ` AKASHI Takahiro
2017-03-28 6:50 ` [PATCH v34 01/14] memblock: add memblock_clear_nomap() AKASHI Takahiro
2017-03-28 6:50 ` AKASHI Takahiro
2017-03-28 6:50 ` AKASHI Takahiro
2017-03-28 9:47 ` Ard Biesheuvel
2017-03-28 9:47 ` Ard Biesheuvel
2017-03-28 9:47 ` Ard Biesheuvel
2017-03-28 6:50 ` [PATCH v34 02/14] memblock: add memblock_cap_memory_range() AKASHI Takahiro
2017-03-28 6:50 ` AKASHI Takahiro
2017-03-28 6:50 ` AKASHI Takahiro
2017-03-28 9:48 ` Ard Biesheuvel
2017-03-28 9:48 ` Ard Biesheuvel
2017-03-28 9:48 ` Ard Biesheuvel
2017-03-28 6:51 ` [PATCH v34 03/14] arm64: limit memory regions based on DT property, usable-memory-range AKASHI Takahiro
2017-03-28 6:51 ` AKASHI Takahiro
2017-03-28 9:50 ` Ard Biesheuvel
2017-03-28 9:50 ` Ard Biesheuvel
2017-03-28 6:51 ` [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel AKASHI Takahiro
2017-03-28 6:51 ` AKASHI Takahiro
2017-03-28 9:52 ` Ard Biesheuvel
2017-03-28 9:52 ` Ard Biesheuvel
2017-04-03 8:18 ` David Woodhouse
2017-04-03 8:18 ` David Woodhouse
2017-04-04 5:41 ` AKASHI Takahiro
2017-04-04 5:41 ` AKASHI Takahiro
2017-04-04 6:14 ` David Woodhouse
2017-04-04 6:14 ` David Woodhouse
2017-04-04 7:35 ` AKASHI Takahiro
2017-04-04 7:35 ` AKASHI Takahiro
2017-04-04 7:39 ` Ard Biesheuvel [this message]
2017-04-04 7:39 ` Ard Biesheuvel
2017-04-04 7:44 ` David Woodhouse
2017-04-04 7:44 ` David Woodhouse
2017-04-04 9:26 ` Will Deacon
2017-04-04 9:26 ` Will Deacon
2017-04-13 12:15 ` David Woodhouse
2017-04-13 12:15 ` David Woodhouse
2017-04-13 12:17 ` [PATCH 1/2] arm64: Fix power-of-ten vs. power-of-two prefixes in user-visible messages David Woodhouse
2017-04-13 12:17 ` David Woodhouse
2017-04-19 9:29 ` Geert Uytterhoeven
2017-04-19 9:29 ` Geert Uytterhoeven
2017-04-13 12:18 ` [PATCH 2/2] arm64: Fix power-of-ten vs. power-of-two prefixes in comments etc David Woodhouse
2017-04-13 12:18 ` David Woodhouse
2017-04-16 23:12 ` Simon Horman
2017-04-16 23:12 ` Simon Horman
2017-04-16 23:12 ` Simon Horman
2017-04-17 11:54 ` Geert Uytterhoeven
2017-04-17 11:54 ` Geert Uytterhoeven
2017-04-17 11:54 ` Geert Uytterhoeven
2017-04-18 14:13 ` Catalin Marinas
2017-04-18 14:13 ` Catalin Marinas
2017-04-18 14:13 ` Catalin Marinas
2017-04-19 14:25 ` Olof Johansson
2017-04-19 14:25 ` Olof Johansson
2017-04-19 14:25 ` Olof Johansson
2017-03-28 6:51 ` [PATCH v34 05/14] arm64: mm: add set_memory_valid() AKASHI Takahiro
2017-03-28 6:51 ` AKASHI Takahiro
2017-03-28 9:54 ` Ard Biesheuvel
2017-03-28 9:54 ` Ard Biesheuvel
2017-03-28 6:51 ` [PATCH v34 06/14] arm64: kdump: protect crash dump kernel memory AKASHI Takahiro
2017-03-28 6:51 ` AKASHI Takahiro
2017-03-28 10:07 ` Ard Biesheuvel
2017-03-28 10:07 ` Ard Biesheuvel
2017-03-28 11:07 ` AKASHI Takahiro
2017-03-28 11:07 ` AKASHI Takahiro
2017-03-28 14:05 ` Ard Biesheuvel
2017-03-28 14:05 ` Ard Biesheuvel
2017-03-30 9:56 ` AKASHI Takahiro
2017-03-30 9:56 ` AKASHI Takahiro
2017-03-30 13:58 ` Ard Biesheuvel
2017-03-30 13:58 ` Ard Biesheuvel
2017-04-03 2:28 ` AKASHI Takahiro
2017-04-03 2:28 ` AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 07/14] arm64: hibernate: preserve kdump image around hibernation AKASHI Takahiro
2017-03-28 6:51 ` AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 08/14] arm64: kdump: implement machine_crash_shutdown() AKASHI Takahiro
2017-03-28 6:51 ` AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 09/14] arm64: kdump: add VMCOREINFO's for user-space tools AKASHI Takahiro
2017-03-28 6:51 ` AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 10/14] arm64: kdump: provide /proc/vmcore file AKASHI Takahiro
2017-03-28 6:51 ` AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 11/14] arm64: kdump: enable kdump in defconfig AKASHI Takahiro
2017-03-28 6:51 ` AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 12/14] Documentation: kdump: describe arm64 port AKASHI Takahiro
2017-03-28 6:51 ` AKASHI Takahiro
[not found] ` <20170328064831.15894-1-takahiro.akashi-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-03-28 6:52 ` [PATCH v34 13/14] Documentation: dt: chosen properties for arm64 kdump AKASHI Takahiro
2017-03-28 6:52 ` AKASHI Takahiro
2017-03-28 6:52 ` AKASHI Takahiro
2017-03-28 6:53 ` [PATCH v34 14/14] efi/libstub/arm*: Set default address and size cells values for an empty dtb AKASHI Takahiro
2017-03-28 6:53 ` AKASHI Takahiro
2017-03-28 6:53 ` AKASHI Takahiro
2017-03-28 10:08 ` Ard Biesheuvel
2017-03-28 10:08 ` Ard Biesheuvel
2017-03-28 10:08 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-3MiGYS=Eh0zfMp41ah6B==HbLFVSh7+kHX_hfHTut-Q@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.