[PATCH] pstore: return error code (if any) from efi_pstore_write

[PATCH] pstore: return error code (if any) from efi_pstore_write

[Kalugin, Evgeny]

From 655a261d71af9de62e0e23ae0eb6f75037ae5e3e Mon Sep 17 00:00:00 2001
From: Evgeny Kalugin <evgeny.kalugin@intel.com>
Date: Tue, 7 Mar 2017 14:22:25 +0000
Subject: [PATCH] pstore: return error code (if any) from efi_pstore_write

For some reason return value from actual variable setting was ignored.
With this change error code get transferred upwards through call stack.

Signed-off-by: Evgeny Kalugin <evgeny.kalugin@intel.com>
---
 drivers/firmware/efi/efi-pstore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
index f402ba2..2ea808e 100644
--- a/drivers/firmware/efi/efi-pstore.c
+++ b/drivers/firmware/efi/efi-pstore.c
@@ -274,7 +274,7 @@ static int efi_pstore_write(enum pstore_type_id type,
 	for (i = 0; i < DUMP_NAME_LEN; i++)
 		efi_name[i] = name[i];
 
-	efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
+	ret = efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
 			      !pstore_cannot_block_path(reason),
 			      size, psi->buf);
 
-- 
1.9.1

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [PATCH] pstore: return error code (if any) from efi_pstore_write

[Ard Biesheuvel]

On 13 March 2017 at 12:46, Kalugin, Evgeny <evgeny.kalugin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> From 655a261d71af9de62e0e23ae0eb6f75037ae5e3e Mon Sep 17 00:00:00 2001
> From: Evgeny Kalugin <evgeny.kalugin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Date: Tue, 7 Mar 2017 14:22:25 +0000
> Subject: [PATCH] pstore: return error code (if any) from efi_pstore_write
>
> For some reason return value from actual variable setting was ignored.
> With this change error code get transferred upwards through call stack.
>
> Signed-off-by: Evgeny Kalugin <evgeny.kalugin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Thanks for the patch.

Could you give a bit more detail on how this broke things for you?

> ---
>  drivers/firmware/efi/efi-pstore.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
> index f402ba2..2ea808e 100644
> --- a/drivers/firmware/efi/efi-pstore.c
> +++ b/drivers/firmware/efi/efi-pstore.c
> @@ -274,7 +274,7 @@ static int efi_pstore_write(enum pstore_type_id type,
>         for (i = 0; i < DUMP_NAME_LEN; i++)
>                 efi_name[i] = name[i];
>
> -       efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
> +       ret = efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
>                               !pstore_cannot_block_path(reason),
>                               size, psi->buf);
>
> --
> 1.9.1
>
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.

Re: [PATCH] pstore: return error code (if any) from efi_pstore_write

[Kalugin, Evgeny]

On Tue, 2017-03-14 at 08:24 +0000, Ard Biesheuvel wrote:
> On 13 March 2017 at 12:46, Kalugin, Evgeny <evgeny.kalugin@intel.com> wrote:
> > From 655a261d71af9de62e0e23ae0eb6f75037ae5e3e Mon Sep 17 00:00:00 2001
> > From: Evgeny Kalugin <evgeny.kalugin@intel.com>
> > Date: Tue, 7 Mar 2017 14:22:25 +0000
> > Subject: [PATCH] pstore: return error code (if any) from efi_pstore_write
> >
> > For some reason return value from actual variable setting was ignored.
> > With this change error code get transferred upwards through call stack.
> >
> > Signed-off-by: Evgeny Kalugin <evgeny.kalugin@intel.com>
> 
> Thanks for the patch.
> 
> Could you give a bit more detail on how this broke things for you?

Well, it haven't broken much things for me yet. I just found it when
tried to debug one problem in efi-pstore. There I was about to watch
return value from write call, when noticed that it is always zero and
that has not so much sense obviously.

> 
> > ---
> >  drivers/firmware/efi/efi-pstore.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
> > index f402ba2..2ea808e 100644
> > --- a/drivers/firmware/efi/efi-pstore.c
> > +++ b/drivers/firmware/efi/efi-pstore.c
> > @@ -274,7 +274,7 @@ static int efi_pstore_write(enum pstore_type_id type,
> >         for (i = 0; i < DUMP_NAME_LEN; i++)
> >                 efi_name[i] = name[i];
> >
> > -       efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
> > +       ret = efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
> >                               !pstore_cannot_block_path(reason),
> >                               size, psi->buf);
> >
> > --
> > 1.9.1
> >

Re: [PATCH] pstore: return error code (if any) from efi_pstore_write

[Ard Biesheuvel]

On 14 March 2017 at 09:59, Kalugin, Evgeny <evgeny.kalugin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> On Tue, 2017-03-14 at 08:24 +0000, Ard Biesheuvel wrote:
>> On 13 March 2017 at 12:46, Kalugin, Evgeny <evgeny.kalugin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>> > From 655a261d71af9de62e0e23ae0eb6f75037ae5e3e Mon Sep 17 00:00:00 2001
>> > From: Evgeny Kalugin <evgeny.kalugin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>> > Date: Tue, 7 Mar 2017 14:22:25 +0000
>> > Subject: [PATCH] pstore: return error code (if any) from efi_pstore_write
>> >
>> > For some reason return value from actual variable setting was ignored.
>> > With this change error code get transferred upwards through call stack.
>> >
>> > Signed-off-by: Evgeny Kalugin <evgeny.kalugin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>
>> Thanks for the patch.
>>
>> Could you give a bit more detail on how this broke things for you?
>
> Well, it haven't broken much things for me yet. I just found it when
> tried to debug one problem in efi-pstore. There I was about to watch
> return value from write call, when noticed that it is always zero and
> that has not so much sense obviously.
>

Queued for v4.12, thanks