From: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Russell King - ARM Linux <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Matt Fleming
<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Graeme Gregory
<graeme.gregory-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Leif Lindholm
<leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2] efi: arm: enable DMI/SMBIOS
Date: Thu, 1 Jun 2017 16:51:05 +0000 [thread overview]
Message-ID: <CAKv+Gu9czLm=i852=GAnx=pmGDDNahTTVpVxWzAfNgzmOWdsaw@mail.gmail.com> (raw)
In-Reply-To: <20170601163614.GC22219-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
On 1 June 2017 at 16:36, Russell King - ARM Linux <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org> wrote:
> On Thu, Jun 01, 2017 at 10:52:13AM +0000, Ard Biesheuvel wrote:
>> (add Russell to To: field)
>
> Thanks.
>
>> On 1 June 2017 at 10:45, Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> > Wire up the existing support for SMBIOS tables (aka DMI), by moving the
>> > arm64 init code to drivers/firmware/efi/arm-runtime.c (which is shared
>> > between ARM and arm64), and adding a asm/dmi.h header to ARM that defines
>> > the mapping routines for the firmware tables.
>> >
>> > This allows userspace to access these tables to discover system information
>> > exposed by the firmware. It also sets the hardware name used in crash
>> > dumps, e.g.,
>> >
>> > Unable to handle kernel NULL pointer dereference at virtual address 00000000
>> > pgd = ed3c0000
>> > [00000000] *pgd=bf1f3835
>> > Internal error: Oops: 817 [#1] SMP THUMB2
>> > Modules linked in:
>> > CPU: 0 PID: 759 Comm: bash Not tainted 4.10.0-09601-g0e8f38792120-dirty #112
>> > Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015
>> > ^^^
>> >
>> > NOTE: This does *NOT* enable or encourage the use of DMI quirks, i.e., the
>> > the practice of identifying the platform via DMI to decide whether
>> > certain workarounds for buggy hardware and/or firmware need to be
>> > enabled. This would require the DMI subsystem to be enabled much
>> > earlier than we do on ARM, which is non-trivial.
>
> I think that needs to be documented somewhere else other than the commit
> message, although I'm not sure where.
>
>> > Cc: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
>> > Cc: Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
>> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>
>> Russell, if you have no objections to this patch, may we have your ack
>> please? I will take it via the EFI tree then.
>
> Acked-by: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
>
Thanks. I will copy the NOTE to the Kconfig help text
WARNING: multiple messages have this Message-ID (diff)
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] efi: arm: enable DMI/SMBIOS
Date: Thu, 1 Jun 2017 16:51:05 +0000 [thread overview]
Message-ID: <CAKv+Gu9czLm=i852=GAnx=pmGDDNahTTVpVxWzAfNgzmOWdsaw@mail.gmail.com> (raw)
In-Reply-To: <20170601163614.GC22219@n2100.armlinux.org.uk>
On 1 June 2017 at 16:36, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> On Thu, Jun 01, 2017 at 10:52:13AM +0000, Ard Biesheuvel wrote:
>> (add Russell to To: field)
>
> Thanks.
>
>> On 1 June 2017 at 10:45, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> > Wire up the existing support for SMBIOS tables (aka DMI), by moving the
>> > arm64 init code to drivers/firmware/efi/arm-runtime.c (which is shared
>> > between ARM and arm64), and adding a asm/dmi.h header to ARM that defines
>> > the mapping routines for the firmware tables.
>> >
>> > This allows userspace to access these tables to discover system information
>> > exposed by the firmware. It also sets the hardware name used in crash
>> > dumps, e.g.,
>> >
>> > Unable to handle kernel NULL pointer dereference at virtual address 00000000
>> > pgd = ed3c0000
>> > [00000000] *pgd=bf1f3835
>> > Internal error: Oops: 817 [#1] SMP THUMB2
>> > Modules linked in:
>> > CPU: 0 PID: 759 Comm: bash Not tainted 4.10.0-09601-g0e8f38792120-dirty #112
>> > Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015
>> > ^^^
>> >
>> > NOTE: This does *NOT* enable or encourage the use of DMI quirks, i.e., the
>> > the practice of identifying the platform via DMI to decide whether
>> > certain workarounds for buggy hardware and/or firmware need to be
>> > enabled. This would require the DMI subsystem to be enabled much
>> > earlier than we do on ARM, which is non-trivial.
>
> I think that needs to be documented somewhere else other than the commit
> message, although I'm not sure where.
>
>> > Cc: Matt Fleming <matt@codeblueprint.co.uk>
>> > Cc: Russell King <linux@armlinux.org.uk>
>> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>
>> Russell, if you have no objections to this patch, may we have your ack
>> please? I will take it via the EFI tree then.
>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
>
Thanks. I will copy the NOTE to the Kconfig help text
next prev parent reply other threads:[~2017-06-01 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 10:45 [PATCH v2] efi: arm: enable DMI/SMBIOS Ard Biesheuvel
2017-06-01 10:45 ` Ard Biesheuvel
[not found] ` <20170601104554.21267-1-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-06-01 10:52 ` Ard Biesheuvel
2017-06-01 10:52 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-OK=0HSG5KmsZ+Zs0Xu2ox5Cva+Nbtgz0DXigk3e3aiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-01 16:36 ` Russell King - ARM Linux
2017-06-01 16:36 ` Russell King - ARM Linux
[not found] ` <20170601163614.GC22219-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-06-01 16:51 ` Ard Biesheuvel [this message]
2017-06-01 16:51 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9czLm=i852=GAnx=pmGDDNahTTVpVxWzAfNgzmOWdsaw@mail.gmail.com' \
--to=ard.biesheuvel-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=graeme.gregory-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.