All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Nathan Lynch <nathan_lynch@mentor.com>,
	Will Deacon <will.deacon@arm.com>,
	Marek Belisko <marek@goldelico.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h
Date: Wed, 30 Sep 2015 18:02:58 +0200	[thread overview]
Message-ID: <CAKv+Gu_098GVMeJPjDWaQ-uXek_cGUe4UMVy+fMdKw=_C+P7Tg@mail.gmail.com> (raw)
In-Reply-To: <2039A9BE-ADA4-4D28-84F4-C8B9D76834AD@goldelico.com>

On 30 September 2015 at 17:56, H. Nikolaus Schaller <hns@goldelico.com> wrote:
> If the host toolchain is not glibc based then the arm kernel build
> fails with
>
>  HOSTCC  arch/arm/vdso/vdsomunge
>  arch/arm/vdso/vdsomunge.c:48:22: fatal error: byteswap.h: No such file or directory
>
> Observed with omap2plus_defconfig and compile on Mac OS X with arm ELF
> cross-compiler.
>
> Reason: byteswap.h is a glibc only header.
>
> Changed to detect the host and include the right file as described at:
>
>  https://bugs.freedesktop.org/show_bug.cgi?id=8882
>
> Tested to compile on Mac OS X 10.9.5 host.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> arch/arm/vdso/vdsomunge.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/vdso/vdsomunge.c b/arch/arm/vdso/vdsomunge.c
> index aedec81..5364cea 100644
> --- a/arch/arm/vdso/vdsomunge.c
> +++ b/arch/arm/vdso/vdsomunge.c
> @@ -45,7 +45,25 @@
>  * it does.
>  */
>
> +#if defined(__linux__)
> #include <byteswap.h>
> +#elif defined(__OpenBSD__)
> +#include <sys/endian.h>
> +#define bswap_16 __swap16
> +#define bswap_32 __swap32
> +#define bswap_64 __swap64
> +#elif defined(__APPLE__)
> +#include <libkern/OSByteOrder.h>
> +#define bswap_16 OSSwapInt16
> +#define bswap_32 OSSwapInt32
> +#define bswap_64 OSSwapInt64
> +#else
> +#include <sys/endian.h>
> +#define bswap_16 bswap16
> +#define bswap_32 bswap32
> +#define bswap_64 bswap64
> +#endif
> +

Have you tried this?

#define bswap_16 __builtin_bswap16
#define bswap_32 __builtin_bswap32
#define bswap_64 __builtin_bswap64

https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html

WARNING: multiple messages have this Message-ID (diff)
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h
Date: Wed, 30 Sep 2015 18:02:58 +0200	[thread overview]
Message-ID: <CAKv+Gu_098GVMeJPjDWaQ-uXek_cGUe4UMVy+fMdKw=_C+P7Tg@mail.gmail.com> (raw)
In-Reply-To: <2039A9BE-ADA4-4D28-84F4-C8B9D76834AD@goldelico.com>

On 30 September 2015 at 17:56, H. Nikolaus Schaller <hns@goldelico.com> wrote:
> If the host toolchain is not glibc based then the arm kernel build
> fails with
>
>  HOSTCC  arch/arm/vdso/vdsomunge
>  arch/arm/vdso/vdsomunge.c:48:22: fatal error: byteswap.h: No such file or directory
>
> Observed with omap2plus_defconfig and compile on Mac OS X with arm ELF
> cross-compiler.
>
> Reason: byteswap.h is a glibc only header.
>
> Changed to detect the host and include the right file as described at:
>
>  https://bugs.freedesktop.org/show_bug.cgi?id=8882
>
> Tested to compile on Mac OS X 10.9.5 host.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> arch/arm/vdso/vdsomunge.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/vdso/vdsomunge.c b/arch/arm/vdso/vdsomunge.c
> index aedec81..5364cea 100644
> --- a/arch/arm/vdso/vdsomunge.c
> +++ b/arch/arm/vdso/vdsomunge.c
> @@ -45,7 +45,25 @@
>  * it does.
>  */
>
> +#if defined(__linux__)
> #include <byteswap.h>
> +#elif defined(__OpenBSD__)
> +#include <sys/endian.h>
> +#define bswap_16 __swap16
> +#define bswap_32 __swap32
> +#define bswap_64 __swap64
> +#elif defined(__APPLE__)
> +#include <libkern/OSByteOrder.h>
> +#define bswap_16 OSSwapInt16
> +#define bswap_32 OSSwapInt32
> +#define bswap_64 OSSwapInt64
> +#else
> +#include <sys/endian.h>
> +#define bswap_16 bswap16
> +#define bswap_32 bswap32
> +#define bswap_64 bswap64
> +#endif
> +

Have you tried this?

#define bswap_16 __builtin_bswap16
#define bswap_32 __builtin_bswap32
#define bswap_64 __builtin_bswap64

https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html

  reply	other threads:[~2015-09-30 16:03 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1443628457.git.hns@goldelico.com>
2015-09-30 15:56 ` [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h H. Nikolaus Schaller
2015-09-30 15:56   ` H. Nikolaus Schaller
2015-09-30 16:02   ` Ard Biesheuvel [this message]
2015-09-30 16:02     ` Ard Biesheuvel
2015-09-30 16:13     ` H. Nikolaus Schaller
2015-09-30 16:13       ` H. Nikolaus Schaller
2015-09-30 16:17       ` Ard Biesheuvel
2015-09-30 16:17         ` Ard Biesheuvel
2015-09-30 17:25         ` H. Nikolaus Schaller
2015-09-30 17:25           ` H. Nikolaus Schaller
2015-09-30 17:37         ` Nathan Lynch
2015-09-30 17:37           ` Nathan Lynch
2015-09-30 17:47           ` H. Nikolaus Schaller
2015-09-30 17:47             ` H. Nikolaus Schaller
2015-09-30 18:17             ` Nathan Lynch
2015-09-30 18:17               ` Nathan Lynch
2015-09-30 19:08               ` H. Nikolaus Schaller
2015-09-30 19:08                 ` H. Nikolaus Schaller
     [not found]                 ` <cover.1443791320.git.hns@goldelico.com>
2015-10-02 13:10                   ` [PATCH] ARM: fix vdsomunge not to depend " H. Nikolaus Schaller
2015-10-03  8:20                   ` H. Nikolaus Schaller
2015-10-03 20:46   ` [PATCH v2] " H. Nikolaus Schaller
2015-10-03 20:46     ` H. Nikolaus Schaller
2015-10-14 12:47     ` H. Nikolaus Schaller
2015-10-14 12:47       ` H. Nikolaus Schaller
2015-10-14 14:16       ` Nathan Lynch
2015-10-14 14:16         ` Nathan Lynch
2015-10-15  5:52         ` H. Nikolaus Schaller
2015-10-15  5:52           ` H. Nikolaus Schaller
2015-10-15 16:37           ` Russell King - ARM Linux
2015-10-15 16:37             ` Russell King - ARM Linux
2015-10-15 16:52             ` H. Nikolaus Schaller
2015-10-15 16:52               ` H. Nikolaus Schaller
2015-10-15 17:07           ` Nathan Lynch
2015-10-15 17:07             ` Nathan Lynch
2015-10-15 17:16             ` H. Nikolaus Schaller
2015-10-15 17:16               ` H. Nikolaus Schaller
2015-10-15 17:23               ` Nathan Lynch
2015-10-15 17:23                 ` Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu_098GVMeJPjDWaQ-uXek_cGUe4UMVy+fMdKw=_C+P7Tg@mail.gmail.com' \
    --to=ard.biesheuvel@linaro.org \
    --cc=hns@goldelico.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek@goldelico.com \
    --cc=nathan_lynch@mentor.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=szabolcs.nagy@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.