All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	kernel-hardening@lists.openwall.com,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Kees Cook <keescook@chromium.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Matt Fleming <matt@codeblueprint.co.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	Sharma Bhupesh <bhupesh.sharma@freescale.com>,
	Stuart Yoder <stuart.yoder@freescale.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Christoffer Dall <christoffer.dall@linaro.org>,
	Laura Abbott <labbott@fedoraproject.org>
Subject: Re: [PATCH v4 00/22] arm64: implement support for KASLR
Date: Fri, 29 Jan 2016 19:49:19 +0100	[thread overview]
Message-ID: <CAKv+Gu_ANOm_skhVVBwK-1+yVP614FWeCo87aGN7iFjmUj95Ug@mail.gmail.com> (raw)
In-Reply-To: <20160129182657.GI20099@e104818-lin.cambridge.arm.com>

giOn 29 January 2016 at 19:26, Catalin Marinas <catalin.marinas@arm.com> wrote:
> Hi Ard,
>
> On Tue, Jan 26, 2016 at 06:10:27PM +0100, Ard Biesheuvel wrote:
>> Code can be found here:
>> git://git.linaro.org/people/ard.biesheuvel/linux-arm.git arm64-kaslr-v4a
>> https://git.linaro.org/people/ard.biesheuvel/linux-arm.git/shortlog/refs/heads/arm64-kaslr-v4a
>
> The overall series looks fine but I'd like more time to review the KASLR
> part together with the module PLT stuff.
>
> So could you please split this series in 2-3 parts for easy merging
> (possibly without the KASLR part, it depends on how the review goes)?

Sure

> It
> looks like a mix of features in random order like huge-vmap, relative
> extable, kernel memory layout changes, kernel load address, PIE and
> KASLR. So something like:
>
> 1. relative extable

This has been picked up by akpm in the mean time

> 2. huge-vmap

This is a single patch which is completely independent. I don't expect
it to conflict when applied in isolation.

> 3. kernel memory layout changes (moving kernel to the base of vmalloc
> range)
> 4. allow kernel loading at different phys offsets
> 5. module PLTs, relocations, PIE, relative kallsyms, KASLR

Relative kallsyms has also been picked up by akpm

> 6. efi_get_random_bytes
>
> 1-4 can be in the same branch but I currently find it hard to
> cherry-pick the non-PIE/non-KASLR patches without conflicts.
>

I think 3 logically coherent series that apply in sequence is
feasible. I will look into this on Monday

-- 
Ard.

WARNING: multiple messages have this Message-ID (diff)
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 00/22] arm64: implement support for KASLR
Date: Fri, 29 Jan 2016 19:49:19 +0100	[thread overview]
Message-ID: <CAKv+Gu_ANOm_skhVVBwK-1+yVP614FWeCo87aGN7iFjmUj95Ug@mail.gmail.com> (raw)
In-Reply-To: <20160129182657.GI20099@e104818-lin.cambridge.arm.com>

giOn 29 January 2016 at 19:26, Catalin Marinas <catalin.marinas@arm.com> wrote:
> Hi Ard,
>
> On Tue, Jan 26, 2016 at 06:10:27PM +0100, Ard Biesheuvel wrote:
>> Code can be found here:
>> git://git.linaro.org/people/ard.biesheuvel/linux-arm.git arm64-kaslr-v4a
>> https://git.linaro.org/people/ard.biesheuvel/linux-arm.git/shortlog/refs/heads/arm64-kaslr-v4a
>
> The overall series looks fine but I'd like more time to review the KASLR
> part together with the module PLT stuff.
>
> So could you please split this series in 2-3 parts for easy merging
> (possibly without the KASLR part, it depends on how the review goes)?

Sure

> It
> looks like a mix of features in random order like huge-vmap, relative
> extable, kernel memory layout changes, kernel load address, PIE and
> KASLR. So something like:
>
> 1. relative extable

This has been picked up by akpm in the mean time

> 2. huge-vmap

This is a single patch which is completely independent. I don't expect
it to conflict when applied in isolation.

> 3. kernel memory layout changes (moving kernel to the base of vmalloc
> range)
> 4. allow kernel loading at different phys offsets
> 5. module PLTs, relocations, PIE, relative kallsyms, KASLR

Relative kallsyms has also been picked up by akpm

> 6. efi_get_random_bytes
>
> 1-4 can be in the same branch but I currently find it hard to
> cherry-pick the non-PIE/non-KASLR patches without conflicts.
>

I think 3 logically coherent series that apply in sequence is
feasible. I will look into this on Monday

-- 
Ard.

WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	kernel-hardening@lists.openwall.com,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Kees Cook <keescook@chromium.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Matt Fleming <matt@codeblueprint.co.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	Sharma Bhupesh <bhupesh.sharma@freescale.com>,
	Stuart Yoder <stuart.yoder@freescale.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Christoffer Dall <christoffer.dall@linaro.org>,
	Laura Abbott <labbott@fedoraproject.org>
Subject: [kernel-hardening] Re: [PATCH v4 00/22] arm64: implement support for KASLR
Date: Fri, 29 Jan 2016 19:49:19 +0100	[thread overview]
Message-ID: <CAKv+Gu_ANOm_skhVVBwK-1+yVP614FWeCo87aGN7iFjmUj95Ug@mail.gmail.com> (raw)
In-Reply-To: <20160129182657.GI20099@e104818-lin.cambridge.arm.com>

giOn 29 January 2016 at 19:26, Catalin Marinas <catalin.marinas@arm.com> wrote:
> Hi Ard,
>
> On Tue, Jan 26, 2016 at 06:10:27PM +0100, Ard Biesheuvel wrote:
>> Code can be found here:
>> git://git.linaro.org/people/ard.biesheuvel/linux-arm.git arm64-kaslr-v4a
>> https://git.linaro.org/people/ard.biesheuvel/linux-arm.git/shortlog/refs/heads/arm64-kaslr-v4a
>
> The overall series looks fine but I'd like more time to review the KASLR
> part together with the module PLT stuff.
>
> So could you please split this series in 2-3 parts for easy merging
> (possibly without the KASLR part, it depends on how the review goes)?

Sure

> It
> looks like a mix of features in random order like huge-vmap, relative
> extable, kernel memory layout changes, kernel load address, PIE and
> KASLR. So something like:
>
> 1. relative extable

This has been picked up by akpm in the mean time

> 2. huge-vmap

This is a single patch which is completely independent. I don't expect
it to conflict when applied in isolation.

> 3. kernel memory layout changes (moving kernel to the base of vmalloc
> range)
> 4. allow kernel loading at different phys offsets
> 5. module PLTs, relocations, PIE, relative kallsyms, KASLR

Relative kallsyms has also been picked up by akpm

> 6. efi_get_random_bytes
>
> 1-4 can be in the same branch but I currently find it hard to
> cherry-pick the non-PIE/non-KASLR patches without conflicts.
>

I think 3 logically coherent series that apply in sequence is
feasible. I will look into this on Monday

-- 
Ard.

  reply	other threads:[~2016-01-29 18:49 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 17:10 [PATCH v4 00/22] arm64: implement support for KASLR Ard Biesheuvel
2016-01-26 17:10 ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10 ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 01/22] of/fdt: make memblock minimum physical address arch configurable Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 02/22] arm64: introduce KIMAGE_VADDR as the virtual base of the kernel region Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 03/22] arm64: pgtable: implement static [pte|pmd|pud]_offset variants Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 04/22] arm64: decouple early fixmap init from linear mapping Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 05/22] arm64: kvm: deal with kernel symbols outside of " Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:45   ` Marc Zyngier
2016-01-26 17:45     ` [kernel-hardening] " Marc Zyngier
2016-01-26 17:45     ` Marc Zyngier
2016-01-26 17:10 ` [PATCH v4 06/22] arm64: add support for ioremap() block mappings Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 07/22] arm64: move kernel image to base of vmalloc area Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 08/22] arm64: add support for module PLTs Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 09/22] extable: add support for relative extables to search and sort routines Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 10/22] arm64: switch to relative exception tables Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 11/22] arm64: avoid R_AARCH64_ABS64 relocations for Image header fields Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 12/22] arm64: avoid dynamic relocations in early boot code Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 13/22] arm64: allow kernel Image to be loaded anywhere in physical memory Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 14/22] arm64: make asm/elf.h available to asm files Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:42   ` Mark Rutland
2016-01-26 17:42     ` [kernel-hardening] " Mark Rutland
2016-01-26 17:42     ` Mark Rutland
2016-01-26 17:10 ` [PATCH v4 15/22] scripts/sortextable: add support for ET_DYN binaries Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 23:25   ` Kees Cook
2016-01-26 23:25     ` [kernel-hardening] " Kees Cook
2016-01-26 23:25     ` Kees Cook
2016-01-26 17:10 ` [PATCH v4 16/22] kallsyms: add support for relative offsets in kallsyms address table Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 17/22] arm64: add support for building the kernel as a relocate PIE binary Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 18/22] arm64: add support for kernel ASLR Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 19/22] efi: stub: implement efi_get_random_bytes() based on EFI_RNG_PROTOCOL Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 20/22] efi: stub: add implementation of efi_random_alloc() Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 23:52   ` Kees Cook
2016-01-26 23:52     ` [kernel-hardening] " Kees Cook
2016-01-26 23:52     ` Kees Cook
2016-01-29 15:39   ` Matt Fleming
2016-01-29 15:39     ` [kernel-hardening] " Matt Fleming
2016-01-29 15:39     ` Matt Fleming
2016-01-26 17:10 ` [PATCH v4 21/22] efi: stub: use high allocation for converted command line Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-26 17:10 ` [PATCH v4 22/22] arm64: efi: invoke EFI_RNG_PROTOCOL to supply KASLR randomness Ard Biesheuvel
2016-01-26 17:10   ` [kernel-hardening] " Ard Biesheuvel
2016-01-26 17:10   ` Ard Biesheuvel
2016-01-29 15:57   ` Matt Fleming
2016-01-29 15:57     ` [kernel-hardening] " Matt Fleming
2016-01-29 15:57     ` Matt Fleming
2016-01-29 18:26 ` [PATCH v4 00/22] arm64: implement support for KASLR Catalin Marinas
2016-01-29 18:26   ` [kernel-hardening] " Catalin Marinas
2016-01-29 18:26   ` Catalin Marinas
2016-01-29 18:49   ` Ard Biesheuvel [this message]
2016-01-29 18:49     ` [kernel-hardening] " Ard Biesheuvel
2016-01-29 18:49     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu_ANOm_skhVVBwK-1+yVP614FWeCo87aGN7iFjmUj95Ug@mail.gmail.com \
    --to=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bhupesh.sharma@freescale.com \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=labbott@fedoraproject.org \
    --cc=leif.lindholm@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=matt@codeblueprint.co.uk \
    --cc=stuart.yoder@freescale.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.