From: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Leif Lindholm
<leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH 2/2] arm*: efi: drop writable mapping of the UEFI System table
Date: Wed, 23 Mar 2016 23:11:53 +0100 [thread overview]
Message-ID: <CAKv+Gu_p=nWMbyciC9QXqnLEgqouxiERn6kcLv1V+2tDc74tbA@mail.gmail.com> (raw)
In-Reply-To: <20160323161624.GG11676-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
On 23 March 2016 at 17:16, Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> wrote:
> On Tue, 22 Mar, at 04:08:24PM, Ard Biesheuvel wrote:
>>
>> This patch causes a warning I hadn't spotted before sending it out.
>> Could you fold this in please?
>>
>> diff --git a/drivers/firmware/efi/arm-runtime.c
>> b/drivers/firmware/efi/arm-runtime.c
>> index 6c97d4884fc7..fe749da9997e 100644
>> --- a/drivers/firmware/efi/arm-runtime.c
>> +++ b/drivers/firmware/efi/arm-runtime.c
>> @@ -72,8 +72,8 @@ static bool __init efi_virtmap_init(void)
>> */
>> if (efi_system_table >= phys &&
>> efi_system_table < phys + (md->num_pages * EFI_PAGE_SIZE)) {
>> - efi.systab = (void *)(efi_system_table - phys +
>> - md->virt_addr);
>> + efi.systab = (void *)(unsigned long)(efi_system_table -
>> + phys + md->virt_addr);
>> systab_found = true;
>> }
>> }
>
> Done, please check,
>
> https://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/commit/?h=next&id=4fd5c619dcf4f3d2c86d4a686ce66fc01e877a08
Looks good to me, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm*: efi: drop writable mapping of the UEFI System table
Date: Wed, 23 Mar 2016 23:11:53 +0100 [thread overview]
Message-ID: <CAKv+Gu_p=nWMbyciC9QXqnLEgqouxiERn6kcLv1V+2tDc74tbA@mail.gmail.com> (raw)
In-Reply-To: <20160323161624.GG11676@codeblueprint.co.uk>
On 23 March 2016 at 17:16, Matt Fleming <matt@codeblueprint.co.uk> wrote:
> On Tue, 22 Mar, at 04:08:24PM, Ard Biesheuvel wrote:
>>
>> This patch causes a warning I hadn't spotted before sending it out.
>> Could you fold this in please?
>>
>> diff --git a/drivers/firmware/efi/arm-runtime.c
>> b/drivers/firmware/efi/arm-runtime.c
>> index 6c97d4884fc7..fe749da9997e 100644
>> --- a/drivers/firmware/efi/arm-runtime.c
>> +++ b/drivers/firmware/efi/arm-runtime.c
>> @@ -72,8 +72,8 @@ static bool __init efi_virtmap_init(void)
>> */
>> if (efi_system_table >= phys &&
>> efi_system_table < phys + (md->num_pages * EFI_PAGE_SIZE)) {
>> - efi.systab = (void *)(efi_system_table - phys +
>> - md->virt_addr);
>> + efi.systab = (void *)(unsigned long)(efi_system_table -
>> + phys + md->virt_addr);
>> systab_found = true;
>> }
>> }
>
> Done, please check,
>
> https://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/commit/?h=next&id=4fd5c619dcf4f3d2c86d4a686ce66fc01e877a08
Looks good to me, thanks.
next prev parent reply other threads:[~2016-03-23 22:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 14:20 [PATCH 1/2] efi: get rid of EFI_SYSTEM_TABLES status bit Ard Biesheuvel
2016-02-26 14:20 ` Ard Biesheuvel
[not found] ` <1456496435-12679-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-02-26 14:20 ` [PATCH 2/2] arm*: efi: drop writable mapping of the UEFI System table Ard Biesheuvel
2016-02-26 14:20 ` Ard Biesheuvel
[not found] ` <1456496435-12679-2-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-02-26 15:01 ` Matt Fleming
2016-02-26 15:01 ` Matt Fleming
[not found] ` <20160226150156.GC7475-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-03-22 15:08 ` Ard Biesheuvel
2016-03-22 15:08 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8+pYR_jxjcVeXgekVqD_BugtRLgNNhOkvhuaEpddbHRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-23 16:16 ` Matt Fleming
2016-03-23 16:16 ` Matt Fleming
[not found] ` <20160323161624.GG11676-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-03-23 22:11 ` Ard Biesheuvel [this message]
2016-03-23 22:11 ` Ard Biesheuvel
2016-02-26 14:43 ` [PATCH 1/2] efi: get rid of EFI_SYSTEM_TABLES status bit Matt Fleming
2016-02-26 14:43 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu_p=nWMbyciC9QXqnLEgqouxiERn6kcLv1V+2tDc74tbA@mail.gmail.com' \
--to=ard.biesheuvel-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.