From: Nick Desaulniers <ndesaulniers@google.com> To: Nathan Chancellor <natechancellor@gmail.com> Cc: Kalle Valo <kvalo@codeaurora.org>, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Network Development <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, clang-built-linux <clang-built-linux@googlegroups.com>, CI Notify <ci_notify@linaro.org> Subject: Re: [PATCH] ath11k: Silence clang -Wsometimes-uninitialized in ath11k_update_per_peer_stats_from_txcompl Date: Mon, 3 Feb 2020 15:18:49 +0000 [thread overview] Message-ID: <CAKwvOd=kehh2A6O1my6FbYtSU7e=p0JVM0+RBSF=rpPU7QWbOw@mail.gmail.com> (raw) In-Reply-To: <20200130015905.18610-1-natechancellor@gmail.com> On Thu, Jan 30, 2020 at 1:59 AM Nathan Chancellor <natechancellor@gmail.com> wrote: > > Clang warns a few times (trimmed for brevity): > > ../drivers/net/wireless/ath/ath11k/debugfs_sta.c:185:7: warning: > variable 'rate_idx' is used uninitialized whenever 'if' condition is > false [-Wsometimes-uninitialized] > > It is not wrong, rate_idx is only initialized in the first if block. > However, this is not necessarily an issue in practice because rate_idx > will only be used when initialized because > ath11k_accumulate_per_peer_tx_stats only uses rate_idx when flags is not > set to RATE_INFO_FLAGS_HE_MCS, RATE_INFO_FLAGS_VHT_MCS, or > RATE_INFO_FLAGS_MCS. Still, it is not good to stick uninitialized values > into another function so initialize it to zero to prevent any issues > down the line. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Link: https://github.com/ClangBuiltLinux/linux/issues/832 > Reported-by: ci_notify@linaro.org > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Thanks for the patch. A bit tricky to follow that this (previously) is safe. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > drivers/net/wireless/ath/ath11k/debugfs_sta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath11k/debugfs_sta.c b/drivers/net/wireless/ath/ath11k/debugfs_sta.c > index 743760c9bcae..a5bdd16d6d46 100644 > --- a/drivers/net/wireless/ath/ath11k/debugfs_sta.c > +++ b/drivers/net/wireless/ath/ath11k/debugfs_sta.c > @@ -136,7 +136,7 @@ void ath11k_update_per_peer_stats_from_txcompl(struct ath11k *ar, > struct ath11k_sta *arsta; > struct ieee80211_sta *sta; > u16 rate; > - u8 rate_idx; > + u8 rate_idx = 0; > int ret; > u8 mcs; > > -- > 2.25.0 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200130015905.18610-1-natechancellor%40gmail.com. -- Thanks, ~Nick Desaulniers
WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com> To: Nathan Chancellor <natechancellor@gmail.com> Cc: Network Development <netdev@vger.kernel.org>, linux-wireless@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, clang-built-linux <clang-built-linux@googlegroups.com>, CI Notify <ci_notify@linaro.org>, ath11k@lists.infradead.org, Kalle Valo <kvalo@codeaurora.org> Subject: Re: [PATCH] ath11k: Silence clang -Wsometimes-uninitialized in ath11k_update_per_peer_stats_from_txcompl Date: Mon, 3 Feb 2020 15:18:49 +0000 [thread overview] Message-ID: <CAKwvOd=kehh2A6O1my6FbYtSU7e=p0JVM0+RBSF=rpPU7QWbOw@mail.gmail.com> (raw) In-Reply-To: <20200130015905.18610-1-natechancellor@gmail.com> On Thu, Jan 30, 2020 at 1:59 AM Nathan Chancellor <natechancellor@gmail.com> wrote: > > Clang warns a few times (trimmed for brevity): > > ../drivers/net/wireless/ath/ath11k/debugfs_sta.c:185:7: warning: > variable 'rate_idx' is used uninitialized whenever 'if' condition is > false [-Wsometimes-uninitialized] > > It is not wrong, rate_idx is only initialized in the first if block. > However, this is not necessarily an issue in practice because rate_idx > will only be used when initialized because > ath11k_accumulate_per_peer_tx_stats only uses rate_idx when flags is not > set to RATE_INFO_FLAGS_HE_MCS, RATE_INFO_FLAGS_VHT_MCS, or > RATE_INFO_FLAGS_MCS. Still, it is not good to stick uninitialized values > into another function so initialize it to zero to prevent any issues > down the line. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Link: https://github.com/ClangBuiltLinux/linux/issues/832 > Reported-by: ci_notify@linaro.org > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Thanks for the patch. A bit tricky to follow that this (previously) is safe. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > drivers/net/wireless/ath/ath11k/debugfs_sta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath11k/debugfs_sta.c b/drivers/net/wireless/ath/ath11k/debugfs_sta.c > index 743760c9bcae..a5bdd16d6d46 100644 > --- a/drivers/net/wireless/ath/ath11k/debugfs_sta.c > +++ b/drivers/net/wireless/ath/ath11k/debugfs_sta.c > @@ -136,7 +136,7 @@ void ath11k_update_per_peer_stats_from_txcompl(struct ath11k *ar, > struct ath11k_sta *arsta; > struct ieee80211_sta *sta; > u16 rate; > - u8 rate_idx; > + u8 rate_idx = 0; > int ret; > u8 mcs; > > -- > 2.25.0 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200130015905.18610-1-natechancellor%40gmail.com. -- Thanks, ~Nick Desaulniers _______________________________________________ ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2020-02-03 15:19 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-30 1:59 [PATCH] ath11k: Silence clang -Wsometimes-uninitialized in ath11k_update_per_peer_stats_from_txcompl Nathan Chancellor 2020-01-30 1:59 ` Nathan Chancellor 2020-02-03 15:18 ` Nick Desaulniers [this message] 2020-02-03 15:18 ` Nick Desaulniers 2020-02-11 14:24 ` Kalle Valo 2020-02-11 14:24 ` Kalle Valo [not found] ` <20200211142431.243E6C433A2@smtp.codeaurora.org> 2020-03-16 21:15 ` Nick Desaulniers 2020-03-16 21:15 ` Nick Desaulniers 2020-03-17 8:29 ` Kalle Valo 2020-03-17 8:29 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKwvOd=kehh2A6O1my6FbYtSU7e=p0JVM0+RBSF=rpPU7QWbOw@mail.gmail.com' \ --to=ndesaulniers@google.com \ --cc=ath11k@lists.infradead.org \ --cc=ci_notify@linaro.org \ --cc=clang-built-linux@googlegroups.com \ --cc=kvalo@codeaurora.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=natechancellor@gmail.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.