[PATCH] drm/nouveau/nvif: remove const attribute from nvif_mclass

[PATCH] drm/nouveau/nvif: remove const attribute from nvif_mclass

[Nick Desaulniers]

Similar to commit 0bf8bf50eddc ("module: Remove
const attribute from alias for MODULE_DEVICE_TABLE")

Fixes many -Wduplicate-decl-specifier warnings due to the combination of
const typeof() of already const variables.

Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
 drivers/gpu/drm/nouveau/include/nvif/object.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/include/nvif/object.h b/drivers/gpu/drm/nouveau/include/nvif/object.h
index a2d5244ff2b7..7f188f66931e 100644
--- a/drivers/gpu/drm/nouveau/include/nvif/object.h
+++ b/drivers/gpu/drm/nouveau/include/nvif/object.h
@@ -78,7 +78,7 @@ struct nvif_mclass {
 #define nvif_mclass(o,m) ({                                                    \
 	struct nvif_object *object = (o);                                      \
 	struct nvif_sclass *sclass;                                            \
-	const typeof(m[0]) *mclass = (m);                                      \
+	typeof(m[0]) *mclass = (m);                                      \
 	int ret = -ENODEV;                                                     \
 	int cnt, i, j;                                                         \
                                                                                \
-- 
2.18.0.rc1.244.gcf134e6275-goog

Re: [PATCH] drm/nouveau/nvif: remove const attribute from nvif_mclass

[Nick Desaulniers]

On Fri, Jun 15, 2018 at 3:56 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> Similar to commit 0bf8bf50eddc ("module: Remove
> const attribute from alias for MODULE_DEVICE_TABLE")
>
> Fixes many -Wduplicate-decl-specifier warnings due to the combination of
> const typeof() of already const variables.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
>  drivers/gpu/drm/nouveau/include/nvif/object.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/include/nvif/object.h b/drivers/gpu/drm/nouveau/include/nvif/object.h
> index a2d5244ff2b7..7f188f66931e 100644
> --- a/drivers/gpu/drm/nouveau/include/nvif/object.h
> +++ b/drivers/gpu/drm/nouveau/include/nvif/object.h
> @@ -78,7 +78,7 @@ struct nvif_mclass {
>  #define nvif_mclass(o,m) ({                                                    \
>         struct nvif_object *object = (o);                                      \
>         struct nvif_sclass *sclass;                                            \
> -       const typeof(m[0]) *mclass = (m);                                      \
> +       typeof(m[0]) *mclass = (m);                                      \

Sorry, this messes up the spaces at the end, will send a v2.

>         int ret = -ENODEV;                                                     \
>         int cnt, i, j;                                                         \
>                                                                                 \
> --
> 2.18.0.rc1.244.gcf134e6275-goog
>

-- 
Thanks,
~Nick Desaulniers

[PATCH v2] drm/nouveau/nvif: remove const attribute from nvif_mclass

[Nick Desaulniers]

Similar to commit 0bf8bf50eddc ("module: Remove
const attribute from alias for MODULE_DEVICE_TABLE")

Fixes many -Wduplicate-decl-specifier warnings due to the combination of
const typeof() of already const variables.

Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
Changes since v1: added additional space after statements.

 drivers/gpu/drm/nouveau/include/nvif/object.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/include/nvif/object.h b/drivers/gpu/drm/nouveau/include/nvif/object.h
index a2d5244ff2b7..3d7e485a9043 100644
--- a/drivers/gpu/drm/nouveau/include/nvif/object.h
+++ b/drivers/gpu/drm/nouveau/include/nvif/object.h
@@ -78,7 +78,7 @@ struct nvif_mclass {
 #define nvif_mclass(o,m) ({                                                    \
 	struct nvif_object *object = (o);                                      \
 	struct nvif_sclass *sclass;                                            \
-	const typeof(m[0]) *mclass = (m);                                      \
+	typeof(m[0]) *mclass = (m);                                            \
 	int ret = -ENODEV;                                                     \
 	int cnt, i, j;                                                         \
                                                                                \
-- 
2.18.0.rc1.244.gcf134e6275-goog

Re: [PATCH v2] drm/nouveau/nvif: remove const attribute from nvif_mclass

[Matthias Kaehlcke]

On Fri, Jun 15, 2018 at 04:00:42PM -0700, Nick Desaulniers wrote:
> Similar to commit 0bf8bf50eddc ("module: Remove
> const attribute from alias for MODULE_DEVICE_TABLE")
> 
> Fixes many -Wduplicate-decl-specifier warnings due to the combination of
> const typeof() of already const variables.
> 
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

Re: [PATCH v2] drm/nouveau/nvif: remove const attribute from nvif_mclass

[Matthias Kaehlcke]

On Fri, Jun 15, 2018 at 04:00:42PM -0700, Nick Desaulniers wrote:
> Similar to commit 0bf8bf50eddc ("module: Remove
> const attribute from alias for MODULE_DEVICE_TABLE")
> 
> Fixes many -Wduplicate-decl-specifier warnings due to the combination of
> const typeof() of already const variables.
> 
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel