* [PATCH v2] kbuild: add -Wno-unused-but-set-variable flag unconditionally
@ 2018-10-02 1:32 Masahiro Yamada
2018-10-02 21:10 ` Nick Desaulniers
2018-10-09 14:58 ` Masahiro Yamada
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2018-10-02 1:32 UTC (permalink / raw)
To: linux-kbuild
Cc: Arnd Bergmann, Kees Cook, Nick Desaulniers, Masahiro Yamada,
Michal Marek, linux-kernel
We have raised the compiler requirement from time to time.
With commit cafa0010cd51 ("Raise the minimum required gcc version
to 4.6"), the minimum for GCC is 4.6 now.
This flag was added by GCC 4.6, and it is recognized by ICC as well.
It is true that Clang does not support this flag but this commit is
just touching the else part of the "ifeq ($(cc-name),clang)" check.
Hence, Clang build is not affected.
Let's rip off the cc-disable-warning switch, and see if somebody
complains about it.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Changes in v2:
- Fix commit log
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 8a23fee..2627266 100644
--- a/Makefile
+++ b/Makefile
@@ -716,7 +716,7 @@ else
# These warnings generated too much noise in a regular build.
# Use make W=1 to enable them (see scripts/Makefile.extrawarn)
-KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
+KBUILD_CFLAGS += -Wno-unused-but-set-variable
endif
KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] kbuild: add -Wno-unused-but-set-variable flag unconditionally
2018-10-02 1:32 [PATCH v2] kbuild: add -Wno-unused-but-set-variable flag unconditionally Masahiro Yamada
@ 2018-10-02 21:10 ` Nick Desaulniers
2018-10-09 14:58 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Nick Desaulniers @ 2018-10-02 21:10 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Linux Kbuild mailing list, Arnd Bergmann, Kees Cook, Michal Marek, LKML
On Mon, Oct 1, 2018 at 6:33 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> We have raised the compiler requirement from time to time.
> With commit cafa0010cd51 ("Raise the minimum required gcc version
> to 4.6"), the minimum for GCC is 4.6 now.
>
> This flag was added by GCC 4.6, and it is recognized by ICC as well.
>
> It is true that Clang does not support this flag but this commit is
> just touching the else part of the "ifeq ($(cc-name),clang)" check.
> Hence, Clang build is not affected.
>
> Let's rip off the cc-disable-warning switch, and see if somebody
> complains about it.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
> - Fix commit log
Mashiro, thank you for this fix.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 8a23fee..2627266 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -716,7 +716,7 @@ else
>
> # These warnings generated too much noise in a regular build.
> # Use make W=1 to enable them (see scripts/Makefile.extrawarn)
> -KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
> +KBUILD_CFLAGS += -Wno-unused-but-set-variable
> endif
>
> KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
> --
> 2.7.4
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] kbuild: add -Wno-unused-but-set-variable flag unconditionally
2018-10-02 1:32 [PATCH v2] kbuild: add -Wno-unused-but-set-variable flag unconditionally Masahiro Yamada
2018-10-02 21:10 ` Nick Desaulniers
@ 2018-10-09 14:58 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2018-10-09 14:58 UTC (permalink / raw)
To: Linux Kbuild mailing list
Cc: Arnd Bergmann, Kees Cook, Nick Desaulniers, Michal Marek,
Linux Kernel Mailing List
On Tue, Oct 2, 2018 at 10:33 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> We have raised the compiler requirement from time to time.
> With commit cafa0010cd51 ("Raise the minimum required gcc version
> to 4.6"), the minimum for GCC is 4.6 now.
>
> This flag was added by GCC 4.6, and it is recognized by ICC as well.
>
> It is true that Clang does not support this flag but this commit is
> just touching the else part of the "ifeq ($(cc-name),clang)" check.
> Hence, Clang build is not affected.
>
> Let's rip off the cc-disable-warning switch, and see if somebody
> complains about it.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Applied to linux-kbuild.
>
> Changes in v2:
> - Fix commit log
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 8a23fee..2627266 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -716,7 +716,7 @@ else
>
> # These warnings generated too much noise in a regular build.
> # Use make W=1 to enable them (see scripts/Makefile.extrawarn)
> -KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
> +KBUILD_CFLAGS += -Wno-unused-but-set-variable
> endif
>
> KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-09 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-02 1:32 [PATCH v2] kbuild: add -Wno-unused-but-set-variable flag unconditionally Masahiro Yamada
2018-10-02 21:10 ` Nick Desaulniers
2018-10-09 14:58 ` Masahiro Yamada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.