From: Nick Desaulniers <ndesaulniers@google.com> To: Jakub Sitnicki <jakub@cloudflare.com> Cc: bpf <bpf@vger.kernel.org>, kbuild-all@lists.01.org, clang-built-linux <clang-built-linux@googlegroups.com>, Network Development <netdev@vger.kernel.org>, kernel-team@cloudflare.com, kbuild test robot <lkp@intel.com> Subject: Re: [PATCH bpf-next 5/8] bpf: Add link-based BPF program attachment to network namespace Date: Thu, 4 Jun 2020 16:38:44 -0700 [thread overview] Message-ID: <CAKwvOdmof_tGVAN+gkq8R3Hq_sRDHXE_cB+37Sd7gKvgzVzVHw@mail.gmail.com> (raw) In-Reply-To: <202005281031.S7IMfvFG%lkp@intel.com> On Wed, May 27, 2020 at 8:19 PM kbuild test robot <lkp@intel.com> wrote: > > Hi Jakub, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > [also build test WARNING on net-next/master next-20200526] > [cannot apply to bpf/master net/master linus/master v5.7-rc7] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Jakub-Sitnicki/Link-based-program-attachment-to-network-namespaces/20200528-011159 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > config: arm-randconfig-r035-20200527 (attached as .config) > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm cross compiling tool for clang build > # apt-get install binutils-arm-linux-gnueabi > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>, old ones prefixed by <<): > > >> kernel/bpf/net_namespace.c:130:6: warning: variable 'inum' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] This looks legit to me. Please fix. > if (net) > ^~~ > kernel/bpf/net_namespace.c:134:26: note: uninitialized use occurs here > info->netns.netns_ino = inum; > ^~~~ > kernel/bpf/net_namespace.c:130:2: note: remove the 'if' if its condition is always true > if (net) > ^~~~~~~~ > kernel/bpf/net_namespace.c:123:19: note: initialize the variable 'inum' to silence this warning > unsigned int inum; > ^ > = 0 > 1 warning generated. > > vim +130 kernel/bpf/net_namespace.c > > 118 > 119 static int bpf_netns_link_fill_info(const struct bpf_link *link, > 120 struct bpf_link_info *info) > 121 { > 122 const struct bpf_netns_link *net_link; > 123 unsigned int inum; > 124 struct net *net; > 125 > 126 net_link = container_of(link, struct bpf_netns_link, link); > 127 > 128 rcu_read_lock(); > 129 net = rcu_dereference(net_link->net); > > 130 if (net) > 131 inum = net->ns.inum; > 132 rcu_read_unlock(); > 133 > 134 info->netns.netns_ino = inum; > 135 info->netns.attach_type = net_link->type; > 136 return 0; > 137 } > 138 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/202005281031.S7IMfvFG%25lkp%40intel.com. -- Thanks, ~Nick Desaulniers
WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH bpf-next 5/8] bpf: Add link-based BPF program attachment to network namespace Date: Thu, 04 Jun 2020 16:38:44 -0700 [thread overview] Message-ID: <CAKwvOdmof_tGVAN+gkq8R3Hq_sRDHXE_cB+37Sd7gKvgzVzVHw@mail.gmail.com> (raw) In-Reply-To: <202005281031.S7IMfvFG%lkp@intel.com> [-- Attachment #1: Type: text/plain, Size: 3571 bytes --] On Wed, May 27, 2020 at 8:19 PM kbuild test robot <lkp@intel.com> wrote: > > Hi Jakub, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > [also build test WARNING on net-next/master next-20200526] > [cannot apply to bpf/master net/master linus/master v5.7-rc7] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Jakub-Sitnicki/Link-based-program-attachment-to-network-namespaces/20200528-011159 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > config: arm-randconfig-r035-20200527 (attached as .config) > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm cross compiling tool for clang build > # apt-get install binutils-arm-linux-gnueabi > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>, old ones prefixed by <<): > > >> kernel/bpf/net_namespace.c:130:6: warning: variable 'inum' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] This looks legit to me. Please fix. > if (net) > ^~~ > kernel/bpf/net_namespace.c:134:26: note: uninitialized use occurs here > info->netns.netns_ino = inum; > ^~~~ > kernel/bpf/net_namespace.c:130:2: note: remove the 'if' if its condition is always true > if (net) > ^~~~~~~~ > kernel/bpf/net_namespace.c:123:19: note: initialize the variable 'inum' to silence this warning > unsigned int inum; > ^ > = 0 > 1 warning generated. > > vim +130 kernel/bpf/net_namespace.c > > 118 > 119 static int bpf_netns_link_fill_info(const struct bpf_link *link, > 120 struct bpf_link_info *info) > 121 { > 122 const struct bpf_netns_link *net_link; > 123 unsigned int inum; > 124 struct net *net; > 125 > 126 net_link = container_of(link, struct bpf_netns_link, link); > 127 > 128 rcu_read_lock(); > 129 net = rcu_dereference(net_link->net); > > 130 if (net) > 131 inum = net->ns.inum; > 132 rcu_read_unlock(); > 133 > 134 info->netns.netns_ino = inum; > 135 info->netns.attach_type = net_link->type; > 136 return 0; > 137 } > 138 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe(a)googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/202005281031.S7IMfvFG%25lkp%40intel.com. -- Thanks, ~Nick Desaulniers
next prev parent reply other threads:[~2020-06-04 23:38 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-27 17:08 [PATCH bpf-next 0/8] Link-based program attachment to network namespaces Jakub Sitnicki 2020-05-27 17:08 ` [PATCH bpf-next 1/8] flow_dissector: Don't grab update-side lock on prog detach from pre_exit Jakub Sitnicki 2020-05-27 17:35 ` sdf 2020-05-27 17:08 ` [PATCH bpf-next 2/8] flow_dissector: Pull locking up from prog attach callback Jakub Sitnicki 2020-05-27 17:35 ` sdf 2020-05-27 17:08 ` [PATCH bpf-next 3/8] net: Introduce netns_bpf for BPF programs attached to netns Jakub Sitnicki 2020-05-27 17:40 ` sdf 2020-05-27 19:31 ` Jakub Sitnicki 2020-05-27 20:36 ` sdf 2020-05-27 17:08 ` [PATCH bpf-next 4/8] flow_dissector: Move out netns_bpf prog callbacks Jakub Sitnicki 2020-05-27 17:08 ` [PATCH bpf-next 5/8] bpf: Add link-based BPF program attachment to network namespace Jakub Sitnicki 2020-05-27 17:48 ` sdf 2020-05-27 19:54 ` Jakub Sitnicki 2020-05-27 20:38 ` sdf 2020-05-28 10:34 ` Jakub Sitnicki 2020-05-27 20:53 ` sdf 2020-05-28 11:03 ` Jakub Sitnicki 2020-05-28 16:09 ` sdf 2020-05-28 2:54 ` kbuild test robot 2020-05-28 2:54 ` kbuild test robot 2020-06-04 23:38 ` Nick Desaulniers [this message] 2020-06-04 23:38 ` Nick Desaulniers 2020-06-05 14:41 ` Jakub Sitnicki 2020-05-28 5:56 ` Andrii Nakryiko 2020-05-28 12:26 ` Jakub Sitnicki 2020-05-28 18:09 ` Andrii Nakryiko 2020-05-28 18:48 ` Alexei Starovoitov 2020-05-28 13:30 ` Jakub Sitnicki 2020-05-27 17:08 ` [PATCH bpf-next 6/8] libbpf: Add support for bpf_link-based netns attachment Jakub Sitnicki 2020-05-28 5:59 ` Andrii Nakryiko 2020-05-28 13:05 ` Jakub Sitnicki 2020-05-27 17:08 ` [PATCH bpf-next 7/8] bpftool: Support link show for netns-attached links Jakub Sitnicki 2020-05-28 6:02 ` Andrii Nakryiko 2020-05-28 13:10 ` Jakub Sitnicki 2020-05-27 17:08 ` [PATCH bpf-next 8/8] selftests/bpf: Add tests for attaching bpf_link to netns Jakub Sitnicki 2020-05-28 6:08 ` Andrii Nakryiko 2020-05-28 13:29 ` Jakub Sitnicki 2020-05-28 18:31 ` Andrii Nakryiko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKwvOdmof_tGVAN+gkq8R3Hq_sRDHXE_cB+37Sd7gKvgzVzVHw@mail.gmail.com \ --to=ndesaulniers@google.com \ --cc=bpf@vger.kernel.org \ --cc=clang-built-linux@googlegroups.com \ --cc=jakub@cloudflare.com \ --cc=kbuild-all@lists.01.org \ --cc=kernel-team@cloudflare.com \ --cc=lkp@intel.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.