Re: [PATCH v5 02/11] qla2xxx: Suppress two recently introduced compiler warnings

[Nick Desaulniers <ndesaulniers@google.com>]

On Thu, May 7, 2020 at 12:18 PM kbuild test robot <lkp@intel.com> wrote:
>
> Hi Bart,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on scsi/for-next]
> [also build test ERROR on mkp-scsi/for-next tip/perf/core v5.7-rc4 next-20200507]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url:    https://github.com/0day-ci/linux/commits/Bart-Van-Assche/Fix-qla2xxx-endianness-annotations/20200507-135245
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
> config: x86_64-allyesconfig (attached as .config)
> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 54b35c066417d4856e9d53313f7e98b354274584)
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install x86_64 cross compiling tool for clang build
>         # apt-get install binutils-x86-64-linux-gnu
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^

Hi Bart,
These compiler specific pragma's are not toolchain portable.  You'll
need to wrap them in:
#ifndef __clang__
preprocessor macros, or I think we have a pragma helper in tree that
helps with compiler specific pragmas.  IIRC it uses _Pragma to define
pragmas in macros.

>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
>    In file included from include/trace/events/qla.h:44:
>    In file included from include/trace/define_trace.h:95:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^
>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
>    In file included from include/trace/events/qla.h:44:
>    In file included from include/trace/define_trace.h:102:
>    In file included from include/trace/trace_events.h:155:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^
>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
>    In file included from include/trace/events/qla.h:44:
>    In file included from include/trace/define_trace.h:102:
>    In file included from include/trace/trace_events.h:222:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^
>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
>    In file included from include/trace/events/qla.h:44:
>    In file included from include/trace/define_trace.h:102:
>    In file included from include/trace/trace_events.h:402:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^
>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
>    In file included from include/trace/events/qla.h:44:
>    In file included from include/trace/define_trace.h:102:
>    In file included from include/trace/trace_events.h:453:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^
>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
>    In file included from include/trace/events/qla.h:44:
>    In file included from include/trace/define_trace.h:102:
>    In file included from include/trace/trace_events.h:533:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^
>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
>    In file included from include/trace/events/qla.h:44:
>    In file included from include/trace/define_trace.h:102:
>    In file included from include/trace/trace_events.h:727:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^
>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
>    In file included from include/trace/events/qla.h:44:
>    In file included from include/trace/define_trace.h:102:
>    In file included from include/trace/trace_events.h:792:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^
>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
>    In file included from include/trace/events/qla.h:44:
>    In file included from include/trace/define_trace.h:103:
>    In file included from include/trace/perf.h:90:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^
>    In file included from drivers/scsi/qla2xxx/qla_dbg.c:77:
>    In file included from include/trace/events/qla.h:44:
>    In file included from include/trace/define_trace.h:104:
>    In file included from include/trace/bpf_probe.h:114:
> >> include/trace/events/qla.h:13:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>    #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                   ^
>    11 errors generated.
>
> vim +13 include/trace/events/qla.h
>
>     11
>     12  #pragma GCC diagnostic push
>   > 13  #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>     14
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/202005080353.y49Uwj18%25lkp%40intel.com.



-- 
Thanks,
~Nick Desaulniers