All of lore.kernel.org
 help / color / mirror / Atom feed
* Remove noisy log message in smb2 readdir
@ 2011-10-28 15:31 Steve French
       [not found] ` <CAH2r5mtoLp0D2Cgxffpt4=D1VE2y_6ga0P6nWpyQmMbBtgotWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Steve French @ 2011-10-28 15:31 UTC (permalink / raw)
  To: Pavel Shilovsky; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA

Pavel,
smb2 readdir is noisy (logging every time).  Do you want to merge
this in to an existing patch, or add it as distinct patch.

Also readdir logs the "expected" return codes (status code) on
medium to large directories since smb2_sendrcv2 is being called for
smb2 search with the "LOG_ERROR" flag.

diff --git a/fs/cifs/smb2readdir.c b/fs/cifs/smb2readdir.c
index 7d80e8b..b4c32d5 100644
--- a/fs/cifs/smb2readdir.c
+++ b/fs/cifs/smb2readdir.c
@@ -412,7 +412,6 @@ static int initiate_smb2_search(const int xid,
struct file *file)
 	if (full_path == NULL)
 		return -ENOMEM;

-	cifs_dump_mem("about to search on name: ", full_path, 4);
 	rc = SMB2_open(xid, tcon, full_path, &persistent_fid, &volatile_fid,
 			FILE_READ_ATTRIBUTES | FILE_READ_DATA, FILE_OPEN, 0, 0,
 			&oplock);

-- 
Thanks,

Steve

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Remove noisy log message in smb2 readdir
       [not found] ` <CAH2r5mtoLp0D2Cgxffpt4=D1VE2y_6ga0P6nWpyQmMbBtgotWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2011-10-28 16:12   ` Pavel Shilovsky
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Shilovsky @ 2011-10-28 16:12 UTC (permalink / raw)
  To: Steve French; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA

2011/10/28 Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> Pavel,
> smb2 readdir is noisy (logging every time).  Do you want to merge
> this in to an existing patch, or add it as distinct patch.
>
> Also readdir logs the "expected" return codes (status code) on
> medium to large directories since smb2_sendrcv2 is being called for
> smb2 search with the "LOG_ERROR" flag.
>
> diff --git a/fs/cifs/smb2readdir.c b/fs/cifs/smb2readdir.c
> index 7d80e8b..b4c32d5 100644
> --- a/fs/cifs/smb2readdir.c
> +++ b/fs/cifs/smb2readdir.c
> @@ -412,7 +412,6 @@ static int initiate_smb2_search(const int xid,
> struct file *file)
>        if (full_path == NULL)
>                return -ENOMEM;
>
> -       cifs_dump_mem("about to search on name: ", full_path, 4);
>        rc = SMB2_open(xid, tcon, full_path, &persistent_fid, &volatile_fid,
>                        FILE_READ_ATTRIBUTES | FILE_READ_DATA, FILE_OPEN, 0, 0,
>                        &oplock);
>
> --
> Thanks,
>
> Steve
>

Thanks! I prefer it to be included in my readdir patch - will do it
soon and reposted.

-- 
Best regards,
Pavel Shilovsky.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-10-28 16:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-28 15:31 Remove noisy log message in smb2 readdir Steve French
     [not found] ` <CAH2r5mtoLp0D2Cgxffpt4=D1VE2y_6ga0P6nWpyQmMbBtgotWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-10-28 16:12   ` Pavel Shilovsky

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.