All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manikishan Ghantasala <manikishanghantasala@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michael Straube <straube.linux@gmail.com>,
	linux-staging@lists.linux.dev,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h
Date: Wed, 2 Jun 2021 23:04:53 +0530	[thread overview]
Message-ID: <CAKzJ-FNm-uYoSFvMmNjAtsXmOQ-_P=o3JhpZhzk0tuuNRDTB9Q@mail.gmail.com> (raw)
In-Reply-To: <YLe8psfQLCb5bn2W@kroah.com>

On Wed, 2 Jun 2021 at 22:45, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Jun 02, 2021 at 09:33:31PM +0530, Manikishan Ghantasala wrote:
> > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
>
> Why is this line here?
>
Added it as description and I put a break due to char limit.
> >
> > "Macros with complex values should be enclosed in parentheses"
> > by enclosing values in parantheses.
>
> I can not understand this sentence, can you please reword it?
>
I meant, I cleared(fixed) the error in quotes by enclosing them in parentheses.

> > Modified spacing around "|" and removed a space before tab.
>
> This is not related to the first thing, please break this up into
> multiple patches like the bot asked...
>
Okay, will do. Do I have to make one for the 'space before tab' too?
or can I ignore it?
> thanks,
>
> greg k-h


Thanks,
Manikishan Ghantasala

  reply	other threads:[~2021-06-02 17:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 16:03 [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h Manikishan Ghantasala
2021-06-02 16:03 ` Manikishan Ghantasala
2021-06-02 17:15 ` Greg Kroah-Hartman
2021-06-02 17:34   ` Manikishan Ghantasala [this message]
2021-06-02 17:34     ` Manikishan Ghantasala
2021-06-02 18:01     ` Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2021-06-02 15:10 sh4nnu
2021-06-02 15:10 ` sh4nnu
2021-06-02 15:18 ` Greg Kroah-Hartman
2021-06-02 15:36   ` Joe Perches
2021-06-02 15:36     ` Joe Perches
2021-06-02 15:42     ` Manikishan Ghantasala
2021-06-02 15:42       ` Manikishan Ghantasala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKzJ-FNm-uYoSFvMmNjAtsXmOQ-_P=o3JhpZhzk0tuuNRDTB9Q@mail.gmail.com' \
    --to=manikishanghantasala@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.