All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manikishan Ghantasala <manikishanghantasala@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alex Elder <elder@ieee.org>, Rui Miguel Silva <rmfrfs@gmail.com>,
	Johan Hovold <johan@kernel.org>,  Alex Elder <elder@kernel.org>,
	greybus-dev@lists.linaro.org,  linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: fixed the coding style, labels should not be indented.
Date: Wed, 2 Jun 2021 20:09:27 +0530	[thread overview]
Message-ID: <CAKzJ-FPZeM1QettgDyNaXy4xXpXX0YVm1TNVaKHOopiYevALjA@mail.gmail.com> (raw)
In-Reply-To: <YLeXoQH2/iJjxkc+@kroah.com>

Hi Greg,
Thanks for the clarification.
Regards,
Manikishan Ghantasala

On Wed, 2 Jun 2021 at 20:07, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Jun 02, 2021 at 07:57:35PM +0530, Manikishan Ghantasala wrote:
> > Sending this mail again as I missed to reply to all.
> >  Hi Alex,
> >
> > I agree those are called bit-field member names rather than labels.
> > But the reason I mentioned is because the ./scripts/checkpatch.pl
> > gave out a warning saying "labels should not be indented".
>
> checkpatch is a perl script that does it's best, but does not always get
> it right.  In this case, it is incorrect, the existing code is just
> fine.
>
> thanks,
>
> greg k-h

  reply	other threads:[~2021-06-02 14:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 13:36 [PATCH] staging: greybus: fixed the coding style, labels should not be indented sh4nnu
2021-06-02 13:36 ` sh4nnu
2021-06-02 13:43 ` Alex Elder
2021-06-02 14:27   ` Manikishan Ghantasala
2021-06-02 14:27     ` Manikishan Ghantasala
2021-06-02 14:37     ` Greg Kroah-Hartman
2021-06-02 14:39       ` Manikishan Ghantasala [this message]
2021-06-02 14:39         ` Manikishan Ghantasala
2021-06-02 17:26       ` [PATCH] checkpatch: Improve the indented label test Joe Perches
2021-06-02 17:26         ` Joe Perches
2021-06-02 14:38     ` [PATCH] staging: greybus: fixed the coding style, labels should not be indented Alex Elder
2021-06-03 21:22     ` David Laight
2021-06-03 21:45       ` [greybus-dev] " Alex Elder
2021-06-03 21:48         ` David Laight
2021-06-03 21:55           ` Alex Elder
2021-06-04  8:13             ` David Laight
2021-06-04  8:26               ` Joe Perches
2021-06-04  8:26                 ` Joe Perches
2021-06-04  8:33                 ` David Laight
2021-06-04 12:34               ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKzJ-FPZeM1QettgDyNaXy4xXpXX0YVm1TNVaKHOopiYevALjA@mail.gmail.com \
    --to=manikishanghantasala@gmail.com \
    --cc=elder@ieee.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=rmfrfs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.