* [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias
@ 2015-01-31 4:38 Axel Lin
2015-01-31 9:04 ` Daniel Mack
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Axel Lin @ 2015-01-31 4:38 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Matt Ranostay, Daniel Mack, linux-input
This is a I2C driver, so it's wrong to use platform prefix for the modalias.
We have all needed i2c aliases coming form MODULE_DEVICE_TABLE,
so remove the wrong and unneeded cap11xx modalias.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/input/keyboard/cap11xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
index 4f59f0b..f07461a 100644
--- a/drivers/input/keyboard/cap11xx.c
+++ b/drivers/input/keyboard/cap11xx.c
@@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = {
module_i2c_driver(cap11xx_i2c_driver);
-MODULE_ALIAS("platform:cap11xx");
MODULE_DESCRIPTION("Microchip CAP11XX driver");
MODULE_AUTHOR("Daniel Mack <linux@zonque.org>");
MODULE_LICENSE("GPL v2");
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias
2015-01-31 4:38 [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias Axel Lin
@ 2015-01-31 9:04 ` Daniel Mack
2015-01-31 10:17 ` Matt Ranostay
2015-02-01 4:21 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Mack @ 2015-01-31 9:04 UTC (permalink / raw)
To: Axel Lin, Dmitry Torokhov; +Cc: Matt Ranostay, linux-input
On 01/31/2015 05:38 AM, Axel Lin wrote:
> This is a I2C driver, so it's wrong to use platform prefix for the modalias.
> We have all needed i2c aliases coming form MODULE_DEVICE_TABLE,
> so remove the wrong and unneeded cap11xx modalias.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Daniel Mack <linux@zonque.org>
Thanks!
Daniel
> ---
> drivers/input/keyboard/cap11xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
> index 4f59f0b..f07461a 100644
> --- a/drivers/input/keyboard/cap11xx.c
> +++ b/drivers/input/keyboard/cap11xx.c
> @@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = {
>
> module_i2c_driver(cap11xx_i2c_driver);
>
> -MODULE_ALIAS("platform:cap11xx");
> MODULE_DESCRIPTION("Microchip CAP11XX driver");
> MODULE_AUTHOR("Daniel Mack <linux@zonque.org>");
> MODULE_LICENSE("GPL v2");
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias
2015-01-31 4:38 [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias Axel Lin
2015-01-31 9:04 ` Daniel Mack
@ 2015-01-31 10:17 ` Matt Ranostay
2015-02-01 4:21 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Matt Ranostay @ 2015-01-31 10:17 UTC (permalink / raw)
To: Axel Lin; +Cc: Dmitry Torokhov, Daniel Mack, linux-input
Reviewed-by: Matt Ranostay <mranostay@gmail.com>
Thanks,
Matt Ranostay
On Fri, Jan 30, 2015 at 8:38 PM, Axel Lin <axel.lin@ingics.com> wrote:
> This is a I2C driver, so it's wrong to use platform prefix for the modalias.
> We have all needed i2c aliases coming form MODULE_DEVICE_TABLE,
> so remove the wrong and unneeded cap11xx modalias.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/input/keyboard/cap11xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
> index 4f59f0b..f07461a 100644
> --- a/drivers/input/keyboard/cap11xx.c
> +++ b/drivers/input/keyboard/cap11xx.c
> @@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = {
>
> module_i2c_driver(cap11xx_i2c_driver);
>
> -MODULE_ALIAS("platform:cap11xx");
> MODULE_DESCRIPTION("Microchip CAP11XX driver");
> MODULE_AUTHOR("Daniel Mack <linux@zonque.org>");
> MODULE_LICENSE("GPL v2");
> --
> 1.9.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias
2015-01-31 4:38 [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias Axel Lin
2015-01-31 9:04 ` Daniel Mack
2015-01-31 10:17 ` Matt Ranostay
@ 2015-02-01 4:21 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2015-02-01 4:21 UTC (permalink / raw)
To: Axel Lin; +Cc: Matt Ranostay, Daniel Mack, linux-input
On Sat, Jan 31, 2015 at 12:38:02PM +0800, Axel Lin wrote:
> This is a I2C driver, so it's wrong to use platform prefix for the modalias.
> We have all needed i2c aliases coming form MODULE_DEVICE_TABLE,
> so remove the wrong and unneeded cap11xx modalias.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied, thank you.
> ---
> drivers/input/keyboard/cap11xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
> index 4f59f0b..f07461a 100644
> --- a/drivers/input/keyboard/cap11xx.c
> +++ b/drivers/input/keyboard/cap11xx.c
> @@ -370,7 +370,6 @@ static struct i2c_driver cap11xx_i2c_driver = {
>
> module_i2c_driver(cap11xx_i2c_driver);
>
> -MODULE_ALIAS("platform:cap11xx");
> MODULE_DESCRIPTION("Microchip CAP11XX driver");
> MODULE_AUTHOR("Daniel Mack <linux@zonque.org>");
> MODULE_LICENSE("GPL v2");
> --
> 1.9.1
>
>
>
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-01 4:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-31 4:38 [PATCH] Input: cap11xx - Remove wrong and unneeded cap11xx modalias Axel Lin
2015-01-31 9:04 ` Daniel Mack
2015-01-31 10:17 ` Matt Ranostay
2015-02-01 4:21 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.