* Apple Thunderbolt Ethernet device support
@ 2012-07-12 20:21 Greg KH
2012-07-12 20:56 ` [PATCH] tg3: add device id of Apple Thunderbolt Ethernet device Greg KH
2012-07-12 20:57 ` Apple Thunderbolt Ethernet device support Greg KH
0 siblings, 2 replies; 13+ messages in thread
From: Greg KH @ 2012-07-12 20:21 UTC (permalink / raw)
To: netdev
I have an Apple Thunderbolt Ethernet device here, and running 3.5-rc6 it
isn't detected. It has PCI id 14e4:1682, which seems like it should be
supported by the tg3 driver. Any hints?
I guess I could just go and add the device id to the driver and see what
happens...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] tg3: add device id of Apple Thunderbolt Ethernet device
2012-07-12 20:21 Apple Thunderbolt Ethernet device support Greg KH
@ 2012-07-12 20:56 ` Greg KH
2012-07-12 23:26 ` [PATCH v2] " Greg KH
2012-07-13 1:39 ` [PATCH v3] " Greg KH
2012-07-12 20:57 ` Apple Thunderbolt Ethernet device support Greg KH
1 sibling, 2 replies; 13+ messages in thread
From: Greg KH @ 2012-07-12 20:56 UTC (permalink / raw)
To: netdev
Add a PCI device id for the Apple Thunderbolt Ethernet device
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Note, I'm sure there's a better #define for this device, any way I can
determine what it should really be?
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index e47ff8b..46576f9 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -298,6 +298,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
+ {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_APPLE)},
{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h
index 93865f8..0a2ddff 100644
--- a/drivers/net/ethernet/broadcom/tg3.h
+++ b/drivers/net/ethernet/broadcom/tg3.h
@@ -63,6 +63,7 @@
#define TG3PCI_DEVICE_TIGON3_57766 0x1686
#define TG3PCI_DEVICE_TIGON3_57786 0x16b3
#define TG3PCI_DEVICE_TIGON3_57782 0x16b7
+#define TG3PCI_DEVICE_TIGON3_APPLE 0x1682
/* 0x04 --> 0x2c unused */
#define TG3PCI_SUBVENDOR_ID_BROADCOM PCI_VENDOR_ID_BROADCOM
#define TG3PCI_SUBDEVICE_ID_BROADCOM_95700A6 0x1644
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: Apple Thunderbolt Ethernet device support
2012-07-12 20:21 Apple Thunderbolt Ethernet device support Greg KH
2012-07-12 20:56 ` [PATCH] tg3: add device id of Apple Thunderbolt Ethernet device Greg KH
@ 2012-07-12 20:57 ` Greg KH
[not found] ` <4FFF59A9.4010009@hp.com>
1 sibling, 1 reply; 13+ messages in thread
From: Greg KH @ 2012-07-12 20:57 UTC (permalink / raw)
To: netdev
On Thu, Jul 12, 2012 at 01:21:31PM -0700, Greg KH wrote:
> I have an Apple Thunderbolt Ethernet device here, and running 3.5-rc6 it
> isn't detected. It has PCI id 14e4:1682, which seems like it should be
> supported by the tg3 driver. Any hints?
>
> I guess I could just go and add the device id to the driver and see what
> happens...
And that worked, patch sent.
But, as the patch shows, odds are it has a "real" device type in it,
so the #define I used isn't as descriptive as it should be. Any hints
on how I can figure out what to look at to make it more "correct"?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Apple Thunderbolt Ethernet device support
[not found] ` <4FFF59A9.4010009@hp.com>
@ 2012-07-12 23:18 ` Greg KH
2012-07-12 23:23 ` Greg KH
0 siblings, 1 reply; 13+ messages in thread
From: Greg KH @ 2012-07-12 23:18 UTC (permalink / raw)
To: Rick Jones; +Cc: netdev
On Thu, Jul 12, 2012 at 04:11:37PM -0700, Rick Jones wrote:
> On 07/12/2012 01:57 PM, Greg KH wrote:
> >On Thu, Jul 12, 2012 at 01:21:31PM -0700, Greg KH wrote:
> >>I have an Apple Thunderbolt Ethernet device here, and running 3.5-rc6 it
> >>isn't detected. It has PCI id 14e4:1682, which seems like it should be
> >>supported by the tg3 driver. Any hints?
> >>
> >>I guess I could just go and add the device id to the driver and see what
> >>happens...
> >And that worked, patch sent.
> >
> >But, as the patch shows, odds are it has a "real" device type in it,
> >so the #define I used isn't as descriptive as it should be. Any hints
> >on how I can figure out what to look at to make it more "correct"?
>
> a long-shot, but maybe there is something in the pci.ids database?
Ah, nice, there is something there:
1682 NetXtreme BCM57762 Gigabit Ethernet PCIe
I'll redo the patch with that information, thanks.
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Apple Thunderbolt Ethernet device support
2012-07-12 23:18 ` Greg KH
@ 2012-07-12 23:23 ` Greg KH
0 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2012-07-12 23:23 UTC (permalink / raw)
To: Rick Jones; +Cc: netdev
On Thu, Jul 12, 2012 at 04:18:34PM -0700, Greg KH wrote:
> On Thu, Jul 12, 2012 at 04:11:37PM -0700, Rick Jones wrote:
> > On 07/12/2012 01:57 PM, Greg KH wrote:
> > >On Thu, Jul 12, 2012 at 01:21:31PM -0700, Greg KH wrote:
> > >>I have an Apple Thunderbolt Ethernet device here, and running 3.5-rc6 it
> > >>isn't detected. It has PCI id 14e4:1682, which seems like it should be
> > >>supported by the tg3 driver. Any hints?
> > >>
> > >>I guess I could just go and add the device id to the driver and see what
> > >>happens...
> > >And that worked, patch sent.
> > >
> > >But, as the patch shows, odds are it has a "real" device type in it,
> > >so the #define I used isn't as descriptive as it should be. Any hints
> > >on how I can figure out what to look at to make it more "correct"?
> >
> > a long-shot, but maybe there is something in the pci.ids database?
>
> Ah, nice, there is something there:
> 1682 NetXtreme BCM57762 Gigabit Ethernet PCIe
>
> I'll redo the patch with that information, thanks.
Wait, something's a bit "odd" here. We already have:
#define TG3PCI_DEVICE_TIGON3_57762 0x1682
in drivers/net/ethernet/broadcom/tg3.h
But it's only used in the function where we can't figure out what type
of vpd we have in tg3_read_vpd(). One could ask how that codepath
was ever tested, as that device id was not in the MODULE_DEVICE_TABLE();
I wonder if someone reused the device id?
Anyway, I'll respin the patch...
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] tg3: add device id of Apple Thunderbolt Ethernet device
2012-07-12 20:56 ` [PATCH] tg3: add device id of Apple Thunderbolt Ethernet device Greg KH
@ 2012-07-12 23:26 ` Greg KH
2012-07-13 1:03 ` David Miller
2012-07-13 1:39 ` [PATCH v3] " Greg KH
1 sibling, 1 reply; 13+ messages in thread
From: Greg KH @ 2012-07-12 23:26 UTC (permalink / raw)
To: netdev
The Apple Thunderbolt ethernet device is already listed in the driver,
but not hooked up in the MODULE_DEVICE_TABLE(). This fixes that and
allows it to work properly.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index e47ff8b..3721833 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -298,6 +298,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
+ {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2] tg3: add device id of Apple Thunderbolt Ethernet device
2012-07-12 23:26 ` [PATCH v2] " Greg KH
@ 2012-07-13 1:03 ` David Miller
2012-07-13 1:37 ` Greg KH
0 siblings, 1 reply; 13+ messages in thread
From: David Miller @ 2012-07-13 1:03 UTC (permalink / raw)
To: gregkh; +Cc: netdev
Please stop ignoring the MAINTAINERS entry for this driver
and CC: the appropriate developers.
Thanks.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] tg3: add device id of Apple Thunderbolt Ethernet device
2012-07-13 1:03 ` David Miller
@ 2012-07-13 1:37 ` Greg KH
0 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2012-07-13 1:37 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Thu, Jul 12, 2012 at 06:03:10PM -0700, David Miller wrote:
>
> Please stop ignoring the MAINTAINERS entry for this driver
> and CC: the appropriate developers.
Sorry about that, will resend.
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device
2012-07-12 20:56 ` [PATCH] tg3: add device id of Apple Thunderbolt Ethernet device Greg KH
2012-07-12 23:26 ` [PATCH v2] " Greg KH
@ 2012-07-13 1:39 ` Greg KH
2012-07-13 5:33 ` Roland Dreier
2012-07-13 7:06 ` Michael Chan
1 sibling, 2 replies; 13+ messages in thread
From: Greg KH @ 2012-07-13 1:39 UTC (permalink / raw)
To: Matt Carlson, Michael Chan; +Cc: netdev
The Apple Thunderbolt ethernet device is already listed in the driver,
but not hooked up in the MODULE_DEVICE_TABLE(). This fixes that and
allows it to work properly.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Resent to Cc: the proper developers this time.
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index e47ff8b..3721833 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -298,6 +298,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
+ {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device
2012-07-13 1:39 ` [PATCH v3] " Greg KH
@ 2012-07-13 5:33 ` Roland Dreier
2012-07-13 7:19 ` Michael Chan
2012-07-13 7:06 ` Michael Chan
1 sibling, 1 reply; 13+ messages in thread
From: Roland Dreier @ 2012-07-13 5:33 UTC (permalink / raw)
To: Greg KH; +Cc: Matt Carlson, Michael Chan, netdev
On Thu, Jul 12, 2012 at 6:39 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> The Apple Thunderbolt ethernet device is already listed in the driver,
> but not hooked up in the MODULE_DEVICE_TABLE(). This fixes that and
> allows it to work properly.
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> Resent to Cc: the proper developers this time.
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index e47ff8b..3721833 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -298,6 +298,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
> {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
> {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
> {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
> + {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
> {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
> {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
> {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
I realize there's no way Greg can know the answer to this or test the
corresponding change...
But for the Broadcom guys:
it looks like there simiarly is code in the driver for at least
TG3PCI_DEVICE_TIGON3_57766
TG3PCI_DEVICE_TIGON3_57782
TG3PCI_DEVICE_TIGON3_57786
without entries in the PCI device table. Should those similarly be added?
- R.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device
2012-07-13 1:39 ` [PATCH v3] " Greg KH
2012-07-13 5:33 ` Roland Dreier
@ 2012-07-13 7:06 ` Michael Chan
2012-07-13 10:00 ` David Miller
1 sibling, 1 reply; 13+ messages in thread
From: Michael Chan @ 2012-07-13 7:06 UTC (permalink / raw)
To: Greg KH; +Cc: Matt Carlson, netdev
On Thu, 2012-07-12 at 18:39 -0700, Greg KH wrote:
> The Apple Thunderbolt ethernet device is already listed in the driver,
> but not hooked up in the MODULE_DEVICE_TABLE(). This fixes that and
> allows it to work properly.
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> Resent to Cc: the proper developers this time.
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index e47ff8b..3721833 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -298,6 +298,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
> {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
> {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
> {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
> + {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
> {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
> {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
> {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
>
ACK for net-next. I don't know why Matt added everything to support
this chip except the entry in the PCI ID table.
Acked-by: Michael Chan <mchan@broadcom.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device
2012-07-13 5:33 ` Roland Dreier
@ 2012-07-13 7:19 ` Michael Chan
0 siblings, 0 replies; 13+ messages in thread
From: Michael Chan @ 2012-07-13 7:19 UTC (permalink / raw)
To: Roland Dreier; +Cc: Greg KH, Matt Carlson, netdev
On Thu, 2012-07-12 at 22:33 -0700, Roland Dreier wrote:
> On Thu, Jul 12, 2012 at 6:39 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > The Apple Thunderbolt ethernet device is already listed in the driver,
> > but not hooked up in the MODULE_DEVICE_TABLE(). This fixes that and
> > allows it to work properly.
> >
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > ---
> > Resent to Cc: the proper developers this time.
> >
> > diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> > index e47ff8b..3721833 100644
> > --- a/drivers/net/ethernet/broadcom/tg3.c
> > +++ b/drivers/net/ethernet/broadcom/tg3.c
> > @@ -298,6 +298,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
> > {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
> > {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
> > {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
> > + {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
> > {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
> > {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
> > {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
>
> I realize there's no way Greg can know the answer to this or test the
> corresponding change...
>
> But for the Broadcom guys:
> it looks like there simiarly is code in the driver for at least
>
> TG3PCI_DEVICE_TIGON3_57766
> TG3PCI_DEVICE_TIGON3_57782
> TG3PCI_DEVICE_TIGON3_57786
>
> without entries in the PCI device table. Should those similarly be added?
>
Yeah we need to add these as well, but there may be missing code to
support these chips besides the PCI ID table entries. We will get these
chips tested and send the complete patches to support these chips.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device
2012-07-13 7:06 ` Michael Chan
@ 2012-07-13 10:00 ` David Miller
0 siblings, 0 replies; 13+ messages in thread
From: David Miller @ 2012-07-13 10:00 UTC (permalink / raw)
To: mchan; +Cc: gregkh, mcarlson, netdev
From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 13 Jul 2012 00:06:38 -0700
> On Thu, 2012-07-12 at 18:39 -0700, Greg KH wrote:
>> The Apple Thunderbolt ethernet device is already listed in the driver,
>> but not hooked up in the MODULE_DEVICE_TABLE(). This fixes that and
>> allows it to work properly.
>>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>
>> ---
>> Resent to Cc: the proper developers this time.
>>
>> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
>> index e47ff8b..3721833 100644
>> --- a/drivers/net/ethernet/broadcom/tg3.c
>> +++ b/drivers/net/ethernet/broadcom/tg3.c
>> @@ -298,6 +298,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
>> {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
>> {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
>> {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
>> + {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
>> {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
>> {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
>> {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
>>
>
> ACK for net-next. I don't know why Matt added everything to support
> this chip except the entry in the PCI ID table.
>
> Acked-by: Michael Chan <mchan@broadcom.com>
Applied.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2012-07-13 10:00 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-12 20:21 Apple Thunderbolt Ethernet device support Greg KH
2012-07-12 20:56 ` [PATCH] tg3: add device id of Apple Thunderbolt Ethernet device Greg KH
2012-07-12 23:26 ` [PATCH v2] " Greg KH
2012-07-13 1:03 ` David Miller
2012-07-13 1:37 ` Greg KH
2012-07-13 1:39 ` [PATCH v3] " Greg KH
2012-07-13 5:33 ` Roland Dreier
2012-07-13 7:19 ` Michael Chan
2012-07-13 7:06 ` Michael Chan
2012-07-13 10:00 ` David Miller
2012-07-12 20:57 ` Apple Thunderbolt Ethernet device support Greg KH
[not found] ` <4FFF59A9.4010009@hp.com>
2012-07-12 23:18 ` Greg KH
2012-07-12 23:23 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.