[PATCH 1/3] target/mips: Support variable page size

[PATCH 1/3] target/mips: Support variable page size

[Huacai Chen]

Traditionally, MIPS use 4KB page size, but Loongson prefer 16KB page
size in system emulator. So, let's define TARGET_PAGE_BITS_VARY and
TARGET_PAGE_BITS_MIN to support variable page size.

Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
 target/mips/cpu-param.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/target/mips/cpu-param.h b/target/mips/cpu-param.h
index 308660d..9c4a6ea 100644
--- a/target/mips/cpu-param.h
+++ b/target/mips/cpu-param.h
@@ -23,7 +23,12 @@
 #  define TARGET_VIRT_ADDR_SPACE_BITS 32
 #endif
 #endif
+#ifdef CONFIG_USER_ONLY
 #define TARGET_PAGE_BITS 12
+#else
+#define TARGET_PAGE_BITS_VARY
+#define TARGET_PAGE_BITS_MIN 12
+#endif
 #define NB_MMU_MODES 4
 
 #endif
-- 
2.7.0

[PATCH 2/3] mips/mips_fulong2e: Set preferred page size to 16KB

[Huacai Chen]

Loongson processor prefers 16KB page size in system emulator, so let's
define mc->minimum_page_bits to 14.

Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
 hw/mips/mips_fulong2e.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
index 5040afd..23897d7 100644
--- a/hw/mips/mips_fulong2e.c
+++ b/hw/mips/mips_fulong2e.c
@@ -399,6 +399,7 @@ static void mips_fulong2e_machine_init(MachineClass *mc)
     mc->default_cpu_type = MIPS_CPU_TYPE_NAME("Loongson-2E");
     mc->default_ram_size = 256 * MiB;
     mc->default_ram_id = "fulong2e.ram";
+    mc->minimum_page_bits = 14;
 }
 
 DEFINE_MACHINE("fulong2e", mips_fulong2e_machine_init)
-- 
2.7.0

[PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

[Huacai Chen]

I submitted the MIPS/fulong2e support about ten years ago, and after
that I became a MIPS kernel developer. Last year, Philippe Mathieu-
Daudé asked me that whether I can be a reviewer of MIPS/fulong2e, and I
promised that I will do some QEMU work in the next year (i.e., 2020 and
later). I think now (and also in future) I can have some spare time, so
I can finally do some real work on QEMU/MIPS. And if possible, I hope I
can be a co-maintainer of MIPS/fulong2e.

Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 642c8e0..3281ff2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1073,6 +1073,7 @@ F: hw/mips/mips_r4k.c
 Fulong 2E
 M: Philippe Mathieu-Daudé <f4bug@amsat.org>
 M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
+M: Huacai Chen <chenhc@lemote.com>
 S: Odd Fixes
 F: hw/mips/mips_fulong2e.c
 F: hw/isa/vt82c686.c
-- 
2.7.0

Re: [PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

[Aleksandar Markovic]

[-- Attachment #1: Type: text/plain, Size: 1770 bytes --]

11:08 Sre, 08.04.2020. Huacai Chen <chenhc@lemote.com> је написао/ла:
>
> I submitted the MIPS/fulong2e support about ten years ago, and after
> that I became a MIPS kernel developer. Last year, Philippe Mathieu-
> Daudé asked me that whether I can be a reviewer of MIPS/fulong2e, and I
> promised that I will do some QEMU work in the next year (i.e., 2020 and
> later). I think now (and also in future) I can have some spare time, so
> I can finally do some real work on QEMU/MIPS. And if possible, I hope I
> can be a co-maintainer of MIPS/fulong2e.
>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 642c8e0..3281ff2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1073,6 +1073,7 @@ F: hw/mips/mips_r4k.c
>  Fulong 2E
>  M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> +M: Huacai Chen <chenhc@lemote.com>
>  S: Odd Fixes
>  F: hw/mips/mips_fulong2e.c
>  F: hw/isa/vt82c686.c
> --
> 2.7.0
>

First of all, I want to express great pleasure and delight seing your
series, and this patch in particular.

A warm welcome to QEMU developers communities!

We are currenyly very busy preparing QEMU 5.0 release, and additionaly,
Easter holidays are in next few days or week (different parts od Christian
world have different calendars), so, fot thay and other reasons, don't
expect promot replies from us.

I would also like to see Jiaxng at least having official reviewer status,
but, of course, only if he wants that.

Yours,
and wishing you and all people from China best health!

Aleksandar

[-- Attachment #2: Type: text/html, Size: 2406 bytes --]

Re: [PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

[Huacai Chen]

Hi, Aleksandar,

On Wed, Apr 8, 2020 at 11:30 PM Aleksandar Markovic
<aleksandar.qemu.devel@gmail.com> wrote:
>
> 11:08 Sre, 08.04.2020. Huacai Chen <chenhc@lemote.com> је написао/ла:
> >
> > I submitted the MIPS/fulong2e support about ten years ago, and after
> > that I became a MIPS kernel developer. Last year, Philippe Mathieu-
> > Daudé asked me that whether I can be a reviewer of MIPS/fulong2e, and I
> > promised that I will do some QEMU work in the next year (i.e., 2020 and
> > later). I think now (and also in future) I can have some spare time, so
> > I can finally do some real work on QEMU/MIPS. And if possible, I hope I
> > can be a co-maintainer of MIPS/fulong2e.
> >
> > Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > Signed-off-by: Huacai Chen <chenhc@lemote.com>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 642c8e0..3281ff2 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1073,6 +1073,7 @@ F: hw/mips/mips_r4k.c
> >  Fulong 2E
> >  M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > +M: Huacai Chen <chenhc@lemote.com>
> >  S: Odd Fixes
> >  F: hw/mips/mips_fulong2e.c
> >  F: hw/isa/vt82c686.c
> > --
> > 2.7.0
> >
>
> First of all, I want to express great pleasure and delight seing your series, and this patch in particular.
>
> A warm welcome to QEMU developers communities!
>
> We are currenyly very busy preparing QEMU 5.0 release, and additionaly, Easter holidays are in next few days or week (different parts od Christian world have different calendars), so, fot thay and other reasons, don't expect promot replies from us.
>
> I would also like to see Jiaxng at least having official reviewer status, but, of course, only if he wants that.
Thank you for your best wishes, I'm also very glad to see Jiaxun be an reviewer.

Regards,
Huacai
>
> Yours,
> and wishing you and all people from China best health!
>
> Aleksandar

Re: [PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

[Jiaxun Yang]

On Thu, 9 Apr 2020 10:17:46 +0800
Huacai Chen <chenhc@lemote.com> wrote:

> Hi, Aleksandar,
> 
> On Wed, Apr 8, 2020 at 11:30 PM Aleksandar Markovic
> <aleksandar.qemu.devel@gmail.com> wrote:
> >
> > 11:08 Sre, 08.04.2020. Huacai Chen <chenhc@lemote.com> је
> > написао/ла:  
> > >
> > > I submitted the MIPS/fulong2e support about ten years ago, and
> > > after that I became a MIPS kernel developer. Last year, Philippe
> > > Mathieu- Daudé asked me that whether I can be a reviewer of
> > > MIPS/fulong2e, and I promised that I will do some QEMU work in
> > > the next year (i.e., 2020 and later). I think now (and also in
> > > future) I can have some spare time, so I can finally do some real
> > > work on QEMU/MIPS. And if possible, I hope I can be a
> > > co-maintainer of MIPS/fulong2e.
> > >
> > > Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > > Signed-off-by: Huacai Chen <chenhc@lemote.com>
> > > ---
> > >  MAINTAINERS | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 642c8e0..3281ff2 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -1073,6 +1073,7 @@ F: hw/mips/mips_r4k.c
> > >  Fulong 2E
> > >  M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > >  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > > +M: Huacai Chen <chenhc@lemote.com>
> > >  S: Odd Fixes
> > >  F: hw/mips/mips_fulong2e.c
> > >  F: hw/isa/vt82c686.c
> > > --
> > > 2.7.0
> > >  
> >
> > First of all, I want to express great pleasure and delight seing
> > your series, and this patch in particular.
> >
> > A warm welcome to QEMU developers communities!
> >
> > We are currenyly very busy preparing QEMU 5.0 release, and
> > additionaly, Easter holidays are in next few days or week
> > (different parts od Christian world have different calendars), so,
> > fot thay and other reasons, don't expect promot replies from us.
> >
> > I would also like to see Jiaxng at least having official reviewer
> > status, but, of course, only if he wants that.  
> Thank you for your best wishes, I'm also very glad to see Jiaxun be
> an reviewer.

Thanks, but I was a primary school student at Loongson-2E's era, so I
can do nothing with 2E.

My experience with Loongson starts from 2F. And I'm more familiar with
2K and 3A.

I'm happy to contribute QEMU support for these platforms.

Thanks.

> 
> Regards,
> Huacai
> >
> > Yours,
> > and wishing you and all people from China best health!
> >
> > Aleksandar  

--
Jiaxun Yang

Re: [PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

[Aleksandar Markovic]

[-- Attachment #1: Type: text/plain, Size: 3048 bytes --]

04:39 Čet, 09.04.2020. Jiaxun Yang <jiaxun.yang@flygoat.com> је написао/ла:
>
> On Thu, 9 Apr 2020 10:17:46 +0800
> Huacai Chen <chenhc@lemote.com> wrote:
>
> > Hi, Aleksandar,
> >
> > On Wed, Apr 8, 2020 at 11:30 PM Aleksandar Markovic
> > <aleksandar.qemu.devel@gmail.com> wrote:
> > >
> > > 11:08 Sre, 08.04.2020. Huacai Chen <chenhc@lemote.com> је
> > > написао/ла:
> > > >
> > > > I submitted the MIPS/fulong2e support about ten years ago, and
> > > > after that I became a MIPS kernel developer. Last year, Philippe
> > > > Mathieu- Daudé asked me that whether I can be a reviewer of
> > > > MIPS/fulong2e, and I promised that I will do some QEMU work in
> > > > the next year (i.e., 2020 and later). I think now (and also in
> > > > future) I can have some spare time, so I can finally do some real
> > > > work on QEMU/MIPS. And if possible, I hope I can be a
> > > > co-maintainer of MIPS/fulong2e.
> > > >
> > > > Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > > > Signed-off-by: Huacai Chen <chenhc@lemote.com>
> > > > ---
> > > >  MAINTAINERS | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 642c8e0..3281ff2 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -1073,6 +1073,7 @@ F: hw/mips/mips_r4k.c
> > > >  Fulong 2E
> > > >  M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > > >  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > > > +M: Huacai Chen <chenhc@lemote.com>
> > > >  S: Odd Fixes
> > > >  F: hw/mips/mips_fulong2e.c
> > > >  F: hw/isa/vt82c686.c
> > > > --
> > > > 2.7.0
> > > >
> > >
> > > First of all, I want to express great pleasure and delight seing
> > > your series, and this patch in particular.
> > >
> > > A warm welcome to QEMU developers communities!
> > >
> > > We are currenyly very busy preparing QEMU 5.0 release, and
> > > additionaly, Easter holidays are in next few days or week
> > > (different parts od Christian world have different calendars), so,
> > > fot thay and other reasons, don't expect promot replies from us.
> > >
> > > I would also like to see Jiaxng at least having official reviewer
> > > status, but, of course, only if he wants that.
> > Thank you for your best wishes, I'm also very glad to see Jiaxun be
> > an reviewer.
>
> Thanks, but I was a primary school student at Loongson-2E's era, so I
> can do nothing with 2E.
>
> My experience with Loongson starts from 2F. And I'm more familiar with
> 2K and 3A.
>

OK, it makes sense. But, if you ever become wanting to be a reviewer for
Foolong 2e, just give me an email.

> I'm happy to contribute QEMU support for these platforms.
>

I am happy as well.

Best wishes and best health to you, people from China, and the whole
region!!

Yours,
Aleksandar

> Thanks.
>
> >
> > Regards,
> > Huacai
> > >
> > > Yours,
> > > and wishing you and all people from China best health!
> > >
> > > Aleksandar
>
> --
> Jiaxun Yang

[-- Attachment #2: Type: text/html, Size: 4644 bytes --]

Re: [PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

[Philippe Mathieu-Daudé]

On 4/10/20 4:37 PM, Aleksandar Markovic wrote:
> 04:39 Čet, 09.04.2020. Jiaxun Yang <jiaxun.yang@flygoat.com
> <mailto:jiaxun.yang@flygoat.com>> је написао/ла:
>>
>> On Thu, 9 Apr 2020 10:17:46 +0800
>> Huacai Chen <chenhc@lemote.com <mailto:chenhc@lemote.com>> wrote:
>>
>> > Hi, Aleksandar,
>> >
>> > On Wed, Apr 8, 2020 at 11:30 PM Aleksandar Markovic
>> > <aleksandar.qemu.devel@gmail.com
> <mailto:aleksandar.qemu.devel@gmail.com>> wrote:
>> > >
>> > > 11:08 Sre, 08.04.2020. Huacai Chen <chenhc@lemote.com
> <mailto:chenhc@lemote.com>> је
>> > > написао/ла: 
>> > > >
>> > > > I submitted the MIPS/fulong2e support about ten years ago, and
>> > > > after that I became a MIPS kernel developer. Last year, Philippe
>> > > > Mathieu- Daudé asked me that whether I can be a reviewer of
>> > > > MIPS/fulong2e, and I promised that I will do some QEMU work in
>> > > > the next year (i.e., 2020 and later). I think now (and also in
>> > > > future) I can have some spare time, so I can finally do some real
>> > > > work on QEMU/MIPS. And if possible, I hope I can be a
>> > > > co-maintainer of MIPS/fulong2e.
>> > > >
>> > > > Cc: Jiaxun Yang <jiaxun.yang@flygoat.com
> <mailto:jiaxun.yang@flygoat.com>>
>> > > > Signed-off-by: Huacai Chen <chenhc@lemote.com
> <mailto:chenhc@lemote.com>>
>> > > > ---
>> > > >  MAINTAINERS | 1 +
>> > > >  1 file changed, 1 insertion(+)
>> > > >
>> > > > diff --git a/MAINTAINERS b/MAINTAINERS
>> > > > index 642c8e0..3281ff2 100644
>> > > > --- a/MAINTAINERS
>> > > > +++ b/MAINTAINERS
>> > > > @@ -1073,6 +1073,7 @@ F: hw/mips/mips_r4k.c
>> > > >  Fulong 2E
>> > > >  M: Philippe Mathieu-Daudé <f4bug@amsat.org
> <mailto:f4bug@amsat.org>>
>> > > >  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com
> <mailto:aleksandar.qemu.devel@gmail.com>>
>> > > > +M: Huacai Chen <chenhc@lemote.com <mailto:chenhc@lemote.com>>
>> > > >  S: Odd Fixes
>> > > >  F: hw/mips/mips_fulong2e.c
>> > > >  F: hw/isa/vt82c686.c
>> > > > --
>> > > > 2.7.0
>> > > > 
>> > >
>> > > First of all, I want to express great pleasure and delight seing
>> > > your series, and this patch in particular.
>> > >
>> > > A warm welcome to QEMU developers communities!
>> > >
>> > > We are currenyly very busy preparing QEMU 5.0 release, and
>> > > additionaly, Easter holidays are in next few days or week
>> > > (different parts od Christian world have different calendars), so,
>> > > fot thay and other reasons, don't expect promot replies from us.
>> > >
>> > > I would also like to see Jiaxng at least having official reviewer
>> > > status, but, of course, only if he wants that. 
>> > Thank you for your best wishes, I'm also very glad to see Jiaxun be
>> > an reviewer.
>>
>> Thanks, but I was a primary school student at Loongson-2E's era, so I
>> can do nothing with 2E.
>>
>> My experience with Loongson starts from 2F. And I'm more familiar with
>> 2K and 3A.

Thank you both of you, your help is very welcome :)

I have a simple series renaming "fulo[o]ng" I plan to send when the 5.1
development window opens, I'll include your patch.

>>
> 
> OK, it makes sense. But, if you ever become wanting to be a reviewer for
> Foolong 2e, just give me an email.
> 
>> I'm happy to contribute QEMU support for these platforms.
>>
> 
> I am happy as well.
> 
> Best wishes and best health to you, people from China, and the whole
> region!!
> 
> Yours,
> Aleksandar
> 
>> Thanks.
>>
>> >
>> > Regards,
>> > Huacai
>> > >
>> > > Yours,
>> > > and wishing you and all people from China best health!
>> > >
>> > > Aleksandar 
>>
>> --
>> Jiaxun Yang
> 

Re: [PATCH 1/3] target/mips: Support variable page size

[Aleksandar Markovic]

сре, 8. апр 2020. у 11:07 Huacai Chen <chenhc@lemote.com> је написао/ла:
>
> Traditionally, MIPS use 4KB page size, but Loongson prefer 16KB page
> size in system emulator. So, let's define TARGET_PAGE_BITS_VARY and
> TARGET_PAGE_BITS_MIN to support variable page size.
>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
>  target/mips/cpu-param.h | 5 +++++
>  1 file changed, 5 insertions(+)
>

Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>

> diff --git a/target/mips/cpu-param.h b/target/mips/cpu-param.h
> index 308660d..9c4a6ea 100644
> --- a/target/mips/cpu-param.h
> +++ b/target/mips/cpu-param.h
> @@ -23,7 +23,12 @@
>  #  define TARGET_VIRT_ADDR_SPACE_BITS 32
>  #endif
>  #endif
> +#ifdef CONFIG_USER_ONLY
>  #define TARGET_PAGE_BITS 12
> +#else
> +#define TARGET_PAGE_BITS_VARY
> +#define TARGET_PAGE_BITS_MIN 12
> +#endif
>  #define NB_MMU_MODES 4
>
>  #endif
> --
> 2.7.0
>

Re: [PATCH 2/3] mips/mips_fulong2e: Set preferred page size to 16KB

[Aleksandar Markovic]

сре, 8. апр 2020. у 11:08 Huacai Chen <chenhc@lemote.com> је написао/ла:
>
> Loongson processor prefers 16KB page size in system emulator, so let's
> define mc->minimum_page_bits to 14.
>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---

Huacai, thanks for the efforts regarding this series! I will very
likely accept patches 1/3 and 2/3 from this series in my next MIPS
queue, but the possible problem is that I somehow can't find patch 3/3
from my series in my mailbox. (I think it also the case with the cover
letter.) Could you perhaps resend the whole series? I'm concerned that
patch 3/3 contains something important, and it would be a shame that
it is omitted, and 1/3 and 2/3 are accepted.

For this patch:

Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>

>  hw/mips/mips_fulong2e.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index 5040afd..23897d7 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -399,6 +399,7 @@ static void mips_fulong2e_machine_init(MachineClass *mc)
>      mc->default_cpu_type = MIPS_CPU_TYPE_NAME("Loongson-2E");
>      mc->default_ram_size = 256 * MiB;
>      mc->default_ram_id = "fulong2e.ram";
> +    mc->minimum_page_bits = 14;
>  }
>
>  DEFINE_MACHINE("fulong2e", mips_fulong2e_machine_init)
> --
> 2.7.0
>

Re: [PATCH 2/3] mips/mips_fulong2e: Set preferred page size to 16KB

[Huacai Chen]

Hi, Aleksandar,

On Wed, May 13, 2020 at 3:56 PM Aleksandar Markovic
<aleksandar.qemu.devel@gmail.com> wrote:
>
> сре, 8. апр 2020. у 11:08 Huacai Chen <chenhc@lemote.com> је написао/ла:
> >
> > Loongson processor prefers 16KB page size in system emulator, so let's
> > define mc->minimum_page_bits to 14.
> >
> > Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > Signed-off-by: Huacai Chen <chenhc@lemote.com>
> > ---
>
> Huacai, thanks for the efforts regarding this series! I will very
> likely accept patches 1/3 and 2/3 from this series in my next MIPS
> queue, but the possible problem is that I somehow can't find patch 3/3
> from my series in my mailbox. (I think it also the case with the cover
> letter.) Could you perhaps resend the whole series? I'm concerned that
> patch 3/3 contains something important, and it would be a shame that
> it is omitted, and 1/3 and 2/3 are accepted.
Patch 3/3 is "Add myself as fulong2e co-maintainer", this is already
done in your series, so maybe I needn't resend?

Regards,
Huacai
>
> For this patch:
>
> Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>
> >  hw/mips/mips_fulong2e.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> > index 5040afd..23897d7 100644
> > --- a/hw/mips/mips_fulong2e.c
> > +++ b/hw/mips/mips_fulong2e.c
> > @@ -399,6 +399,7 @@ static void mips_fulong2e_machine_init(MachineClass *mc)
> >      mc->default_cpu_type = MIPS_CPU_TYPE_NAME("Loongson-2E");
> >      mc->default_ram_size = 256 * MiB;
> >      mc->default_ram_id = "fulong2e.ram";
> > +    mc->minimum_page_bits = 14;
> >  }
> >
> >  DEFINE_MACHINE("fulong2e", mips_fulong2e_machine_init)
> > --
> > 2.7.0
> >

Re: [PATCH 2/3] mips/mips_fulong2e: Set preferred page size to 16KB

[Aleksandar Markovic]

сре, 13. мај 2020. у 10:25 Huacai Chen <chenhc@lemote.com> је написао/ла:
>
> Hi, Aleksandar,
>
> On Wed, May 13, 2020 at 3:56 PM Aleksandar Markovic
> <aleksandar.qemu.devel@gmail.com> wrote:
> >
> > сре, 8. апр 2020. у 11:08 Huacai Chen <chenhc@lemote.com> је написао/ла:
> > >
> > > Loongson processor prefers 16KB page size in system emulator, so let's
> > > define mc->minimum_page_bits to 14.
> > >
> > > Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > > Signed-off-by: Huacai Chen <chenhc@lemote.com>
> > > ---
> >
> > Huacai, thanks for the efforts regarding this series! I will very
> > likely accept patches 1/3 and 2/3 from this series in my next MIPS
> > queue, but the possible problem is that I somehow can't find patch 3/3
> > from my series in my mailbox. (I think it also the case with the cover
> > letter.) Could you perhaps resend the whole series? I'm concerned that
> > patch 3/3 contains something important, and it would be a shame that
> > it is omitted, and 1/3 and 2/3 are accepted.
> Patch 3/3 is "Add myself as fulong2e co-maintainer", this is already
> done in your series, so maybe I needn't resend?
>

In that case, no need to resend, thanks!

Aleksandar

> Regards,
> Huacai
> >
> > For this patch:
> >
> > Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> >
> > >  hw/mips/mips_fulong2e.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> > > index 5040afd..23897d7 100644
> > > --- a/hw/mips/mips_fulong2e.c
> > > +++ b/hw/mips/mips_fulong2e.c
> > > @@ -399,6 +399,7 @@ static void mips_fulong2e_machine_init(MachineClass *mc)
> > >      mc->default_cpu_type = MIPS_CPU_TYPE_NAME("Loongson-2E");
> > >      mc->default_ram_size = 256 * MiB;
> > >      mc->default_ram_id = "fulong2e.ram";
> > > +    mc->minimum_page_bits = 14;
> > >  }
> > >
> > >  DEFINE_MACHINE("fulong2e", mips_fulong2e_machine_init)
> > > --
> > > 2.7.0
> > >

Re: [PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

[Aleksandar Markovic]

сре, 8. апр 2020. у 11:08 Huacai Chen <chenhc@lemote.com> је написао/ла:
>
> I submitted the MIPS/fulong2e support about ten years ago, and after
> that I became a MIPS kernel developer. Last year, Philippe Mathieu-
> Daudé asked me that whether I can be a reviewer of MIPS/fulong2e, and I
> promised that I will do some QEMU work in the next year (i.e., 2020 and
> later). I think now (and also in future) I can have some spare time, so
> I can finally do some real work on QEMU/MIPS. And if possible, I hope I
> can be a co-maintainer of MIPS/fulong2e.
>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---

Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>


>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 642c8e0..3281ff2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1073,6 +1073,7 @@ F: hw/mips/mips_r4k.c
>  Fulong 2E
>  M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>  M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> +M: Huacai Chen <chenhc@lemote.com>
>  S: Odd Fixes
>  F: hw/mips/mips_fulong2e.c
>  F: hw/isa/vt82c686.c
> --
> 2.7.0
>

Re: [PATCH 1/3] target/mips: Support variable page size

[Aleksandar Markovic]

On Wed, Apr 8, 2020 at 4:41 PM Huacai Chen <chenhc@lemote.com> wrote:
>
> Traditionally, MIPS use 4KB page size, but Loongson prefer 16KB page
> size in system emulator. So, let's define TARGET_PAGE_BITS_VARY and
> TARGET_PAGE_BITS_MIN to support variable page size.
>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---

Applied to MIPS queue.

Thanks and Regards,
Aleksandar

>  target/mips/cpu-param.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/target/mips/cpu-param.h b/target/mips/cpu-param.h
> index 308660d..9c4a6ea 100644
> --- a/target/mips/cpu-param.h
> +++ b/target/mips/cpu-param.h
> @@ -23,7 +23,12 @@
>  #  define TARGET_VIRT_ADDR_SPACE_BITS 32
>  #endif
>  #endif
> +#ifdef CONFIG_USER_ONLY
>  #define TARGET_PAGE_BITS 12
> +#else
> +#define TARGET_PAGE_BITS_VARY
> +#define TARGET_PAGE_BITS_MIN 12
> +#endif
>  #define NB_MMU_MODES 4
>
>  #endif
> --
> 2.7.0
>
>

Re: [PATCH 2/3] mips/mips_fulong2e: Set preferred page size to 16KB

[Aleksandar Markovic]

On Wed, Apr 8, 2020 at 4:41 PM Huacai Chen <chenhc@lemote.com> wrote:
>
> Loongson processor prefers 16KB page size in system emulator, so let's
> define mc->minimum_page_bits to 14.
>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---

Applied to MIPS queue.

Many thanks!
Aleksandar

>  hw/mips/mips_fulong2e.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index 5040afd..23897d7 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -399,6 +399,7 @@ static void mips_fulong2e_machine_init(MachineClass *mc)
>      mc->default_cpu_type = MIPS_CPU_TYPE_NAME("Loongson-2E");
>      mc->default_ram_size = 256 * MiB;
>      mc->default_ram_id = "fulong2e.ram";
> +    mc->minimum_page_bits = 14;
>  }
>
>  DEFINE_MACHINE("fulong2e", mips_fulong2e_machine_init)
> --
> 2.7.0
>
>

Re: [PATCH 1/3] target/mips: Support variable page size

[Aleksandar Markovic]

On Wed, Apr 8, 2020 at 4:41 PM Huacai Chen <chenhc@lemote.com> wrote:
>
> Traditionally, MIPS use 4KB page size, but Loongson prefer 16KB page
> size in system emulator. So, let's define TARGET_PAGE_BITS_VARY and
> TARGET_PAGE_BITS_MIN to support variable page size.
>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---

Applied to MIPS queue.

I hope this email will find you and all citizens of China in good
health and spirits!

Aleksandar

>  target/mips/cpu-param.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/target/mips/cpu-param.h b/target/mips/cpu-param.h
> index 308660d..9c4a6ea 100644
> --- a/target/mips/cpu-param.h
> +++ b/target/mips/cpu-param.h
> @@ -23,7 +23,12 @@
>  #  define TARGET_VIRT_ADDR_SPACE_BITS 32
>  #endif
>  #endif
> +#ifdef CONFIG_USER_ONLY
>  #define TARGET_PAGE_BITS 12
> +#else
> +#define TARGET_PAGE_BITS_VARY
> +#define TARGET_PAGE_BITS_MIN 12
> +#endif
>  #define NB_MMU_MODES 4
>
>  #endif
> --
> 2.7.0
>
>

[PATCH 2/3] mips/mips_fulong2e: Set preferred page size to 16KB

[Huacai Chen]

Loongson processor prefers 16KB page size in system emulator, so let's
define mc->minimum_page_bits to 14.

Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
 hw/mips/mips_fulong2e.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
index 5040afd..23897d7 100644
--- a/hw/mips/mips_fulong2e.c
+++ b/hw/mips/mips_fulong2e.c
@@ -399,6 +399,7 @@ static void mips_fulong2e_machine_init(MachineClass *mc)
     mc->default_cpu_type = MIPS_CPU_TYPE_NAME("Loongson-2E");
     mc->default_ram_size = 256 * MiB;
     mc->default_ram_id = "fulong2e.ram";
+    mc->minimum_page_bits = 14;
 }
 
 DEFINE_MACHINE("fulong2e", mips_fulong2e_machine_init)
-- 
2.7.0