All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Оля Тележная" <olyatelezhnaya@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic
Date: Fri, 30 Mar 2018 09:42:10 +0300	[thread overview]
Message-ID: <CAL21Bm=hcvk7LUKP4PY5FgXJFBDanf-=MMzFEMv-1paUHfojYg@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD2EjZ9-qeS-3oWWS8O8ayP92aXAxAb1qK9qjKKqDh7y2g@mail.gmail.com>

2018-03-29 17:41 GMT+03:00 Christian Couder <christian.couder@gmail.com>:
> On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhnaya@gmail.com> wrote:
>> Move helper function from strbuf to ref-filter.
>> Get rid of some memory leaks.
>
> The above seems to be the changes since v5. Usually in a cover letter
> (patch 0/X) there is both information about the goal of the patch
> series and the changes since last version.
>
> Repeating the goal in each version is useful for reviewers who might
> not have time to look at the patch series before, or who might have
> forgotten about it.

Thank you, I wasn't thinking about it that way. I agree, it's important.

Description:
The main idea of the patch is, if you want to format the output by
ref-filter, you should have an ability to work with errors and final
message by yourself if you want to.
So I decided not to touch signature of show_ref_array_item(), but to
move all die() invocations to it. So that we could invoke
format_ref_array_item() and be sure that we could handle errors by
ourselves, and we also get formatted message so we could continue
working with it if we want to.

Thank you,
Olga

      parent reply	other threads:[~2018-03-30  6:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 12:52 [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic Оля Тележная
2018-03-29 14:41 ` Christian Couder
2018-03-30  0:16   ` Eric Sunshine
2018-03-30  6:42   ` Оля Тележная [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL21Bm=hcvk7LUKP4PY5FgXJFBDanf-=MMzFEMv-1paUHfojYg@mail.gmail.com' \
    --to=olyatelezhnaya@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.