All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: "Оля Тележная" <olyatelezhnaya@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic
Date: Thu, 29 Mar 2018 20:16:50 -0400	[thread overview]
Message-ID: <CAPig+cTWKXrWggWO5EXA9dvpgW8rzZs=+XN3TK2GN4dM_gPiKg@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD2EjZ9-qeS-3oWWS8O8ayP92aXAxAb1qK9qjKKqDh7y2g@mail.gmail.com>

On Thu, Mar 29, 2018 at 10:41 AM, Christian Couder
<christian.couder@gmail.com> wrote:
> On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhnaya@gmail.com> wrote:
>> Move helper function from strbuf to ref-filter.
>> Get rid of some memory leaks.
>
> The above seems to be the changes since v5. Usually in a cover letter
> (patch 0/X) there is both information about the goal of the patch
> series and the changes since last version.
>
> Repeating the goal in each version is useful for reviewers who might
> not have time to look at the patch series before, or who might have
> forgotten about it.

Another important way to help both returning and new reviewers is to
provide a link to the previous iteration (or iterations), like
this[1].

Thanks.

[1]: https://public-inbox.org/git/0102016249d21c40-0edf6647-4d26-46fc-8cfd-5a446b93a5e2-000000@eu-west-1.amazonses.com/

  reply	other threads:[~2018-03-30  0:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 12:52 [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic Оля Тележная
2018-03-29 14:41 ` Christian Couder
2018-03-30  0:16   ` Eric Sunshine [this message]
2018-03-30  6:42   ` Оля Тележная

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cTWKXrWggWO5EXA9dvpgW8rzZs=+XN3TK2GN4dM_gPiKg@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=olyatelezhnaya@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.