All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs/076: fix file_size variable
@ 2023-09-25  4:33 Naohiro Aota
  2023-09-25 10:51 ` Filipe Manana
  0 siblings, 1 reply; 2+ messages in thread
From: Naohiro Aota @ 2023-09-25  4:33 UTC (permalink / raw)
  To: fstests; +Cc: linux-btrfs, Naohiro Aota

The file size written below is 10 MB, but the variable is set to 1 MB. Fix
it, or the test will fail.

Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
---
 tests/btrfs/076 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/btrfs/076 b/tests/btrfs/076
index 23f9bd534a0a..894a1ac7fa5d 100755
--- a/tests/btrfs/076
+++ b/tests/btrfs/076
@@ -37,7 +37,7 @@ if _scratch_btrfs_is_zoned; then
 		max_extent_size=$(( $zone_append_max / 4096 * 4096 ))
 	fi
 fi
-file_size=$(( 1 * 1024 * 1024 ))
+file_size=$(( 10 * 1024 * 1024 ))
 expect=$(( (file_size + max_extent_size - 1) / max_extent_size ))
 
 _scratch_mkfs >> $seqres.full 2>&1
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs/076: fix file_size variable
  2023-09-25  4:33 [PATCH] btrfs/076: fix file_size variable Naohiro Aota
@ 2023-09-25 10:51 ` Filipe Manana
  0 siblings, 0 replies; 2+ messages in thread
From: Filipe Manana @ 2023-09-25 10:51 UTC (permalink / raw)
  To: Naohiro Aota; +Cc: fstests, linux-btrfs

On Mon, Sep 25, 2023 at 5:34 AM Naohiro Aota <naohiro.aota@wdc.com> wrote:
>
> The file size written below is 10 MB, but the variable is set to 1 MB. Fix
> it, or the test will fail.
>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Ok, so this means that v3 of the recent patch:

https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?h=for-next&id=f4c7dbbb4f166996d8fefdebbceacd2f7d359dee

was completely untested and now the test always fails. Too bad.

Thanks for the fix.

> ---
>  tests/btrfs/076 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/076 b/tests/btrfs/076
> index 23f9bd534a0a..894a1ac7fa5d 100755
> --- a/tests/btrfs/076
> +++ b/tests/btrfs/076
> @@ -37,7 +37,7 @@ if _scratch_btrfs_is_zoned; then
>                 max_extent_size=$(( $zone_append_max / 4096 * 4096 ))
>         fi
>  fi
> -file_size=$(( 1 * 1024 * 1024 ))
> +file_size=$(( 10 * 1024 * 1024 ))
>  expect=$(( (file_size + max_extent_size - 1) / max_extent_size ))
>
>  _scratch_mkfs >> $seqres.full 2>&1
> --
> 2.42.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-25 10:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-25  4:33 [PATCH] btrfs/076: fix file_size variable Naohiro Aota
2023-09-25 10:51 ` Filipe Manana

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.