[PATCH] btrfs/283: skip if we cannot write into one extent

[PATCH] btrfs/283: skip if we cannot write into one extent

[Naohiro Aota]

On the zoned mode, the extent size is limited also by
queue/zone_append_max_bytes. This breaks the assumption that the file "foo"
has a single extent and corrupts the test output.

It is difficult to support the case, so let's just skip the test in this
case.

Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
---
 tests/btrfs/283 | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/btrfs/283 b/tests/btrfs/283
index c1f6007d5398..118df08b8958 100755
--- a/tests/btrfs/283
+++ b/tests/btrfs/283
@@ -25,6 +25,14 @@ _require_fssum
 _wants_kernel_commit c7499a64dcf6 \
 	     "btrfs: send: optimize clone detection to increase extent sharing"
 
+extent_size=$(( 128 * 1024 ))
+if _scratch_btrfs_is_zoned; then
+	zone_append_max=$(cat "/sys/block/$(_short_dev $SCRATCH_DEV)/queue/zone_append_max_bytes")
+	if [[ $zone_append_max -gt 0 && $zone_append_max -lt $extent_size ]]; then
+		_notrun "zone append max $zone_append_max is smaller than wanted extent size $extent_size"
+	fi
+fi
+
 send_files_dir=$TEST_DIR/btrfs-test-$seq
 send_stream=$send_files_dir/snap.stream
 snap_fssum=$send_files_dir/snap.fssum
-- 
2.42.0

Re: [PATCH] btrfs/283: skip if we cannot write into one extent

[Filipe Manana]

On Mon, Sep 25, 2023 at 6:55 AM Naohiro Aota <naohiro.aota@wdc.com> wrote:
>
> On the zoned mode, the extent size is limited also by
> queue/zone_append_max_bytes. This breaks the assumption that the file "foo"
> has a single extent and corrupts the test output.
>
> It is difficult to support the case, so let's just skip the test in this
> case.
>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Looks reasonable, thanks.

> ---
>  tests/btrfs/283 | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/tests/btrfs/283 b/tests/btrfs/283
> index c1f6007d5398..118df08b8958 100755
> --- a/tests/btrfs/283
> +++ b/tests/btrfs/283
> @@ -25,6 +25,14 @@ _require_fssum
>  _wants_kernel_commit c7499a64dcf6 \
>              "btrfs: send: optimize clone detection to increase extent sharing"
>
> +extent_size=$(( 128 * 1024 ))
> +if _scratch_btrfs_is_zoned; then
> +       zone_append_max=$(cat "/sys/block/$(_short_dev $SCRATCH_DEV)/queue/zone_append_max_bytes")
> +       if [[ $zone_append_max -gt 0 && $zone_append_max -lt $extent_size ]]; then
> +               _notrun "zone append max $zone_append_max is smaller than wanted extent size $extent_size"
> +       fi
> +fi
> +
>  send_files_dir=$TEST_DIR/btrfs-test-$seq
>  send_stream=$send_files_dir/snap.stream
>  snap_fssum=$send_files_dir/snap.fssum
> --
> 2.42.0
>