* [PATCH] Staging: rtl8192u: Replace TRUE with true
@ 2015-03-04 23:51 Ksenija Stanojevic
2015-03-05 1:38 ` [Outreachy kernel] " Jes Sorensen
0 siblings, 1 reply; 3+ messages in thread
From: Ksenija Stanojevic @ 2015-03-04 23:51 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic
This patch replaces TRUE by true, since Linux kernel has already a
boolean type, bool, defined in linux/stddef.h
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
index 96ab304..9f68c65 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
@@ -553,16 +553,16 @@ static void ieee80211_txrate_selectmode(struct ieee80211_device *ieee,
#ifdef TO_DO_LIST
if(!IsDataFrame(pFrame))
{
- pTcb->bTxDisableRateFallBack = TRUE;
- pTcb->bTxUseDriverAssingedRate = TRUE;
+ pTcb->bTxDisableRateFallBack = true;
+ pTcb->bTxUseDriverAssingedRate = true;
pTcb->RATRIndex = 7;
return;
}
if(pMgntInfo->ForcedDataRate!= 0)
{
- pTcb->bTxDisableRateFallBack = TRUE;
- pTcb->bTxUseDriverAssingedRate = TRUE;
+ pTcb->bTxDisableRateFallBack = true;
+ pTcb->bTxUseDriverAssingedRate = true;
return;
}
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Replace TRUE with true
2015-03-04 23:51 [PATCH] Staging: rtl8192u: Replace TRUE with true Ksenija Stanojevic
@ 2015-03-05 1:38 ` Jes Sorensen
2015-03-05 16:08 ` Ksenija Stanojević
0 siblings, 1 reply; 3+ messages in thread
From: Jes Sorensen @ 2015-03-05 1:38 UTC (permalink / raw)
To: Ksenija Stanojevic, outreachy-kernel
On 03/04/15 18:51, Ksenija Stanojevic wrote:
> This patch replaces TRUE by true, since Linux kernel has already a
> boolean type, bool, defined in linux/stddef.h
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Getting rid of their ugly TRUE is a good thing - however it would be
good to do the entire driver in one patch, and also get rid of the
#define of TRUE at the same time.
Cheers,
Jes
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> index 96ab304..9f68c65 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> @@ -553,16 +553,16 @@ static void ieee80211_txrate_selectmode(struct ieee80211_device *ieee,
> #ifdef TO_DO_LIST
> if(!IsDataFrame(pFrame))
> {
> - pTcb->bTxDisableRateFallBack = TRUE;
> - pTcb->bTxUseDriverAssingedRate = TRUE;
> + pTcb->bTxDisableRateFallBack = true;
> + pTcb->bTxUseDriverAssingedRate = true;
> pTcb->RATRIndex = 7;
> return;
> }
>
> if(pMgntInfo->ForcedDataRate!= 0)
> {
> - pTcb->bTxDisableRateFallBack = TRUE;
> - pTcb->bTxUseDriverAssingedRate = TRUE;
> + pTcb->bTxDisableRateFallBack = true;
> + pTcb->bTxUseDriverAssingedRate = true;
> return;
> }
> #endif
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Replace TRUE with true
2015-03-05 1:38 ` [Outreachy kernel] " Jes Sorensen
@ 2015-03-05 16:08 ` Ksenija Stanojević
0 siblings, 0 replies; 3+ messages in thread
From: Ksenija Stanojević @ 2015-03-05 16:08 UTC (permalink / raw)
To: Jes Sorensen; +Cc: outreachy-kernel
On Thu, Mar 5, 2015 at 2:38 AM, Jes Sorensen <jes.sorensen@gmail.com> wrote:
> On 03/04/15 18:51, Ksenija Stanojevic wrote:
>> This patch replaces TRUE by true, since Linux kernel has already a
>> boolean type, bool, defined in linux/stddef.h
>>
>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>> ---
>> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Getting rid of their ugly TRUE is a good thing - however it would be
> good to do the entire driver in one patch, and also get rid of the
> #define of TRUE at the same time.
Hi, I already got rid of a macros TRUE and FALSE defined in rtl8192U.h,
and I did a patchset on this, but it seems that this file via recursive headers
has access to a macros defined outside of this driver. Also its
better practice to first
replace TRUE and FALSE and then remove the macro. And yes I plan to do that, but
thanks for your observation
Ksenija
> Cheers,
> Jes
>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
>> index 96ab304..9f68c65 100644
>> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
>> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
>> @@ -553,16 +553,16 @@ static void ieee80211_txrate_selectmode(struct ieee80211_device *ieee,
>> #ifdef TO_DO_LIST
>> if(!IsDataFrame(pFrame))
>> {
>> - pTcb->bTxDisableRateFallBack = TRUE;
>> - pTcb->bTxUseDriverAssingedRate = TRUE;
>> + pTcb->bTxDisableRateFallBack = true;
>> + pTcb->bTxUseDriverAssingedRate = true;
>> pTcb->RATRIndex = 7;
>> return;
>> }
>>
>> if(pMgntInfo->ForcedDataRate!= 0)
>> {
>> - pTcb->bTxDisableRateFallBack = TRUE;
>> - pTcb->bTxUseDriverAssingedRate = TRUE;
>> + pTcb->bTxDisableRateFallBack = true;
>> + pTcb->bTxUseDriverAssingedRate = true;
>> return;
>> }
>> #endif
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-05 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-04 23:51 [PATCH] Staging: rtl8192u: Replace TRUE with true Ksenija Stanojevic
2015-03-05 1:38 ` [Outreachy kernel] " Jes Sorensen
2015-03-05 16:08 ` Ksenija Stanojević
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.