[PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports

[PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports

[Feng Kan]

This adds ACPI support for the APM X-Gene SATA ports. When the system
boots using ACPI table, the SATA ports are able to configure using the
values supplied by the ACPI table rather than the DTS.

Signed-off-by: Feng Kan <fkan@apm.com>
---
 drivers/ata/ahci_xgene.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index d0c851a..4951392 100644
--- a/drivers/ata/ahci_xgene.c
+++ b/drivers/ata/ahci_xgene.c
@@ -22,6 +22,7 @@
  * NOTE: PM support is not currently available.
  *
  */
+#include <linux/acpi.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/ahci_platform.h>
@@ -521,6 +522,14 @@ disable_resources:
 	return rc;
 }
 
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id xgene_ahci_acpi_match[] = {
+	{ "APMC0D0D", },
+	{ }
+};
+MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match);
+#endif
+
 static const struct of_device_id xgene_ahci_of_match[] = {
 	{.compatible = "apm,xgene-ahci"},
 	{},
@@ -534,6 +543,7 @@ static struct platform_driver xgene_ahci_driver = {
 		.name = "xgene-ahci",
 		.owner = THIS_MODULE,
 		.of_match_table = xgene_ahci_of_match,
+		.acpi_match_table = ACPI_PTR(xgene_ahci_acpi_match),
 	},
 };
 
-- 
1.9.1

Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports

[Feng Kan]

Just want to ping this again.

Happy new year

On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com> wrote:
> This adds ACPI support for the APM X-Gene SATA ports. When the system
> boots using ACPI table, the SATA ports are able to configure using the
> values supplied by the ACPI table rather than the DTS.
>
> Signed-off-by: Feng Kan <fkan@apm.com>
> ---
>  drivers/ata/ahci_xgene.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
> index d0c851a..4951392 100644
> --- a/drivers/ata/ahci_xgene.c
> +++ b/drivers/ata/ahci_xgene.c
> @@ -22,6 +22,7 @@
>   * NOTE: PM support is not currently available.
>   *
>   */
> +#include <linux/acpi.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/ahci_platform.h>
> @@ -521,6 +522,14 @@ disable_resources:
>         return rc;
>  }
>
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id xgene_ahci_acpi_match[] = {
> +       { "APMC0D0D", },
> +       { }
> +};
> +MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match);
> +#endif
> +
>  static const struct of_device_id xgene_ahci_of_match[] = {
>         {.compatible = "apm,xgene-ahci"},
>         {},
> @@ -534,6 +543,7 @@ static struct platform_driver xgene_ahci_driver = {
>                 .name = "xgene-ahci",
>                 .owner = THIS_MODULE,
>                 .of_match_table = xgene_ahci_of_match,
> +               .acpi_match_table = ACPI_PTR(xgene_ahci_acpi_match),
>         },
>  };
>
> --
> 1.9.1
>

Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports

[Hanjun Guo]

Hi Feng Kan,

I have some comments below.

On 2015年01月08日 01:32, Feng Kan wrote:
> Just want to ping this again.
>
> Happy new year
>
> On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com> wrote:
>> This adds ACPI support for the APM X-Gene SATA ports. When the system
>> boots using ACPI table, the SATA ports are able to configure using the
>> values supplied by the ACPI table rather than the DTS.
>>
>> Signed-off-by: Feng Kan <fkan@apm.com>
>> ---
>>   drivers/ata/ahci_xgene.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
>> index d0c851a..4951392 100644
>> --- a/drivers/ata/ahci_xgene.c
>> +++ b/drivers/ata/ahci_xgene.c
>> @@ -22,6 +22,7 @@
>>    * NOTE: PM support is not currently available.
>>    *
>>    */
>> +#include <linux/acpi.h>
>>   #include <linux/module.h>
>>   #include <linux/platform_device.h>
>>   #include <linux/ahci_platform.h>
>> @@ -521,6 +522,14 @@ disable_resources:
>>          return rc;
>>   }
>>
>> +#ifdef CONFIG_ACPI
>> +static const struct acpi_device_id xgene_ahci_acpi_match[] = {
>> +       { "APMC0D0D", },

When I was going through the PNP and ACPI ID list in
http://www.uefi.org/PNP_ACPI_Registry, I found that
there is no "APMC" for ACPI ID, I only found that there is
a PNP ID "APM" for Applied Memory Tech company, are
you using PNP ID for this one?

if not, I think you can send a request to UEFI and
request a new ACPI ID of "APMC" for Applied Micro, and then
submit the patch again.

How to send a request to register the ACPI ID, you can
refer to:
http://www.uefi.org/PNP_ACPI_Registry

Thanks
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports

[Hanjun Guo]

Hi Feng Kan,

I have some comments below.

On 2015年01月08日 01:32, Feng Kan wrote:
> Just want to ping this again.
>
> Happy new year
>
> On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com> wrote:
>> This adds ACPI support for the APM X-Gene SATA ports. When the system
>> boots using ACPI table, the SATA ports are able to configure using the
>> values supplied by the ACPI table rather than the DTS.
>>
>> Signed-off-by: Feng Kan <fkan@apm.com>
>> ---
>>   drivers/ata/ahci_xgene.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
>> index d0c851a..4951392 100644
>> --- a/drivers/ata/ahci_xgene.c
>> +++ b/drivers/ata/ahci_xgene.c
>> @@ -22,6 +22,7 @@
>>    * NOTE: PM support is not currently available.
>>    *
>>    */
>> +#include <linux/acpi.h>
>>   #include <linux/module.h>
>>   #include <linux/platform_device.h>
>>   #include <linux/ahci_platform.h>
>> @@ -521,6 +522,14 @@ disable_resources:
>>          return rc;
>>   }
>>
>> +#ifdef CONFIG_ACPI
>> +static const struct acpi_device_id xgene_ahci_acpi_match[] = {
>> +       { "APMC0D0D", },

When I was going through the PNP and ACPI ID list in
http://www.uefi.org/PNP_ACPI_Registry, I found that
there is no "APMC" for ACPI ID, I only found that there is
a PNP ID "APM" for Applied Memory Tech company, are
you using PNP ID for this one?

if not, I think you can send a request to UEFI and
request a new ACPI ID of "APMC" for Applied Micro, and then
submit the patch again.

How to send a request to register the ACPI ID, you can
refer to:
http://www.uefi.org/PNP_ACPI_Registry

Thanks
Hanjun

Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports

[Feng Kan]

On Wed, Jan 7, 2015 at 11:50 PM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
> Hi Feng Kan,
>
> I have some comments below.
>
>
> On 2015年01月08日 01:32, Feng Kan wrote:
>>
>> Just want to ping this again.
>>
>> Happy new year
>>
>> On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com> wrote:
>>>
>>> This adds ACPI support for the APM X-Gene SATA ports. When the system
>>> boots using ACPI table, the SATA ports are able to configure using the
>>> values supplied by the ACPI table rather than the DTS.
>>>
>>> Signed-off-by: Feng Kan <fkan@apm.com>
>>> ---
>>>   drivers/ata/ahci_xgene.c | 10 ++++++++++
>>>   1 file changed, 10 insertions(+)
>>>
>>> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
>>> index d0c851a..4951392 100644
>>> --- a/drivers/ata/ahci_xgene.c
>>> +++ b/drivers/ata/ahci_xgene.c
>>> @@ -22,6 +22,7 @@
>>>    * NOTE: PM support is not currently available.
>>>    *
>>>    */
>>> +#include <linux/acpi.h>
>>>   #include <linux/module.h>
>>>   #include <linux/platform_device.h>
>>>   #include <linux/ahci_platform.h>
>>> @@ -521,6 +522,14 @@ disable_resources:
>>>          return rc;
>>>   }
>>>
>>> +#ifdef CONFIG_ACPI
>>> +static const struct acpi_device_id xgene_ahci_acpi_match[] = {
>>> +       { "APMC0D0D", },
>
>
> When I was going through the PNP and ACPI ID list in
> http://www.uefi.org/PNP_ACPI_Registry, I found that
> there is no "APMC" for ACPI ID, I only found that there is
> a PNP ID "APM" for Applied Memory Tech company, are
> you using PNP ID for this one?
>
> if not, I think you can send a request to UEFI and
> request a new ACPI ID of "APMC" for Applied Micro, and then
> submit the patch again.
>
> How to send a request to register the ACPI ID, you can
> refer to:
> http://www.uefi.org/PNP_ACPI_Registry

Hanjun, the documents are bit out of sync. We have received approval and
it is present in the document link below. I can also forward the approval letter
if it needed.

http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2/ISA%20PNPID%20List.xlsx


>
> Thanks
> Hanjun

Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports

[Hanjun Guo]

On 2015年01月09日 01:56, Feng Kan wrote:
> On Wed, Jan 7, 2015 at 11:50 PM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>> Hi Feng Kan,
>>
>> I have some comments below.
>>
>>
>> On 2015年01月08日 01:32, Feng Kan wrote:
>>>
>>> Just want to ping this again.
>>>
>>> Happy new year
>>>
>>> On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com> wrote:
>>>>
>>>> This adds ACPI support for the APM X-Gene SATA ports. When the system
>>>> boots using ACPI table, the SATA ports are able to configure using the
>>>> values supplied by the ACPI table rather than the DTS.
>>>>
>>>> Signed-off-by: Feng Kan <fkan@apm.com>
>>>> ---
>>>>    drivers/ata/ahci_xgene.c | 10 ++++++++++
>>>>    1 file changed, 10 insertions(+)
>>>>
>>>> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
>>>> index d0c851a..4951392 100644
>>>> --- a/drivers/ata/ahci_xgene.c
>>>> +++ b/drivers/ata/ahci_xgene.c
>>>> @@ -22,6 +22,7 @@
>>>>     * NOTE: PM support is not currently available.
>>>>     *
>>>>     */
>>>> +#include <linux/acpi.h>
>>>>    #include <linux/module.h>
>>>>    #include <linux/platform_device.h>
>>>>    #include <linux/ahci_platform.h>
>>>> @@ -521,6 +522,14 @@ disable_resources:
>>>>           return rc;
>>>>    }
>>>>
>>>> +#ifdef CONFIG_ACPI
>>>> +static const struct acpi_device_id xgene_ahci_acpi_match[] = {
>>>> +       { "APMC0D0D", },
>>
>>
>> When I was going through the PNP and ACPI ID list in
>> http://www.uefi.org/PNP_ACPI_Registry, I found that
>> there is no "APMC" for ACPI ID, I only found that there is
>> a PNP ID "APM" for Applied Memory Tech company, are
>> you using PNP ID for this one?
>>
>> if not, I think you can send a request to UEFI and
>> request a new ACPI ID of "APMC" for Applied Micro, and then
>> submit the patch again.
>>
>> How to send a request to register the ACPI ID, you can
>> refer to:
>> http://www.uefi.org/PNP_ACPI_Registry
>
> Hanjun, the documents are bit out of sync. We have received approval and
> it is present in the document link below. I can also forward the approval letter
> if it needed.
>
> http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2/ISA%20PNPID%20List.xlsx

Sorry for missing this link, I think I should report this
inconsistency to ACPI spec working group and then update it
accordingly.

Thanks
Hanjun

Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports

[Hanjun Guo]

On 2015年01月13日 05:07, Suman Tripathi wrote:
> Hi,
>
> Tested-by: Suman Tripathi <stripathi@apm.com>
>
> On Thu, Jan 8, 2015 at 11:35 PM, Hanjun Guo <hanjun.guo@linaro.org
> <mailto:hanjun.guo@linaro.org>> wrote:
>
>     On 2015年01月09日 01:56, Feng Kan wrote:
>
>         On Wed, Jan 7, 2015 at 11:50 PM, Hanjun Guo
>         <hanjun.guo@linaro.org <mailto:hanjun.guo@linaro.org>> wrote:
>
>             Hi Feng Kan,
>
>             I have some comments below.
>
>
>             On 2015年01月08日 01:32, Feng Kan wrote:
>
>
>                 Just want to ping this again.
>
>                 Happy new year
>
>                 On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com
>                 <mailto:fkan@apm.com>> wrote:
>
>
>                     This adds ACPI support for the APM X-Gene SATA
>                     ports. When the system
>                     boots using ACPI table, the SATA ports are able to
>                     configure using the
>                     values supplied by the ACPI table rather than the DTS.
>
>                     Signed-off-by: Feng Kan <fkan@apm.com
>                     <mailto:fkan@apm.com>>
>                     ---
>                         drivers/ata/ahci_xgene.c | 10 ++++++++++
>                         1 file changed, 10 insertions(+)
>
>                     diff --git a/drivers/ata/ahci_xgene.c
>                     b/drivers/ata/ahci_xgene.c
>                     index d0c851a..4951392 100644
>                     --- a/drivers/ata/ahci_xgene.c
>                     +++ b/drivers/ata/ahci_xgene.c
>                     @@ -22,6 +22,7 @@
>                          * NOTE: PM support is not currently available.
>                          *
>                          */
>                     +#include <linux/acpi.h>
>                         #include <linux/module.h>
>                         #include <linux/platform_device.h>
>                         #include <linux/ahci_platform.h>
>                     @@ -521,6 +522,14 @@ disable_resources:
>                                return rc;
>                         }
>
>                     +#ifdef CONFIG_ACPI
>                     +static const struct acpi_device_id
>                     xgene_ahci_acpi_match[] = {
>                     +       { "APMC0D0D", },
>
>
>
>             When I was going through the PNP and ACPI ID list in
>             http://www.uefi.org/PNP_ACPI___Registry
>             <http://www.uefi.org/PNP_ACPI_Registry>, I found that
>             there is no "APMC" for ACPI ID, I only found that there is
>             a PNP ID "APM" for Applied Memory Tech company, are
>             you using PNP ID for this one?
>
>             if not, I think you can send a request to UEFI and
>             request a new ACPI ID of "APMC" for Applied Micro, and then
>             submit the patch again.
>
>             How to send a request to register the ACPI ID, you can
>             refer to:
>             http://www.uefi.org/PNP_ACPI___Registry
>             <http://www.uefi.org/PNP_ACPI_Registry>
>
>
>         Hanjun, the documents are bit out of sync. We have received
>         approval and
>         it is present in the document link below. I can also forward the
>         approval letter
>         if it needed.
>
>         http://download.microsoft.com/__download/7/E/7/7E7662CF-CBEA-__470B-A97E-CE7CE0D98DC2/ISA%__20PNPID%20List.xlsx
>         <http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2/ISA%20PNPID%20List.xlsx>
>
>
>     Sorry for missing this link, I think I should report this
>     inconsistency to ACPI spec working group and then update it
>     accordingly.

Also I had reported this issue to ASWG and some people will
check with this issue and fix it, so

Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>

Thanks
Hanjun

Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports

[Feng Kan]

On Mon, Jan 12, 2015 at 10:29 PM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
> On 2015年01月13日 05:07, Suman Tripathi wrote:
>>
>> Hi,
>>
>> Tested-by: Suman Tripathi <stripathi@apm.com>
>>
>> On Thu, Jan 8, 2015 at 11:35 PM, Hanjun Guo <hanjun.guo@linaro.org
>> <mailto:hanjun.guo@linaro.org>> wrote:
>>
>>     On 2015年01月09日 01:56, Feng Kan wrote:
>>
>>         On Wed, Jan 7, 2015 at 11:50 PM, Hanjun Guo
>>         <hanjun.guo@linaro.org <mailto:hanjun.guo@linaro.org>> wrote:
>>
>>             Hi Feng Kan,
>>
>>             I have some comments below.
>>
>>
>>             On 2015年01月08日 01:32, Feng Kan wrote:
>>
>>
>>                 Just want to ping this again.
>>
>>                 Happy new year
>>
>>                 On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com
>>                 <mailto:fkan@apm.com>> wrote:
>>
>>
>>                     This adds ACPI support for the APM X-Gene SATA
>>                     ports. When the system
>>                     boots using ACPI table, the SATA ports are able to
>>                     configure using the
>>                     values supplied by the ACPI table rather than the DTS.
>>
>>                     Signed-off-by: Feng Kan <fkan@apm.com
>>                     <mailto:fkan@apm.com>>
>>                     ---
>>                         drivers/ata/ahci_xgene.c | 10 ++++++++++
>>                         1 file changed, 10 insertions(+)
>>
>>                     diff --git a/drivers/ata/ahci_xgene.c
>>                     b/drivers/ata/ahci_xgene.c
>>                     index d0c851a..4951392 100644
>>                     --- a/drivers/ata/ahci_xgene.c
>>                     +++ b/drivers/ata/ahci_xgene.c
>>                     @@ -22,6 +22,7 @@
>>                          * NOTE: PM support is not currently available.
>>                          *
>>                          */
>>                     +#include <linux/acpi.h>
>>                         #include <linux/module.h>
>>                         #include <linux/platform_device.h>
>>                         #include <linux/ahci_platform.h>
>>                     @@ -521,6 +522,14 @@ disable_resources:
>>                                return rc;
>>                         }
>>
>>                     +#ifdef CONFIG_ACPI
>>                     +static const struct acpi_device_id
>>                     xgene_ahci_acpi_match[] = {
>>                     +       { "APMC0D0D", },
>>
>>
>>
>>             When I was going through the PNP and ACPI ID list in
>>             http://www.uefi.org/PNP_ACPI___Registry
>>             <http://www.uefi.org/PNP_ACPI_Registry>, I found that
>>             there is no "APMC" for ACPI ID, I only found that there is
>>             a PNP ID "APM" for Applied Memory Tech company, are
>>             you using PNP ID for this one?
>>
>>             if not, I think you can send a request to UEFI and
>>             request a new ACPI ID of "APMC" for Applied Micro, and then
>>             submit the patch again.
>>
>>             How to send a request to register the ACPI ID, you can
>>             refer to:
>>             http://www.uefi.org/PNP_ACPI___Registry
>>             <http://www.uefi.org/PNP_ACPI_Registry>
>>
>>
>>         Hanjun, the documents are bit out of sync. We have received
>>         approval and
>>         it is present in the document link below. I can also forward the
>>         approval letter
>>         if it needed.
>>
>>
>> http://download.microsoft.com/__download/7/E/7/7E7662CF-CBEA-__470B-A97E-CE7CE0D98DC2/ISA%__20PNPID%20List.xlsx
>>
>> <http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2/ISA%20PNPID%20List.xlsx>
>>
>>
>>     Sorry for missing this link, I think I should report this
>>     inconsistency to ACPI spec working group and then update it
>>     accordingly.
>
>
> Also I had reported this issue to ASWG and some people will
> check with this issue and fix it, so
>
> Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>

Hi. Is there a chance this can make it into tree. Thanks

>
> Thanks
> Hanjun