All of lore.kernel.org
 help / color / mirror / Atom feed
* dvb lock patch
@ 2012-03-04 20:49 Josu Lazkano
       [not found] ` <4f6ca10f.e503b40a.4448.ffffc0feSMTPIN_ADDED@mx.google.com>
  2012-03-24 14:32 ` Mauro Carvalho Chehab
  0 siblings, 2 replies; 10+ messages in thread
From: Josu Lazkano @ 2012-03-04 20:49 UTC (permalink / raw)
  To: linux-media

Hello all, I am using this patch to get virtual adapters for DVB
devices: https://aur.archlinux.org/packages/sa/sascng-linux3-patch/sascng-linux3-patch.tar.gz

Here is more info: https://aur.archlinux.org/packages.php?ID=51325

Is it possible to add this patch on the dvb source?

This patch is needed for people who not have a CI and need to create
virtual adapters to get a working pay-tv system.

Best regards.

-- 
Josu Lazkano

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dvb lock patch
       [not found] ` <4f6ca10f.e503b40a.4448.ffffc0feSMTPIN_ADDED@mx.google.com>
@ 2012-03-23 16:15   ` Josu Lazkano
  0 siblings, 0 replies; 10+ messages in thread
From: Josu Lazkano @ 2012-03-23 16:15 UTC (permalink / raw)
  To: Angela Schmid; +Cc: linux-media

2012/3/23 Angela Schmid <angela.schmid@wolke7.net>:
> Hello Josu
>
> Maybe I have overseen any replies. Did you got some ?
>
> Angela
>

Hello, there is no replys, I think that this is not interesting for developers.

Kind regards.

-- 
Josu Lazkano

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dvb lock patch
  2012-03-04 20:49 dvb lock patch Josu Lazkano
       [not found] ` <4f6ca10f.e503b40a.4448.ffffc0feSMTPIN_ADDED@mx.google.com>
@ 2012-03-24 14:32 ` Mauro Carvalho Chehab
  2012-04-17 13:30   ` Josu Lazkano
  1 sibling, 1 reply; 10+ messages in thread
From: Mauro Carvalho Chehab @ 2012-03-24 14:32 UTC (permalink / raw)
  To: Josu Lazkano; +Cc: linux-media

Em 04-03-2012 17:49, Josu Lazkano escreveu:
> Hello all, I am using this patch to get virtual adapters for DVB
> devices: https://aur.archlinux.org/packages/sa/sascng-linux3-patch/sascng-linux3-patch.tar.gz
> 
> Here is more info: https://aur.archlinux.org/packages.php?ID=51325
> 
> Is it possible to add this patch on the dvb source?
> 
> This patch is needed for people who not have a CI and need to create
> virtual adapters to get a working pay-tv system.

Please always send the diff, instead to a point to some tarball, otherwise
most developers won't care enough to see what's there.

Anyway:

> diff -Nur linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c
> --- linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c
> +++ linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c
> @@ -83,8 +83,11 @@ static int dvb_device_open(struct inode *inode, struct file *file)
>  			file->f_op = old_fops;
>  			goto fail;
>  		}
> -		if(file->f_op->open)
> +		if(file->f_op->open) {
> +			mutex_unlock(&dvbdev_mutex);
>  			err = file->f_op->open(inode,file);
> +			mutex_lock(&dvbdev_mutex);
> +		}
>  		if (err) {
>  			fops_put(file->f_op);
>  			file->f_op = fops_get(old_fops);
> -- 
> 

That doesn't sound right to me, and can actually cause race issues.

Regards,
Mauro.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dvb lock patch
  2012-03-24 14:32 ` Mauro Carvalho Chehab
@ 2012-04-17 13:30   ` Josu Lazkano
  2012-04-18 18:58     ` Ezequiel García
  0 siblings, 1 reply; 10+ messages in thread
From: Josu Lazkano @ 2012-04-17 13:30 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-media

2012/3/24 Mauro Carvalho Chehab <mchehab@redhat.com>:
> Em 04-03-2012 17:49, Josu Lazkano escreveu:
>> Hello all, I am using this patch to get virtual adapters for DVB
>> devices: https://aur.archlinux.org/packages/sa/sascng-linux3-patch/sascng-linux3-patch.tar.gz
>>
>> Here is more info: https://aur.archlinux.org/packages.php?ID=51325
>>
>> Is it possible to add this patch on the dvb source?
>>
>> This patch is needed for people who not have a CI and need to create
>> virtual adapters to get a working pay-tv system.
>
> Please always send the diff, instead to a point to some tarball, otherwise
> most developers won't care enough to see what's there.
>
> Anyway:
>
>> diff -Nur linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c
>> --- linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c
>> +++ linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c
>> @@ -83,8 +83,11 @@ static int dvb_device_open(struct inode *inode, struct file *file)
>>                       file->f_op = old_fops;
>>                       goto fail;
>>               }
>> -             if(file->f_op->open)
>> +             if(file->f_op->open) {
>> +                     mutex_unlock(&dvbdev_mutex);
>>                       err = file->f_op->open(inode,file);
>> +                     mutex_lock(&dvbdev_mutex);
>> +             }
>>               if (err) {
>>                       fops_put(file->f_op);
>>                       file->f_op = fops_get(old_fops);
>> --
>>
>
> That doesn't sound right to me, and can actually cause race issues.
>
> Regards,
> Mauro.

Thanks for the patch Mauro.

Regards.

-- 
Josu Lazkano

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dvb lock patch
  2012-04-17 13:30   ` Josu Lazkano
@ 2012-04-18 18:58     ` Ezequiel García
  2012-04-18 19:19       ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 10+ messages in thread
From: Ezequiel García @ 2012-04-18 18:58 UTC (permalink / raw)
  To: Josu Lazkano; +Cc: Mauro Carvalho Chehab, linux-media

Josu,

On Tue, Apr 17, 2012 at 10:30 AM, Josu Lazkano <josu.lazkano@gmail.com> wrote:
> 2012/3/24 Mauro Carvalho Chehab <mchehab@redhat.com>:
[snip]
>>
>> That doesn't sound right to me, and can actually cause race issues.
>>
>> Regards,
>> Mauro.
>
> Thanks for the patch Mauro.
>

I think Mauro is *not* giving you a patch, rather the opposite:
pointing out that the patch can
cause problems!

Regards,
Ezequiel.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dvb lock patch
  2012-04-18 18:58     ` Ezequiel García
@ 2012-04-18 19:19       ` Mauro Carvalho Chehab
  2012-04-18 20:13         ` Josu Lazkano
  0 siblings, 1 reply; 10+ messages in thread
From: Mauro Carvalho Chehab @ 2012-04-18 19:19 UTC (permalink / raw)
  To: Ezequiel García; +Cc: Josu Lazkano, linux-media

Em 18-04-2012 15:58, Ezequiel García escreveu:
> Josu,
> 
> On Tue, Apr 17, 2012 at 10:30 AM, Josu Lazkano <josu.lazkano@gmail.com> wrote:
>> 2012/3/24 Mauro Carvalho Chehab <mchehab@redhat.com>:
> [snip]
>>>
>>> That doesn't sound right to me, and can actually cause race issues.
>>>
>>> Regards,
>>> Mauro.
>>
>> Thanks for the patch Mauro.
>>
> 
> I think Mauro is *not* giving you a patch, rather the opposite:
> pointing out that the patch can
> cause problems!

Yes. The driver will be unreliable with a patch like that, due to
race conditions.

> Regards,
> Ezequiel.

Regards,
Mauro.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dvb lock patch
  2012-04-18 19:19       ` Mauro Carvalho Chehab
@ 2012-04-18 20:13         ` Josu Lazkano
  2012-04-19 22:39           ` Torfinn Ingolfsen
  0 siblings, 1 reply; 10+ messages in thread
From: Josu Lazkano @ 2012-04-18 20:13 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: Ezequiel García, linux-media

El día 18 de abril de 2012 21:19, Mauro Carvalho Chehab
<mchehab@redhat.com> escribió:
> Em 18-04-2012 15:58, Ezequiel García escreveu:
>> Josu,
>>
>> On Tue, Apr 17, 2012 at 10:30 AM, Josu Lazkano <josu.lazkano@gmail.com> wrote:
>>> 2012/3/24 Mauro Carvalho Chehab <mchehab@redhat.com>:
>> [snip]
>>>>
>>>> That doesn't sound right to me, and can actually cause race issues.
>>>>
>>>> Regards,
>>>> Mauro.
>>>
>>> Thanks for the patch Mauro.
>>>
>>
>> I think Mauro is *not* giving you a patch, rather the opposite:
>> pointing out that the patch can
>> cause problems!
>
> Yes. The driver will be unreliable with a patch like that, due to
> race conditions.
>
>> Regards,
>> Ezequiel.
>
> Regards,
> Mauro.

Thanks anyway.

I am looking for a solution to use virtual adapters on MythTV to use
my satellite provider card on two machines.
With 2.6.32 kernel is working great, but there is no way to work with
3.x kernel.

Is anyone using sasc-ng with latest kernel?

Kind regards.

-- 
Josu Lazkano

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dvb lock patch
  2012-04-18 20:13         ` Josu Lazkano
@ 2012-04-19 22:39           ` Torfinn Ingolfsen
  2012-04-21 12:18             ` Josu Lazkano
  0 siblings, 1 reply; 10+ messages in thread
From: Torfinn Ingolfsen @ 2012-04-19 22:39 UTC (permalink / raw)
  To: linux-media

2012/4/18 Josu Lazkano <josu.lazkano@gmail.com>:
> El día 18 de abril de 2012 21:19, Mauro Carvalho Chehab
> <mchehab@redhat.com> escribió:
>> Em 18-04-2012 15:58, Ezequiel García escreveu:
>>> Josu,
>>>
>>> On Tue, Apr 17, 2012 at 10:30 AM, Josu Lazkano <josu.lazkano@gmail.com> wrote:
>>>> 2012/3/24 Mauro Carvalho Chehab <mchehab@redhat.com>:
>>> [snip]
>>>>>
>>>>> That doesn't sound right to me, and can actually cause race issues.
>>>>>
>>>>> Regards,
>>>>> Mauro.
>>>>
>>>> Thanks for the patch Mauro.
>>>>
>>>
>>> I think Mauro is *not* giving you a patch, rather the opposite:
>>> pointing out that the patch can
>>> cause problems!
>>
>> Yes. The driver will be unreliable with a patch like that, due to
>> race conditions.
>>
>>> Regards,
>>> Ezequiel.
>>
>> Regards,
>> Mauro.
>
> Thanks anyway.
>
> I am looking for a solution to use virtual adapters on MythTV to use
> my satellite provider card on two machines.
> With 2.6.32 kernel is working great, but there is no way to work with
> 3.x kernel.
>
> Is anyone using sasc-ng with latest kernel?
>

Would kernel 3.0.0.15 do?
If so, descriptions on how I did it here:
http://sites.google.com/site/tingox/digitaltv_sascng
http://sites.google.com/site/tingox/asrock_e350m1_xubuntu

Note: these are my work notes, not a how-to!

As you can see, I'm using this patch:
http://kipdola.be/subdomain/linux-2.6.38-dvb-mutex.patch

It seems to work for me (had it running with Kaffeine on encrypted
channesl for two weeks in a row)

HTH
-- 
Regards,
Torfinn Ingolfsen

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dvb lock patch
  2012-04-19 22:39           ` Torfinn Ingolfsen
@ 2012-04-21 12:18             ` Josu Lazkano
  2012-04-23 11:01               ` Torfinn Ingolfsen
  0 siblings, 1 reply; 10+ messages in thread
From: Josu Lazkano @ 2012-04-21 12:18 UTC (permalink / raw)
  To: Torfinn Ingolfsen; +Cc: linux-media

2012/4/20 Torfinn Ingolfsen <tingox@gmail.com>:
> 2012/4/18 Josu Lazkano <josu.lazkano@gmail.com>:
>> El día 18 de abril de 2012 21:19, Mauro Carvalho Chehab
>> <mchehab@redhat.com> escribió:
>>> Em 18-04-2012 15:58, Ezequiel García escreveu:
>>>> Josu,
>>>>
>>>> On Tue, Apr 17, 2012 at 10:30 AM, Josu Lazkano <josu.lazkano@gmail.com> wrote:
>>>>> 2012/3/24 Mauro Carvalho Chehab <mchehab@redhat.com>:
>>>> [snip]
>>>>>>
>>>>>> That doesn't sound right to me, and can actually cause race issues.
>>>>>>
>>>>>> Regards,
>>>>>> Mauro.
>>>>>
>>>>> Thanks for the patch Mauro.
>>>>>
>>>>
>>>> I think Mauro is *not* giving you a patch, rather the opposite:
>>>> pointing out that the patch can
>>>> cause problems!
>>>
>>> Yes. The driver will be unreliable with a patch like that, due to
>>> race conditions.
>>>
>>>> Regards,
>>>> Ezequiel.
>>>
>>> Regards,
>>> Mauro.
>>
>> Thanks anyway.
>>
>> I am looking for a solution to use virtual adapters on MythTV to use
>> my satellite provider card on two machines.
>> With 2.6.32 kernel is working great, but there is no way to work with
>> 3.x kernel.
>>
>> Is anyone using sasc-ng with latest kernel?
>>
>
> Would kernel 3.0.0.15 do?
> If so, descriptions on how I did it here:
> http://sites.google.com/site/tingox/digitaltv_sascng
> http://sites.google.com/site/tingox/asrock_e350m1_xubuntu
>
> Note: these are my work notes, not a how-to!
>
> As you can see, I'm using this patch:
> http://kipdola.be/subdomain/linux-2.6.38-dvb-mutex.patch
>
> It seems to work for me (had it running with Kaffeine on encrypted
> channesl for two weeks in a row)
>
> HTH
> --
> Regards,
> Torfinn Ingolfsen
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks Torfinn!

I get it working with modules compilation, that great!

apt-get install linux-source-3.2
cd /usr/src/
tar -xjvf linux-source-3.2.tar.bz2
cd linux-source-3.2/
wget http://kipdola.be/subdomain/linux-2.6.38-dvb-mutex.patch
patch -p1 linux-2.6.38-dvb-mutex.patch (I must do it manually, maybe
for the kernel version)
cp /boot/config-3.2.0-2-686-pae .config
cp ../linux-headers-3.2.0-2-686-pae/Module.symvers .
make oldconfig
make prepare
make scripts
make modules SUBDIRS=drivers/media/dvb/
cp drivers/media/dvb/dvb-core/dvb-core.ko
/lib/modules/3.2.0-2-686-pae/kernel/drivers/media/dvb/dvb-core/
(reboot)

I am not software developer and I have no idea what means "race
conditions", is this sasc-ng or linux driver "problem"?

It will be great to fix it and not patch the driver anymore, but I am
happy with this solution (module compilation).

Thanks and best regards.

-- 
Josu Lazkano

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dvb lock patch
  2012-04-21 12:18             ` Josu Lazkano
@ 2012-04-23 11:01               ` Torfinn Ingolfsen
  0 siblings, 0 replies; 10+ messages in thread
From: Torfinn Ingolfsen @ 2012-04-23 11:01 UTC (permalink / raw)
  To: linux-media

On Sat, Apr 21, 2012 at 2:18 PM, Josu Lazkano <josu.lazkano@gmail.com> wrote:
>
> Thanks Torfinn!
>
> I get it working with modules compilation, that great!

Good to hear that you got it working.

>
> apt-get install linux-source-3.2
> cd /usr/src/
> tar -xjvf linux-source-3.2.tar.bz2
> cd linux-source-3.2/
> wget http://kipdola.be/subdomain/linux-2.6.38-dvb-mutex.patch
> patch -p1 linux-2.6.38-dvb-mutex.patch (I must do it manually, maybe
> for the kernel version)
> cp /boot/config-3.2.0-2-686-pae .config
> cp ../linux-headers-3.2.0-2-686-pae/Module.symvers .
> make oldconfig
> make prepare
> make scripts
> make modules SUBDIRS=drivers/media/dvb/
> cp drivers/media/dvb/dvb-core/dvb-core.ko
> /lib/modules/3.2.0-2-686-pae/kernel/drivers/media/dvb/dvb-core/
> (reboot)
>
> I am not software developer and I have no idea what means "race
> conditions", is this sasc-ng or linux driver "problem"?

Sorry, I'm also not a developer, so I can't tell. :)
As long as the driver works, I'm happy.
-- 
Regards,
Torfinn Ingolfsen

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2012-04-23 11:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-04 20:49 dvb lock patch Josu Lazkano
     [not found] ` <4f6ca10f.e503b40a.4448.ffffc0feSMTPIN_ADDED@mx.google.com>
2012-03-23 16:15   ` Josu Lazkano
2012-03-24 14:32 ` Mauro Carvalho Chehab
2012-04-17 13:30   ` Josu Lazkano
2012-04-18 18:58     ` Ezequiel García
2012-04-18 19:19       ` Mauro Carvalho Chehab
2012-04-18 20:13         ` Josu Lazkano
2012-04-19 22:39           ` Torfinn Ingolfsen
2012-04-21 12:18             ` Josu Lazkano
2012-04-23 11:01               ` Torfinn Ingolfsen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.