From: dillon min <dillon.minfei@gmail.com> To: Alexandre TORGUE <alexandre.torgue@foss.st.com>, rong.a.chen@intel.com Cc: Rob Herring <robh+dt@kernel.org>, Ahmad Fatoum <a.fatoum@pengutronix.de>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-stm32@st-md-mailman.stormreply.com, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux@armlinux.org.uk, Vladimir Murzin <vladimir.murzin@arm.com>, afzal.mohd.ma@gmail.com, gregkh@linuxfoundation.org, erwan.leray@st.com, erwan.leray@foss.st.com, linux-serial@vger.kernel.org, lkp@intel.com Subject: Re: [PATCH v3 9/9] dt-bindings: serial: stm32: add phandle 'bluetooth' to fix dtbs_check warrning Date: Fri, 19 Mar 2021 19:13:27 +0800 [thread overview] Message-ID: <CAL9mu0LaWyhb0=CdJgrfq8v08P2cgKSx8g=u3MJU=dRQc8bThw@mail.gmail.com> (raw) In-Reply-To: <01c9f635-7b2b-fc9c-3cf9-6d7f425d683e@foss.st.com> Hi Alexandre, Thanks for the reply. On Fri, Mar 19, 2021 at 4:38 PM Alexandre TORGUE <alexandre.torgue@foss.st.com> wrote: > > Hi Dillon > > On 3/19/21 5:28 AM, dillon min wrote: > > No changes, Just loop lkp in. > > > > > > Hi lkp, > > > > Sorry for the late reply, thanks for your report. > > This patch is to fix the build warning message. > > > > Thanks. > > Regards > > > > On Mon, Mar 15, 2021 at 5:45 PM <dillon.minfei@gmail.com> wrote: > >> > >> From: dillon min <dillon.minfei@gmail.com> > >> > >> when run make dtbs_check with 'bluetoothi brcm,bcm43438-bt' > >> dts enabled on stm32h7, there is a warrning popup: > >> > >>>> arch/arm/boot/dts/stm32h750i-art-pi.dt.yaml: serial@40004800: 'bluetooth' > >> does not match any of the regexes: 'pinctrl-[0-9]+' > >> > >> to make dtbs_check happy, so add a phandle bluetooth > >> > >> Fixes: 500cdb23d608 ("ARM: dts: stm32: Add STM32H743 MCU and STM32H743i-EVAL board") > >> Signed-off-by: dillon min <dillon.minfei@gmail.com> > >> Reported-by: kernel test robot <lkp@intel.com> > >> --- > >> Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > >> index 8631678283f9..5e674840e62d 100644 > >> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > >> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > >> @@ -50,6 +50,11 @@ properties: > >> minItems: 1 > >> maxItems: 2 > >> > >> + bluetooth: > >> + type: object > >> + description: | > >> + phandles to the usart controller and bluetooth > >> + > > Do we really need to add this "generic" property here ? You could test > without the "AditionalProperties:False". Yes, indeed. we have no reason to add a generic 'bluetooth' property into specific soc's interface yaml. I can't just remove "AditionalProperties:False", else make O=../kernel-art/ dtbs dtbs_check will run into /home/fmin/linux/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property ... So , i will replace "AditionalProperties:False". with unevaluatedProperties: false, do you agree with this? If so, i will send patch v4 later. Thanks. Regards > > Regards > Alex > > > >> # cts-gpios and rts-gpios properties can be used instead of 'uart-has-rtscts' > >> # or 'st,hw-flow-ctrl' (deprecated) for making use of any gpio pins for flow > >> # control instead of dedicated pins. > >> -- > >> 1.9.1 > >>
WARNING: multiple messages have this Message-ID (diff)
From: dillon min <dillon.minfei@gmail.com> To: Alexandre TORGUE <alexandre.torgue@foss.st.com>, rong.a.chen@intel.com Cc: Rob Herring <robh+dt@kernel.org>, Ahmad Fatoum <a.fatoum@pengutronix.de>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-stm32@st-md-mailman.stormreply.com, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux@armlinux.org.uk, Vladimir Murzin <vladimir.murzin@arm.com>, afzal.mohd.ma@gmail.com, gregkh@linuxfoundation.org, erwan.leray@st.com, erwan.leray@foss.st.com, linux-serial@vger.kernel.org, lkp@intel.com Subject: Re: [PATCH v3 9/9] dt-bindings: serial: stm32: add phandle 'bluetooth' to fix dtbs_check warrning Date: Fri, 19 Mar 2021 19:13:27 +0800 [thread overview] Message-ID: <CAL9mu0LaWyhb0=CdJgrfq8v08P2cgKSx8g=u3MJU=dRQc8bThw@mail.gmail.com> (raw) In-Reply-To: <01c9f635-7b2b-fc9c-3cf9-6d7f425d683e@foss.st.com> Hi Alexandre, Thanks for the reply. On Fri, Mar 19, 2021 at 4:38 PM Alexandre TORGUE <alexandre.torgue@foss.st.com> wrote: > > Hi Dillon > > On 3/19/21 5:28 AM, dillon min wrote: > > No changes, Just loop lkp in. > > > > > > Hi lkp, > > > > Sorry for the late reply, thanks for your report. > > This patch is to fix the build warning message. > > > > Thanks. > > Regards > > > > On Mon, Mar 15, 2021 at 5:45 PM <dillon.minfei@gmail.com> wrote: > >> > >> From: dillon min <dillon.minfei@gmail.com> > >> > >> when run make dtbs_check with 'bluetoothi brcm,bcm43438-bt' > >> dts enabled on stm32h7, there is a warrning popup: > >> > >>>> arch/arm/boot/dts/stm32h750i-art-pi.dt.yaml: serial@40004800: 'bluetooth' > >> does not match any of the regexes: 'pinctrl-[0-9]+' > >> > >> to make dtbs_check happy, so add a phandle bluetooth > >> > >> Fixes: 500cdb23d608 ("ARM: dts: stm32: Add STM32H743 MCU and STM32H743i-EVAL board") > >> Signed-off-by: dillon min <dillon.minfei@gmail.com> > >> Reported-by: kernel test robot <lkp@intel.com> > >> --- > >> Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > >> index 8631678283f9..5e674840e62d 100644 > >> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > >> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml > >> @@ -50,6 +50,11 @@ properties: > >> minItems: 1 > >> maxItems: 2 > >> > >> + bluetooth: > >> + type: object > >> + description: | > >> + phandles to the usart controller and bluetooth > >> + > > Do we really need to add this "generic" property here ? You could test > without the "AditionalProperties:False". Yes, indeed. we have no reason to add a generic 'bluetooth' property into specific soc's interface yaml. I can't just remove "AditionalProperties:False", else make O=../kernel-art/ dtbs dtbs_check will run into /home/fmin/linux/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property ... So , i will replace "AditionalProperties:False". with unevaluatedProperties: false, do you agree with this? If so, i will send patch v4 later. Thanks. Regards > > Regards > Alex > > > >> # cts-gpios and rts-gpios properties can be used instead of 'uart-has-rtscts' > >> # or 'st,hw-flow-ctrl' (deprecated) for making use of any gpio pins for flow > >> # control instead of dedicated pins. > >> -- > >> 1.9.1 > >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-19 11:14 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-15 9:43 [PATCH v3 0/9] ARM: STM32: add art-pi(stm32h750xbh6) board support dillon.minfei 2021-03-15 9:43 ` dillon.minfei 2021-03-15 9:43 ` [PATCH v3 1/9] Documentation: arm: stm32: Add stm32h750 value line doc dillon.minfei 2021-03-15 9:43 ` dillon.minfei 2021-03-15 9:43 ` [PATCH v3 2/9] dt-bindings: arm: stm32: Add compatible strings for ART-PI board dillon.minfei 2021-03-15 9:43 ` dillon.minfei 2021-03-15 16:26 ` Rob Herring 2021-03-15 16:26 ` Rob Herring 2021-03-15 15:10 ` dillon min 2021-03-15 15:10 ` dillon min 2021-03-15 9:43 ` [PATCH v3 3/9] dt-bindings: pinctrl: stm32: Add stm32h750 pinctrl dillon.minfei 2021-03-15 9:43 ` dillon.minfei 2021-03-15 16:26 ` Rob Herring 2021-03-15 16:26 ` Rob Herring 2021-03-15 15:11 ` dillon min 2021-03-15 15:11 ` dillon min 2021-03-15 9:43 ` [PATCH v3 4/9] ARM: dts: stm32: introduce stm32h7-pinctrl.dtsi to support stm32h750 dillon.minfei 2021-03-15 9:43 ` dillon.minfei 2021-03-15 9:43 ` [PATCH v3 5/9] ARM: dts: stm32: add stm32h750-pinctrl.dtsi dillon.minfei 2021-03-15 9:43 ` dillon.minfei 2021-03-15 9:43 ` [PATCH v3 6/9] ARM: dts: stm32: add support for art-pi board based on stm32h750xbh6 dillon.minfei 2021-03-15 9:43 ` dillon.minfei 2021-03-19 4:27 ` dillon min 2021-03-19 4:27 ` dillon min 2021-03-15 9:43 ` [PATCH v3 7/9] ARM: stm32: Add a new SOC - STM32H750 dillon.minfei 2021-03-15 9:43 ` dillon.minfei 2021-03-15 9:43 ` [PATCH v3 8/9] pinctrl: stm32: Add STM32H750 MCU pinctrl support dillon.minfei 2021-03-15 9:43 ` dillon.minfei 2021-03-15 9:43 ` [PATCH v3 9/9] dt-bindings: serial: stm32: add phandle 'bluetooth' to fix dtbs_check warrning dillon.minfei 2021-03-15 9:43 ` dillon.minfei 2021-03-19 4:28 ` dillon min 2021-03-19 4:28 ` dillon min 2021-03-19 8:38 ` Alexandre TORGUE 2021-03-19 8:38 ` Alexandre TORGUE 2021-03-19 11:13 ` dillon min [this message] 2021-03-19 11:13 ` dillon min 2021-03-24 17:45 ` Rob Herring 2021-03-24 17:45 ` Rob Herring 2021-03-25 5:40 ` dillon min 2021-03-25 5:40 ` dillon min
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL9mu0LaWyhb0=CdJgrfq8v08P2cgKSx8g=u3MJU=dRQc8bThw@mail.gmail.com' \ --to=dillon.minfei@gmail.com \ --cc=a.fatoum@pengutronix.de \ --cc=afzal.mohd.ma@gmail.com \ --cc=alexandre.torgue@foss.st.com \ --cc=alexandre.torgue@st.com \ --cc=devicetree@vger.kernel.org \ --cc=erwan.leray@foss.st.com \ --cc=erwan.leray@st.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=linux@armlinux.org.uk \ --cc=lkp@intel.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=robh+dt@kernel.org \ --cc=rong.a.chen@intel.com \ --cc=vladimir.murzin@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.