* [PATCH] wcn36xx: Set SMD timeout to 10 seconds
@ 2016-04-21 21:09 Bjorn Andersson
2016-04-21 21:11 ` John Stultz
2016-04-27 12:55 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Andersson @ 2016-04-21 21:09 UTC (permalink / raw)
To: Eugene Krasnikov, Kalle Valo
Cc: linux-wireless, netdev, linux-kernel, John Stultz
After booting the wireless subsystem and uploading the NV blob to the
WCNSS_CTRL service the remote continues to do things and will not start
servicing wlan-requests for another 2-5 seconds (measured).
The downstream code does not have any special handling for this case,
but has a timeout of 10 seconds for the communication layer. By
extending the wcn36xx timeout to match this we follows the same flow for
the boot procedure and can successfully configure WiFi as wlan0 is
registered.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/net/wireless/ath/wcn36xx/smd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.h b/drivers/net/wireless/ath/wcn36xx/smd.h
index e6aadd273c46..6310560901f0 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.h
+++ b/drivers/net/wireless/ath/wcn36xx/smd.h
@@ -24,7 +24,7 @@
#define WCN36XX_HAL_BUF_SIZE 4096
-#define HAL_MSG_TIMEOUT 500
+#define HAL_MSG_TIMEOUT 10000
#define WCN36XX_SMSM_WLAN_TX_ENABLE 0x00000400
#define WCN36XX_SMSM_WLAN_TX_RINGS_EMPTY 0x00000200
/* The PNO version info be contained in the rsp msg */
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wcn36xx: Set SMD timeout to 10 seconds
2016-04-21 21:09 [PATCH] wcn36xx: Set SMD timeout to 10 seconds Bjorn Andersson
@ 2016-04-21 21:11 ` John Stultz
2016-04-27 12:55 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: John Stultz @ 2016-04-21 21:11 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Eugene Krasnikov, Kalle Valo, linux-wireless, netdev, lkml
On Thu, Apr 21, 2016 at 2:09 PM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> After booting the wireless subsystem and uploading the NV blob to the
> WCNSS_CTRL service the remote continues to do things and will not start
> servicing wlan-requests for another 2-5 seconds (measured).
>
> The downstream code does not have any special handling for this case,
> but has a timeout of 10 seconds for the communication layer. By
> extending the wcn36xx timeout to match this we follows the same flow for
> the boot procedure and can successfully configure WiFi as wlan0 is
> registered.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
I've been using this with my nexus7 tree, and its avoided issues I was
seeing without it.
Tested-by: John Stultz <john.stultz@linaro.org>
thanks
-john
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wcn36xx: Set SMD timeout to 10 seconds
2016-04-21 21:09 [PATCH] wcn36xx: Set SMD timeout to 10 seconds Bjorn Andersson
2016-04-21 21:11 ` John Stultz
@ 2016-04-27 12:55 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-04-27 12:55 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Eugene Krasnikov, linux-wireless, netdev, linux-kernel, John Stultz
Bjorn Andersson <bjorn.andersson@linaro.org> writes:
> After booting the wireless subsystem and uploading the NV blob to the
> WCNSS_CTRL service the remote continues to do things and will not start
> servicing wlan-requests for another 2-5 seconds (measured).
>
> The downstream code does not have any special handling for this case,
> but has a timeout of 10 seconds for the communication layer. By
> extending the wcn36xx timeout to match this we follows the same flow for
> the boot procedure and can successfully configure WiFi as wlan0 is
> registered.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Applied, thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-27 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-21 21:09 [PATCH] wcn36xx: Set SMD timeout to 10 seconds Bjorn Andersson
2016-04-21 21:11 ` John Stultz
2016-04-27 12:55 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.