Re: [PATCH] libdrm: Convert to Android.mk to Android.bp

From: John Stultz <john.stultz@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Rob Clark <robdclark@chromium.org>,
	Jiyong Park <jiyong@google.com>,
	Robert Foss <robert.foss@collabora.com>,
	Mauro Rossi <issor.oruam@gmail.com>,
	Alistair Strachan <astrachan@google.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Eric Anholt <anholt@google.com>,
	Sean Paul <seanpaul@chromium.org>,
	Dan Willemsen <dwillemsen@google.com>,
	Emil Velikov <emil.velikov@collabora.com>,
	Vishal Bhoj <vishal.bhoj@linaro.org>
Subject: Re: [PATCH] libdrm: Convert to Android.mk to Android.bp
Date: Tue, 24 Sep 2019 16:30:18 -0700	[thread overview]
Message-ID: <CALAqxLUR5ML3gmBs3SM2GvfXB+JxiO7gTUrtpVJqVzuh+hugxg@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqLR212Et5Z82Gr=DJfB5WY-4o8bN_s5peu07EnaEVEOYQ@mail.gmail.com>

On Tue, Sep 24, 2019 at 3:24 PM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Sep 24, 2019 at 4:29 PM John Stultz <john.stultz@linaro.org> wrote:
> >
> > This patch removes the deprecated Android.mk files and replaces
> > them with Android.bp files, used in Android N and newer
> > releases.
> >
> > This is needed in order to build libdrm/master against recent
> > Android releases and AOSP/master, as some of the Treble build
> > options required since Android O cannot be expressed in
> > Andorid.mk files.
> >
> > Patch originally by Dan Willemsen with fixes folded in by:
> >  Jerry Zhang, Eliott Hughes and myself.
> >
> > While this does cost comptability with older pre Android N
> > releases, I'd contend that being able to build/test
> > libdrm/master against AOSP/master and recent releases is more
> > valuable then soley maintaining support for old and unsupported
> > Android releases.
>
> Trying to maintain something that works across more than 3 releases or
> so is painful. I don't think android-x86 folks have the bandwidth to
> maintain things older than that *and* update to newer versions. So I
> think only supporting the n latest releases is good.
>
> Are .bp files for master/Q compatible back to N (or O)? IIRC, at least
> for the first couple of releases with .bp files, they seemed to have
> incompatible changes.

I think there have possibly been some incompatible changes, as I know
early w/ bp files things were more in flux. That said, there haven't
been many changes to the libdrm bp files since the conversion was
first done in 2017 (so Android O). I'll checkout N and validate so I
can provide a more concrete assurance.

thanks
-john
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel