Re: [PATCH] libdrm: Convert to Android.mk to Android.bp

From: John Stultz <john.stultz@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Rob Clark <robdclark@chromium.org>,
	Jiyong Park <jiyong@google.com>,
	Robert Foss <robert.foss@collabora.com>,
	Mauro Rossi <issor.oruam@gmail.com>,
	Alistair Strachan <astrachan@google.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Eric Anholt <anholt@google.com>,
	Sean Paul <seanpaul@chromium.org>,
	Dan Willemsen <dwillemsen@google.com>,
	Emil Velikov <emil.velikov@collabora.com>,
	Vishal Bhoj <vishal.bhoj@linaro.org>
Subject: Re: [PATCH] libdrm: Convert to Android.mk to Android.bp
Date: Tue, 24 Sep 2019 23:09:08 -0700	[thread overview]
Message-ID: <CALAqxLWHrCKogRqe2ZQZT3dK57+8AmxKfZjKXxztvw6CFobdkg@mail.gmail.com> (raw)
In-Reply-To: <CALAqxLUR5ML3gmBs3SM2GvfXB+JxiO7gTUrtpVJqVzuh+hugxg@mail.gmail.com>

On Tue, Sep 24, 2019 at 4:30 PM John Stultz <john.stultz@linaro.org> wrote:
> On Tue, Sep 24, 2019 at 3:24 PM Rob Herring <robh@kernel.org> wrote:
> > Trying to maintain something that works across more than 3 releases or
> > so is painful. I don't think android-x86 folks have the bandwidth to
> > maintain things older than that *and* update to newer versions. So I
> > think only supporting the n latest releases is good.
> >
> > Are .bp files for master/Q compatible back to N (or O)? IIRC, at least
> > for the first couple of releases with .bp files, they seemed to have
> > incompatible changes.
>
> I think there have possibly been some incompatible changes, as I know
> early w/ bp files things were more in flux. That said, there haven't
> been many changes to the libdrm bp files since the conversion was
> first done in 2017 (so Android O). I'll checkout N and validate so I
> can provide a more concrete assurance.

Ah. Crud. You're right. The bp syntax has shifted enough over time to
cause problems w/ the current file when building against older Android
releases.   N falls over pretty hard, and O and even P have issues w/
"recovery_available: ", and "prebuilt_etc" syntax.  So my proposed
commit message mischaracterizes the state of older builds. Apologies!

I'll try to reach out to the android devs to see if there's any sort
of compat magic that can be done to keep things working on older
versions. That said, I'm still torn, as without this the current
libdrm/master code is broken with AOSP/master and Q.  Its frustrating
we have to have this seemingly exclusive trade off.

I'm curious if folks might be willing to consider something like an
upstream branch to preserve the build bits that work with prior
Android releases? Or any other ideas?

thanks
-john
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel