All of lore.kernel.org
 help / color / mirror / Atom feed
* imx8qxp-lpcg-clk: probe of 5a4a0000.clock-controller failed with error -110
@ 2020-04-21 14:23 Oliver Graute
  2020-04-23 14:16 ` Aisheng Dong
  0 siblings, 1 reply; 4+ messages in thread
From: Oliver Graute @ 2020-04-21 14:23 UTC (permalink / raw)
  To: Dong Aisheng, Stephen Boyd, Michael Turquette
  Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Peng Fan, Leonard Crestez, Daniel Baluta,
	linux-clk, oliver.graute

Hello,

I run into below clock probing issue, after upgrading from next-20200214 to
next-20200420. I use the following patches series ontop:

https://patchwork.kernel.org/patch/11143351/

Some ideas what's the reason for this behavior? or how to fix this?

Best Regards,

Oliver


Linux dmsse20 5.7.0-rc2-next-20200420-00062-gdeb4ab568a65 #29 SMP PREEMPT Tue Apr 21 13:30:56 UTC 2020 aarch64 GNU/Linux

------------[ cut here ]------------
[   31.817971] imx8qxp-lpcg-clk 5a4a0000.clock-controller: deferred probe timeout, ignoring dependency
[   31.818035] WARNING: CPU: 0 PID: 122 at drivers/base/dd.c:270 driver_deferred_probe_check_state+0x44/0x68
[   31.836647] Modules linked in:
[   31.839709] CPU: 0 PID: 122 Comm: kworker/0:1 Not tainted 5.7.0-rc2-next-20200420-00062-gdeb4ab568a65 #29
[   31.849276] Hardware name: Advantech iMX8QM DMSSE20 (DT)
[   31.854593] Workqueue: events deferred_probe_work_func
[   31.859738] pstate: 60000005 (nZCv daif -PAN -UAO)
[   31.864532] pc : driver_deferred_probe_check_state+0x44/0x68
[   31.870198] lr : driver_deferred_probe_check_state+0x44/0x68
[   31.875859] sp : ffff8000120ebac0
[   31.879168] x29: ffff8000120ebac0 x28: ffff800011957000 
[   31.884485] x27: 0000000000000000 x26: ffff80001006bce8 
[   31.889792] x25: 0000000000000001 x24: ffff800011ae8d58 
[   31.895109] x23: ffff000975ff7010 x22: fffffffffffffffe 
[   31.900426] x21: ffff000975ec4600 x20: ffff000975ff7010 
[   31.905742] x19: ffff000975ff7010 x18: 0000000000000010 
[   31.911050] x17: 0000000000000000 x16: 0000000000000000 
[   31.916367] x15: ffff000975ec4a70 x14: 6f656d6974206562 
[   31.921684] x13: 6f72702064657272 x12: 65666564203a7265 
[   31.927001] x11: 6c6c6f72746e6f63 x10: 2d6b636f6c632e30 
[   31.932318] x9 : 3030306134613520 x8 : 0000000000000000 
[   31.937634] x7 : 6f6e6769202c7475 x6 : ffff800011b5584f 
[   31.942951] x5 : 0000000000000000 x4 : 0000000000000000 
[   31.948268] x3 : 00000000ffffffff x2 : ffff80096d9d0000 
[   31.953584] x1 : cda1879e3af41400 x0 : 0000000000000000 
[   31.958904] Call trace:
[   31.961351]  driver_deferred_probe_check_state+0x44/0x68
[   31.966667]  __genpd_dev_pm_attach+0x1a4/0x1b0
[   31.971109]  genpd_dev_pm_attach+0x60/0x70
[   31.975214]  dev_pm_domain_attach+0x50/0x58
[   31.979401]  platform_drv_probe+0x3c/0xa8
[   31.983411]  really_probe+0xd8/0x320
[   31.986990]  driver_probe_device+0x58/0xf0
[   31.991093]  __device_attach_driver+0x84/0xc8
[   31.995454]  bus_for_each_drv+0x78/0xc8
[   31.999292]  __device_attach+0xe4/0x140
[   32.003131]  device_initial_probe+0x14/0x20
[   32.007310]  bus_probe_device+0x9c/0xa8
[   32.011141]  deferred_probe_work_func+0x74/0xb0
[   32.015683]  process_one_work+0x1a0/0x328
[   32.019692]  worker_thread+0x1f8/0x428
[   32.023447]  kthread+0x138/0x158
[   32.026680]  ret_from_fork+0x10/0x1c
[   32.030256] ---[ end trace 33d4174015850150 ]---
[   32.034947] imx8qxp-lpcg-clk: probe of 5a4a0000.clock-controller failed with error -110
[   32.046365] platform lvds_backlight@1: deferred probe pending
[   32.052154] platform 5b130000.cdns3: deferred probe pending


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: imx8qxp-lpcg-clk: probe of 5a4a0000.clock-controller failed with error -110
  2020-04-21 14:23 imx8qxp-lpcg-clk: probe of 5a4a0000.clock-controller failed with error -110 Oliver Graute
@ 2020-04-23 14:16 ` Aisheng Dong
  2020-04-23 19:47   ` Oliver Graute
  0 siblings, 1 reply; 4+ messages in thread
From: Aisheng Dong @ 2020-04-23 14:16 UTC (permalink / raw)
  To: Oliver Graute, Stephen Boyd, Michael Turquette
  Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	dl-linux-imx, Peng Fan, Leonard Crestez, Daniel Baluta,
	linux-clk, Oliver Graute

> From: Oliver Graute <oliver.graute@gmail.com>
> Sent: Tuesday, April 21, 2020 10:24 PM
> 
> Hello,
> 
> I run into below clock probing issue, after upgrading from next-20200214 to
> next-20200420. I use the following patches series ontop:
> > 
> Some ideas what's the reason for this behavior? or how to fix this?
> 

I will check it tomorrow.
Before that, I need rebase my patch series to last kernel to reproduce this issue.

Regards
Aisheng

> Best Regards,
> 
> Oliver
> 
> 
> Linux dmsse20 5.7.0-rc2-next-20200420-00062-gdeb4ab568a65 #29 SMP
> PREEMPT Tue Apr 21 13:30:56 UTC 2020 aarch64 GNU/Linux
> 
> ------------[ cut here ]------------
> [   31.817971] imx8qxp-lpcg-clk 5a4a0000.clock-controller: deferred probe
> timeout, ignoring dependency
> [   31.818035] WARNING: CPU: 0 PID: 122 at drivers/base/dd.c:270
> driver_deferred_probe_check_state+0x44/0x68
> [   31.836647] Modules linked in:
> [   31.839709] CPU: 0 PID: 122 Comm: kworker/0:1 Not tainted
> 5.7.0-rc2-next-20200420-00062-gdeb4ab568a65 #29
> [   31.849276] Hardware name: Advantech iMX8QM DMSSE20 (DT)
> [   31.854593] Workqueue: events deferred_probe_work_func
> [   31.859738] pstate: 60000005 (nZCv daif -PAN -UAO)
> [   31.864532] pc : driver_deferred_probe_check_state+0x44/0x68
> [   31.870198] lr : driver_deferred_probe_check_state+0x44/0x68
> [   31.875859] sp : ffff8000120ebac0
> [   31.879168] x29: ffff8000120ebac0 x28: ffff800011957000
> [   31.884485] x27: 0000000000000000 x26: ffff80001006bce8
> [   31.889792] x25: 0000000000000001 x24: ffff800011ae8d58
> [   31.895109] x23: ffff000975ff7010 x22: fffffffffffffffe
> [   31.900426] x21: ffff000975ec4600 x20: ffff000975ff7010
> [   31.905742] x19: ffff000975ff7010 x18: 0000000000000010
> [   31.911050] x17: 0000000000000000 x16: 0000000000000000
> [   31.916367] x15: ffff000975ec4a70 x14: 6f656d6974206562
> [   31.921684] x13: 6f72702064657272 x12: 65666564203a7265
> [   31.927001] x11: 6c6c6f72746e6f63 x10: 2d6b636f6c632e30
> [   31.932318] x9 : 3030306134613520 x8 : 0000000000000000
> [   31.937634] x7 : 6f6e6769202c7475 x6 : ffff800011b5584f
> [   31.942951] x5 : 0000000000000000 x4 : 0000000000000000
> [   31.948268] x3 : 00000000ffffffff x2 : ffff80096d9d0000
> [   31.953584] x1 : cda1879e3af41400 x0 : 0000000000000000
> [   31.958904] Call trace:
> [   31.961351]  driver_deferred_probe_check_state+0x44/0x68
> [   31.966667]  __genpd_dev_pm_attach+0x1a4/0x1b0
> [   31.971109]  genpd_dev_pm_attach+0x60/0x70
> [   31.975214]  dev_pm_domain_attach+0x50/0x58
> [   31.979401]  platform_drv_probe+0x3c/0xa8
> [   31.983411]  really_probe+0xd8/0x320
> [   31.986990]  driver_probe_device+0x58/0xf0
> [   31.991093]  __device_attach_driver+0x84/0xc8
> [   31.995454]  bus_for_each_drv+0x78/0xc8
> [   31.999292]  __device_attach+0xe4/0x140
> [   32.003131]  device_initial_probe+0x14/0x20
> [   32.007310]  bus_probe_device+0x9c/0xa8
> [   32.011141]  deferred_probe_work_func+0x74/0xb0
> [   32.015683]  process_one_work+0x1a0/0x328
> [   32.019692]  worker_thread+0x1f8/0x428
> [   32.023447]  kthread+0x138/0x158
> [   32.026680]  ret_from_fork+0x10/0x1c
> [   32.030256] ---[ end trace 33d4174015850150 ]---
> [   32.034947] imx8qxp-lpcg-clk: probe of 5a4a0000.clock-controller failed
> with error -110
> [   32.046365] platform lvds_backlight@1: deferred probe pending
> [   32.052154] platform 5b130000.cdns3: deferred probe pending


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: imx8qxp-lpcg-clk: probe of 5a4a0000.clock-controller failed with error -110
  2020-04-23 14:16 ` Aisheng Dong
@ 2020-04-23 19:47   ` Oliver Graute
  2020-04-23 19:59     ` John Stultz
  0 siblings, 1 reply; 4+ messages in thread
From: Oliver Graute @ 2020-04-23 19:47 UTC (permalink / raw)
  To: Aisheng Dong
  Cc: Stephen Boyd, Michael Turquette, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx, Peng Fan,
	Leonard Crestez, Daniel Baluta, linux-clk, Oliver Graute,
	John Stultz

On 23/04/20, Aisheng Dong wrote:
> > From: Oliver Graute <oliver.graute@gmail.com>
> > Sent: Tuesday, April 21, 2020 10:24 PM
> > 
> > Hello,
> > 
> > I run into below clock probing issue, after upgrading from next-20200214 to
> > next-20200420. I use the following patches series ontop:
> > > 
> > Some ideas what's the reason for this behavior? or how to fix this?
> > 
> 
> I will check it tomorrow.
> Before that, I need rebase my patch series to last kernel to reproduce this issue.

ok fine, I have some bisect results for you I think this change is
causing the issue.

e2cec7d6853712295cef5377762165a489b2957f is the first bad commit
commit e2cec7d6853712295cef5377762165a489b2957f
Author: John Stultz <john.stultz@linaro.org>
Date:   Tue Feb 25 05:08:24 2020 +0000

    driver core: Set deferred_probe_timeout to a longer default if CONFIG_MODULES is set
    
    When using modules, its common for the modules not to be loaded
    until quite late by userland. With the current code,
    driver_deferred_probe_check_state() will stop returning
    EPROBE_DEFER after late_initcall, which can cause module
    dependency resolution to fail after that.
    
    So allow a longer window of 30 seconds (picked somewhat
    arbitrarily, but influenced by the similar regulator core
    timeout value) in the case where modules are enabled.

 drivers/base/dd.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Best regards,

Oliver

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: imx8qxp-lpcg-clk: probe of 5a4a0000.clock-controller failed with error -110
  2020-04-23 19:47   ` Oliver Graute
@ 2020-04-23 19:59     ` John Stultz
  0 siblings, 0 replies; 4+ messages in thread
From: John Stultz @ 2020-04-23 19:59 UTC (permalink / raw)
  To: Oliver Graute
  Cc: Aisheng Dong, Stephen Boyd, Michael Turquette, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	dl-linux-imx, Peng Fan, Leonard Crestez, Daniel Baluta,
	linux-clk, Oliver Graute

On Thu, Apr 23, 2020 at 12:47 PM Oliver Graute <oliver.graute@gmail.com> wrote:
>
> On 23/04/20, Aisheng Dong wrote:
> > > From: Oliver Graute <oliver.graute@gmail.com>
> > > Sent: Tuesday, April 21, 2020 10:24 PM
> > >
> > > Hello,
> > >
> > > I run into below clock probing issue, after upgrading from next-20200214 to
> > > next-20200420. I use the following patches series ontop:
> > > >
> > > Some ideas what's the reason for this behavior? or how to fix this?
> > >
> >
> > I will check it tomorrow.
> > Before that, I need rebase my patch series to last kernel to reproduce this issue.
>
> ok fine, I have some bisect results for you I think this change is
> causing the issue.
>
> e2cec7d6853712295cef5377762165a489b2957f is the first bad commit
> commit e2cec7d6853712295cef5377762165a489b2957f
> Author: John Stultz <john.stultz@linaro.org>
> Date:   Tue Feb 25 05:08:24 2020 +0000
>
>     driver core: Set deferred_probe_timeout to a longer default if CONFIG_MODULES is set
>
>     When using modules, its common for the modules not to be loaded
>     until quite late by userland. With the current code,
>     driver_deferred_probe_check_state() will stop returning
>     EPROBE_DEFER after late_initcall, which can cause module
>     dependency resolution to fail after that.
>
>     So allow a longer window of 30 seconds (picked somewhat
>     arbitrarily, but influenced by the similar regulator core
>     timeout value) in the case where modules are enabled.

Yea. Apologies for the trouble.

I've got some patches to set the 30 second window back to zero on the
list, but they haven't been picked up yet:
https://lore.kernel.org/lkml/20200422203245.83244-1-john.stultz@linaro.org/

thanks
-john

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-23 19:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21 14:23 imx8qxp-lpcg-clk: probe of 5a4a0000.clock-controller failed with error -110 Oliver Graute
2020-04-23 14:16 ` Aisheng Dong
2020-04-23 19:47   ` Oliver Graute
2020-04-23 19:59     ` John Stultz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.