Re: [RFC][PATCH 2/6] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation (fwd)

Re: [RFC][PATCH 2/6] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation (fwd)

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 2036 bytes --]

Some mutex_unlocks appear to be needed in the function cma_heap_vmap.

julia


---------- Forwarded message ----------
Date: Sat, 26 Sep 2020 18:11:36 +0800
From: kernel test robot <lkp@intel.com>
To: kbuild(a)lists.01.org
Cc: lkp(a)intel.com, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [RFC][PATCH 2/6] dma-buf: heaps: Move heap-helper logic into the
    cma_heap implementation

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200926042453.67517-3-john.stultz@linaro.org>
References: <20200926042453.67517-3-john.stultz@linaro.org>
TO: John Stultz <john.stultz@linaro.org>

Hi John,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linux/master]
[also build test WARNING on tegra-drm/drm/tegra/for-next linus/master next-20200925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/John-Stultz/dma-buf-Performance-improvements-for-system-heap/20200926-122541
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
config: x86_64-randconfig-c002-20200925 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/dma-buf/heaps/cma_heap.c:203:2-8: preceding lock on line 200
   drivers/dma-buf/heaps/cma_heap.c:208:2-8: preceding lock on line 200
--
>> drivers/dma-buf/heaps/cma_heap.c:119:5-8: Unneeded variable: "ret". Return "0" on line 131

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34164 bytes --]

Re: [RFC][PATCH 2/6] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation (fwd)

[John Stultz]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

On Sat, Sep 26, 2020 at 6:49 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
> Some mutex_unlocks appear to be needed in the function cma_heap_vmap.
>
>

Thanks so much again, fixed up in my tree!
-john