All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm_hwcomposer: Mark tests as vendor, fix build
@ 2018-05-02 23:55 Alistair Strachan
  2018-05-03  0:21 ` John Stultz
  0 siblings, 1 reply; 2+ messages in thread
From: Alistair Strachan @ 2018-05-02 23:55 UTC (permalink / raw)
  To: dri-devel; +Cc: Rob Herring, Sean Paul, Robert Foss, Alistair Strachan

After commit 94bb596, the tests for drm_hwcomposer no longer build,
because the build system detects that they are linking other vendor
modules (but installing themselves elsewhere).

This change also adds the libhardware include path explicitly, as the
implicit include of hardware/libhardware/include is going away.

Cc: John Stultz <john.stultz@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Sean Paul <seanpaul@google.com>
Cc: Robert Foss <robert.foss@collabora.com>
Signed-off-by: Alistair Strachan <astrachan@google.com>
---
 tests/Android.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/Android.mk b/tests/Android.mk
index 3b9e0a2..c6a0afa 100644
--- a/tests/Android.mk
+++ b/tests/Android.mk
@@ -7,6 +7,8 @@ LOCAL_SRC_FILES := \
 	worker_test.cpp
 
 LOCAL_MODULE := hwc-drm-tests
+LOCAL_VENDOR_MODULE := true
+LOCAL_HEADER_LIBRARIES := libhardware_headers
 LOCAL_STATIC_LIBRARIES := libdrmhwc_utils
 LOCAL_SHARED_LIBRARIES := hwcomposer.drm
 LOCAL_C_INCLUDES := external/drm_hwcomposer
-- 
2.17.0.441.gb46fe60e1d-goog

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm_hwcomposer: Mark tests as vendor, fix build
  2018-05-02 23:55 [PATCH] drm_hwcomposer: Mark tests as vendor, fix build Alistair Strachan
@ 2018-05-03  0:21 ` John Stultz
  0 siblings, 0 replies; 2+ messages in thread
From: John Stultz @ 2018-05-03  0:21 UTC (permalink / raw)
  To: Alistair Strachan; +Cc: Robert Foss, Rob Herring, dri-devel, Sean Paul

On Wed, May 2, 2018 at 4:55 PM, Alistair Strachan <astrachan@google.com> wrote:
> After commit 94bb596, the tests for drm_hwcomposer no longer build,
> because the build system detects that they are linking other vendor
> modules (but installing themselves elsewhere).
>
> This change also adds the libhardware include path explicitly, as the
> implicit include of hardware/libhardware/include is going away.
>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Rob Herring <rob.herring@linaro.org>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Sean Paul <seanpaul@google.com>
> Cc: Robert Foss <robert.foss@collabora.com>
> Signed-off-by: Alistair Strachan <astrachan@google.com>

Thanks for catching this!

Acked-by: John Stultz <john.stultz@linaro.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-03  0:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 23:55 [PATCH] drm_hwcomposer: Mark tests as vendor, fix build Alistair Strachan
2018-05-03  0:21 ` John Stultz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.