From: John Stultz <john.stultz@linaro.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
"Andy Lutomirski" <luto@kernel.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Daniel Colascione" <dancol@google.com>,
"Hugh Dickins" <hughd@google.com>, "Jann Horn" <jannh@google.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"Jeff Layton" <jlayton@kernel.org>,
"Linux API" <linux-api@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm <linux-mm@kvack.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Mike Kravetz" <mike.kravetz@oracle.com>,
"Minchan Kim" <minchan@kernel.org>,
"Shuah Khan" <shuah@kernel.org>
Subject: Re: [PATCH v4 1/2] mm/memfd: Add an F_SEAL_FUTURE_WRITE seal to memfd
Date: Tue, 15 Jan 2019 09:36:52 -0800 [thread overview]
Message-ID: <CALAqxLXFvktP+k8AWPEoT=-MM_vdu=1hzgzPYEzhSp8hXd-ADg@mail.gmail.com> (raw)
In-Reply-To: <20190112203816.85534-2-joel@joelfernandes.org>
On Sat, Jan 12, 2019 at 12:38 PM Joel Fernandes <joel@joelfernandes.org> wrote:
>
> From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
>
> Android uses ashmem for sharing memory regions. We are looking forward to
> migrating all usecases of ashmem to memfd so that we can possibly remove
> the ashmem driver in the future from staging while also benefiting from
> using memfd and contributing to it. Note staging drivers are also not ABI
> and generally can be removed at anytime.
>
> One of the main usecases Android has is the ability to create a region and
> mmap it as writeable, then add protection against making any "future"
> writes while keeping the existing already mmap'ed writeable-region active.
> This allows us to implement a usecase where receivers of the shared
> memory buffer can get a read-only view, while the sender continues to
> write to the buffer. See CursorWindow documentation in Android for more
> details:
> https://developer.android.com/reference/android/database/CursorWindow
>
> This usecase cannot be implemented with the existing F_SEAL_WRITE seal.
> To support the usecase, this patch adds a new F_SEAL_FUTURE_WRITE seal
> which prevents any future mmap and write syscalls from succeeding while
> keeping the existing mmap active.
>
> A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week
> where we don't need to modify core VFS structures to get the same
> behavior of the seal. This solves several side-effects pointed by Andy.
> self-tests are provided in later patch to verify the expected semantics.
>
> [1] https://lore.kernel.org/lkml/20181111173650.GA256781@google.com/
>
> [Thanks a lot to Andy for suggestions to improve code]
> Cc: Andy Lutomirski <luto@kernel.org>
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> ---
> fs/hugetlbfs/inode.c | 2 +-
> include/uapi/linux/fcntl.h | 1 +
> mm/memfd.c | 3 ++-
> mm/shmem.c | 25 ++++++++++++++++++++++---
> 4 files changed, 26 insertions(+), 5 deletions(-)
Acked-by: John Stultz <john.stultz@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: john.stultz at linaro.org (John Stultz)
Subject: [PATCH v4 1/2] mm/memfd: Add an F_SEAL_FUTURE_WRITE seal to memfd
Date: Tue, 15 Jan 2019 09:36:52 -0800 [thread overview]
Message-ID: <CALAqxLXFvktP+k8AWPEoT=-MM_vdu=1hzgzPYEzhSp8hXd-ADg@mail.gmail.com> (raw)
In-Reply-To: <20190112203816.85534-2-joel@joelfernandes.org>
On Sat, Jan 12, 2019 at 12:38 PM Joel Fernandes <joel at joelfernandes.org> wrote:
>
> From: "Joel Fernandes (Google)" <joel at joelfernandes.org>
>
> Android uses ashmem for sharing memory regions. We are looking forward to
> migrating all usecases of ashmem to memfd so that we can possibly remove
> the ashmem driver in the future from staging while also benefiting from
> using memfd and contributing to it. Note staging drivers are also not ABI
> and generally can be removed at anytime.
>
> One of the main usecases Android has is the ability to create a region and
> mmap it as writeable, then add protection against making any "future"
> writes while keeping the existing already mmap'ed writeable-region active.
> This allows us to implement a usecase where receivers of the shared
> memory buffer can get a read-only view, while the sender continues to
> write to the buffer. See CursorWindow documentation in Android for more
> details:
> https://developer.android.com/reference/android/database/CursorWindow
>
> This usecase cannot be implemented with the existing F_SEAL_WRITE seal.
> To support the usecase, this patch adds a new F_SEAL_FUTURE_WRITE seal
> which prevents any future mmap and write syscalls from succeeding while
> keeping the existing mmap active.
>
> A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week
> where we don't need to modify core VFS structures to get the same
> behavior of the seal. This solves several side-effects pointed by Andy.
> self-tests are provided in later patch to verify the expected semantics.
>
> [1] https://lore.kernel.org/lkml/20181111173650.GA256781 at google.com/
>
> [Thanks a lot to Andy for suggestions to improve code]
> Cc: Andy Lutomirski <luto at kernel.org>
> Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org>
> ---
> fs/hugetlbfs/inode.c | 2 +-
> include/uapi/linux/fcntl.h | 1 +
> mm/memfd.c | 3 ++-
> mm/shmem.c | 25 ++++++++++++++++++++++---
> 4 files changed, 26 insertions(+), 5 deletions(-)
Acked-by: John Stultz <john.stultz at linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: john.stultz@linaro.org (John Stultz)
Subject: [PATCH v4 1/2] mm/memfd: Add an F_SEAL_FUTURE_WRITE seal to memfd
Date: Tue, 15 Jan 2019 09:36:52 -0800 [thread overview]
Message-ID: <CALAqxLXFvktP+k8AWPEoT=-MM_vdu=1hzgzPYEzhSp8hXd-ADg@mail.gmail.com> (raw)
Message-ID: <20190115173652.MrBKQXnBhswRGBe7TypJhoKBa1lciEmkj18jh3zmook@z> (raw)
In-Reply-To: <20190112203816.85534-2-joel@joelfernandes.org>
On Sat, Jan 12, 2019@12:38 PM Joel Fernandes <joel@joelfernandes.org> wrote:
>
> From: "Joel Fernandes (Google)" <joel at joelfernandes.org>
>
> Android uses ashmem for sharing memory regions. We are looking forward to
> migrating all usecases of ashmem to memfd so that we can possibly remove
> the ashmem driver in the future from staging while also benefiting from
> using memfd and contributing to it. Note staging drivers are also not ABI
> and generally can be removed at anytime.
>
> One of the main usecases Android has is the ability to create a region and
> mmap it as writeable, then add protection against making any "future"
> writes while keeping the existing already mmap'ed writeable-region active.
> This allows us to implement a usecase where receivers of the shared
> memory buffer can get a read-only view, while the sender continues to
> write to the buffer. See CursorWindow documentation in Android for more
> details:
> https://developer.android.com/reference/android/database/CursorWindow
>
> This usecase cannot be implemented with the existing F_SEAL_WRITE seal.
> To support the usecase, this patch adds a new F_SEAL_FUTURE_WRITE seal
> which prevents any future mmap and write syscalls from succeeding while
> keeping the existing mmap active.
>
> A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week
> where we don't need to modify core VFS structures to get the same
> behavior of the seal. This solves several side-effects pointed by Andy.
> self-tests are provided in later patch to verify the expected semantics.
>
> [1] https://lore.kernel.org/lkml/20181111173650.GA256781 at google.com/
>
> [Thanks a lot to Andy for suggestions to improve code]
> Cc: Andy Lutomirski <luto at kernel.org>
> Signed-off-by: Joel Fernandes (Google) <joel at joelfernandes.org>
> ---
> fs/hugetlbfs/inode.c | 2 +-
> include/uapi/linux/fcntl.h | 1 +
> mm/memfd.c | 3 ++-
> mm/shmem.c | 25 ++++++++++++++++++++++---
> 4 files changed, 26 insertions(+), 5 deletions(-)
Acked-by: John Stultz <john.stultz at linaro.org>
next prev parent reply other threads:[~2019-01-15 17:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 20:38 [PATCH v4 0/2] Add a future write seal to memfd Joel Fernandes
2019-01-12 20:38 ` Joel Fernandes
2019-01-12 20:38 ` joel
2019-01-12 20:38 ` [PATCH v4 1/2] mm/memfd: Add an F_SEAL_FUTURE_WRITE " Joel Fernandes
2019-01-12 20:38 ` Joel Fernandes
2019-01-12 20:38 ` joel
2019-01-15 17:36 ` John Stultz [this message]
2019-01-15 17:36 ` John Stultz
2019-01-15 17:36 ` john.stultz
2019-01-12 20:38 ` [PATCH v4 2/2] selftests/memfd: Add tests for F_SEAL_FUTURE_WRITE seal Joel Fernandes
2019-01-12 20:38 ` Joel Fernandes
2019-01-12 20:38 ` joel
2019-01-15 1:39 ` shuah
2019-01-15 1:39 ` shuah
2019-01-15 1:39 ` shuah
2019-01-15 14:50 ` Joel Fernandes
2019-01-15 14:50 ` Joel Fernandes
2019-01-15 14:50 ` joel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALAqxLXFvktP+k8AWPEoT=-MM_vdu=1hzgzPYEzhSp8hXd-ADg@mail.gmail.com' \
--to=john.stultz@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=dancol@google.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=jlayton@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=mike.kravetz@oracle.com \
--cc=minchan@kernel.org \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.