[PATCH v1] common/cnxk: fix initialization of timer LF count

[PATCH v1] common/cnxk: fix initialization of timer LF count

[Shijith Thotton]

Assignment of nb_lfs variable with the available number of timer LFs was
not happening in the success case after the addition of the new label
"done". This patch fixes the same by moving the assignment under the
label.

Fixes: 44a9307c0908 ("common/cnxk: support mailbox locking")

Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
 drivers/common/cnxk/roc_tim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/common/cnxk/roc_tim.c b/drivers/common/cnxk/roc_tim.c
index 6f256c60fa..f8607b2852 100644
--- a/drivers/common/cnxk/roc_tim.c
+++ b/drivers/common/cnxk/roc_tim.c
@@ -394,11 +394,11 @@ roc_tim_init(struct roc_tim *roc_tim)
 	} else {
 		goto done;
 	}
-	roc_tim->nb_lfs = nb_lfs;
 
 fail:
 	mbox_put(dev->mbox);
 done:
+	roc_tim->nb_lfs = nb_lfs;
 	return nb_lfs;
 }
 
-- 
2.25.1

RE: [PATCH v1] common/cnxk: fix initialization of timer LF count

[Pavan Nikhilesh Bhagavatula]

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]



> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Tuesday, March 14, 2023 9:17 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Pavan
> Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Subject: [PATCH v1] common/cnxk: fix initialization of timer LF count
> 
> Assignment of nb_lfs variable with the available number of timer LFs was
> not happening in the success case after the addition of the new label
> "done". This patch fixes the same by moving the assignment under the
> label.
> 
> Fixes: 44a9307c0908 ("common/cnxk: support mailbox locking")
> 
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>

Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

> ---
>  drivers/common/cnxk/roc_tim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/common/cnxk/roc_tim.c
> b/drivers/common/cnxk/roc_tim.c
> index 6f256c60fa..f8607b2852 100644
> --- a/drivers/common/cnxk/roc_tim.c
> +++ b/drivers/common/cnxk/roc_tim.c
> @@ -394,11 +394,11 @@ roc_tim_init(struct roc_tim *roc_tim)
>  	} else {
>  		goto done;
>  	}
> -	roc_tim->nb_lfs = nb_lfs;
> 
>  fail:
>  	mbox_put(dev->mbox);
>  done:
> +	roc_tim->nb_lfs = nb_lfs;
>  	return nb_lfs;
>  }
> 
> --
> 2.25.1


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 23601 bytes --]

Re: [PATCH v1] common/cnxk: fix initialization of timer LF count

[Jerin Jacob]

On Tue, Mar 14, 2023 at 11:29 AM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Shijith Thotton <sthotton@marvell.com>
> > Sent: Tuesday, March 14, 2023 9:17 AM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Pavan
> > Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> > Subject: [PATCH v1] common/cnxk: fix initialization of timer LF count
> >
> > Assignment of nb_lfs variable with the available number of timer LFs was
> > not happening in the success case after the addition of the new label
> > "done". This patch fixes the same by moving the assignment under the
> > label.
> >
> > Fixes: 44a9307c0908 ("common/cnxk: support mailbox locking")
> >
> > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Applied to dpdk-next-net-mrvl/for-next-net. Thanks


>
> > ---
> >  drivers/common/cnxk/roc_tim.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/common/cnxk/roc_tim.c
> > b/drivers/common/cnxk/roc_tim.c
> > index 6f256c60fa..f8607b2852 100644
> > --- a/drivers/common/cnxk/roc_tim.c
> > +++ b/drivers/common/cnxk/roc_tim.c
> > @@ -394,11 +394,11 @@ roc_tim_init(struct roc_tim *roc_tim)
> >       } else {
> >               goto done;
> >       }
> > -     roc_tim->nb_lfs = nb_lfs;
> >
> >  fail:
> >       mbox_put(dev->mbox);
> >  done:
> > +     roc_tim->nb_lfs = nb_lfs;
> >       return nb_lfs;
> >  }
> >
> > --
> > 2.25.1
>