* [dpdk-dev] [PATCH] common/cnxk: move ICMP ltype to end of enum
@ 2022-12-01 4:03 psatheesh
2023-01-09 15:27 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: psatheesh @ 2022-12-01 4:03 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Jerin Jacob
From: Kiran Kumar K <kirankumark@marvell.com>
While configuring the RSS key, mask has been created to match multiple
ltypes for L4. Since ICMP is placed in between, it is also being
considered for RSS. So, moving the ICMP to end of enum.
Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
---
drivers/common/cnxk/hw/npc.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/common/cnxk/hw/npc.h b/drivers/common/cnxk/hw/npc.h
index b8218e25af..4164c6ac2e 100644
--- a/drivers/common/cnxk/hw/npc.h
+++ b/drivers/common/cnxk/hw/npc.h
@@ -219,8 +219,7 @@ enum npc_kpu_lc_ltype {
enum npc_kpu_ld_ltype {
NPC_LT_LD_TCP = 1,
NPC_LT_LD_UDP,
- NPC_LT_LD_ICMP,
- NPC_LT_LD_SCTP,
+ NPC_LT_LD_SCTP = 4,
NPC_LT_LD_ICMP6,
NPC_LT_LD_CUSTOM0,
NPC_LT_LD_CUSTOM1,
@@ -231,6 +230,7 @@ enum npc_kpu_ld_ltype {
NPC_LT_LD_NSH,
NPC_LT_LD_TU_MPLS_IN_NSH,
NPC_LT_LD_TU_MPLS_IN_IP,
+ NPC_LT_LD_ICMP,
};
enum npc_kpu_le_ltype {
@@ -276,14 +276,14 @@ enum npc_kpu_lg_ltype {
enum npc_kpu_lh_ltype {
NPC_LT_LH_TU_TCP = 1,
NPC_LT_LH_TU_UDP,
- NPC_LT_LH_TU_ICMP,
- NPC_LT_LH_TU_SCTP,
+ NPC_LT_LH_TU_SCTP = 4,
NPC_LT_LH_TU_ICMP6,
+ NPC_LT_LH_CUSTOM0,
+ NPC_LT_LH_CUSTOM1,
NPC_LT_LH_TU_IGMP = 8,
NPC_LT_LH_TU_ESP,
NPC_LT_LH_TU_AH,
- NPC_LT_LH_CUSTOM0 = 0xE,
- NPC_LT_LH_CUSTOM1 = 0xF,
+ NPC_LT_LH_TU_ICMP = 0xF,
};
enum npc_kpu_lb_uflag {
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] common/cnxk: move ICMP ltype to end of enum
2022-12-01 4:03 [dpdk-dev] [PATCH] common/cnxk: move ICMP ltype to end of enum psatheesh
@ 2023-01-09 15:27 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2023-01-09 15:27 UTC (permalink / raw)
To: psatheesh
Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao,
dev, Jerin Jacob
On Thu, Dec 1, 2022 at 9:33 AM <psatheesh@marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> While configuring the RSS key, mask has been created to match multiple
> ltypes for L4. Since ICMP is placed in between, it is also being
> considered for RSS. So, moving the ICMP to end of enum.
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/common/cnxk/hw/npc.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/common/cnxk/hw/npc.h b/drivers/common/cnxk/hw/npc.h
> index b8218e25af..4164c6ac2e 100644
> --- a/drivers/common/cnxk/hw/npc.h
> +++ b/drivers/common/cnxk/hw/npc.h
> @@ -219,8 +219,7 @@ enum npc_kpu_lc_ltype {
> enum npc_kpu_ld_ltype {
> NPC_LT_LD_TCP = 1,
> NPC_LT_LD_UDP,
> - NPC_LT_LD_ICMP,
> - NPC_LT_LD_SCTP,
> + NPC_LT_LD_SCTP = 4,
> NPC_LT_LD_ICMP6,
> NPC_LT_LD_CUSTOM0,
> NPC_LT_LD_CUSTOM1,
> @@ -231,6 +230,7 @@ enum npc_kpu_ld_ltype {
> NPC_LT_LD_NSH,
> NPC_LT_LD_TU_MPLS_IN_NSH,
> NPC_LT_LD_TU_MPLS_IN_IP,
> + NPC_LT_LD_ICMP,
> };
>
> enum npc_kpu_le_ltype {
> @@ -276,14 +276,14 @@ enum npc_kpu_lg_ltype {
> enum npc_kpu_lh_ltype {
> NPC_LT_LH_TU_TCP = 1,
> NPC_LT_LH_TU_UDP,
> - NPC_LT_LH_TU_ICMP,
> - NPC_LT_LH_TU_SCTP,
> + NPC_LT_LH_TU_SCTP = 4,
> NPC_LT_LH_TU_ICMP6,
> + NPC_LT_LH_CUSTOM0,
> + NPC_LT_LH_CUSTOM1,
> NPC_LT_LH_TU_IGMP = 8,
> NPC_LT_LH_TU_ESP,
> NPC_LT_LH_TU_AH,
> - NPC_LT_LH_CUSTOM0 = 0xE,
> - NPC_LT_LH_CUSTOM1 = 0xF,
> + NPC_LT_LH_TU_ICMP = 0xF,
> };
>
> enum npc_kpu_lb_uflag {
> --
> 2.35.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-09 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-01 4:03 [dpdk-dev] [PATCH] common/cnxk: move ICMP ltype to end of enum psatheesh
2023-01-09 15:27 ` Jerin Jacob
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.