From: Martin Fuzzey <mfuzzey-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Martin Fuzzey <mfuzzey-mB3Nsq4MPf1BDgjK7y7TUQ@public.gmane.org>, Mike Turquette <mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" <devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> Subject: Re: [RFC PATCH] CLK: Allow parent clock and rate to be configured in DT. Date: Sat, 6 Apr 2013 19:51:55 +0200 [thread overview] Message-ID: <CALBypN4mHwWZNiAQqErh1bL1sPHNuRbO5-yxzY+R1enQqEJOSQ@mail.gmail.com> (raw) In-Reply-To: <6581638.FPkNsv6peb@flatron> On Sat, Apr 6, 2013 at 3:21 PM, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > Hi, > > [RANT] > > I tend to disagree about this whole hype about device tree usage for other > things than pure hardware description. I don't think device tree should be > a way to force some kind of new world order, but rather a more convenient > and more maintainable (than board files) way of support hardware platforms > in Linux kernel. > Totally agree > On Friday 05 of April 2013 20:07:09 Matt Sealey wrote: >> >> The device tree concept is NOT a place to dump configuration items for >> your board as hardcoded values to try and force something you could >> have done elsewhere. On i.MX53 you cannot boot a kernel verbatim - you >> at least have to run through the Boot ROM and supply a DCD table or >> plugins first. This is where you figure things like this out. > You're suggesting setting the frequencies, parents etc in the DCD table?? Why? IMHO that's horribly unreadable. > But you can't always have control over the bootloader. What's wrong in > letting the kernel configure the board itself? It must configure most of > the hardware anyway, based on platform data (either located in board files > or parsed from device tree). > > Why not to make the kernel independent from the bootloader at all? Then > the bootloader could just do some minimal initialization needed to load a > kernel image from flash memory and launch it (+ some code to allow > flashing of new images). > Yes that's my opinion too. I think the bootloader should really do as little as possible since: * It's generally harder and/or riskier to update the bootloader than the kernel (althugh somewhat less true these days with boot from SD) * There are multiple bootloaders (u-boot, barebox, ...) but only one kernel * It makes it easier to do product families where you have a common bootloader and kernel image with different DTBs per variant. You can then put all the DTBs in the boot partition and use a bootloader variable to chose the right one. >> I am totally against this (sorry Sascha..). Let's put some effort into >> fixing the bootloaders rather than trying to use the device tree to >> enforce the ridiculous assumption that "Linux kernel does not trust >> the bootloader". Why is this "rediculous" IMHO the kernel shouldn't trust the bootloader, beyond having setting up the hardware sufficiently to reliably and safely execute code. >> Once the bindings and trees are out of the kernel >> source, you're going to HAVE to trust what the bootloader passes, be >> it pregenerated compiled blob (which needs to be written to match the >> hardware state the bootloader finishes up at) or dynamically generated >> at runtime during the boot process (which can describe to the bit what >> the hardware is doing). You have to trust the DTB yes but that is not the same as trusting the bootloader to have setup the hardware. I fail to see what difference it makes if the DTS is inside or outside the kernel source. Even today you can compile a DTB from out of tree DTS and pass it to a mainline kernel. Regards, Martin
WARNING: multiple messages have this Message-ID (diff)
From: mfuzzey@gmail.com (Martin Fuzzey) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH] CLK: Allow parent clock and rate to be configured in DT. Date: Sat, 6 Apr 2013 19:51:55 +0200 [thread overview] Message-ID: <CALBypN4mHwWZNiAQqErh1bL1sPHNuRbO5-yxzY+R1enQqEJOSQ@mail.gmail.com> (raw) In-Reply-To: <6581638.FPkNsv6peb@flatron> On Sat, Apr 6, 2013 at 3:21 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi, > > [RANT] > > I tend to disagree about this whole hype about device tree usage for other > things than pure hardware description. I don't think device tree should be > a way to force some kind of new world order, but rather a more convenient > and more maintainable (than board files) way of support hardware platforms > in Linux kernel. > Totally agree > On Friday 05 of April 2013 20:07:09 Matt Sealey wrote: >> >> The device tree concept is NOT a place to dump configuration items for >> your board as hardcoded values to try and force something you could >> have done elsewhere. On i.MX53 you cannot boot a kernel verbatim - you >> at least have to run through the Boot ROM and supply a DCD table or >> plugins first. This is where you figure things like this out. > You're suggesting setting the frequencies, parents etc in the DCD table?? Why? IMHO that's horribly unreadable. > But you can't always have control over the bootloader. What's wrong in > letting the kernel configure the board itself? It must configure most of > the hardware anyway, based on platform data (either located in board files > or parsed from device tree). > > Why not to make the kernel independent from the bootloader at all? Then > the bootloader could just do some minimal initialization needed to load a > kernel image from flash memory and launch it (+ some code to allow > flashing of new images). > Yes that's my opinion too. I think the bootloader should really do as little as possible since: * It's generally harder and/or riskier to update the bootloader than the kernel (althugh somewhat less true these days with boot from SD) * There are multiple bootloaders (u-boot, barebox, ...) but only one kernel * It makes it easier to do product families where you have a common bootloader and kernel image with different DTBs per variant. You can then put all the DTBs in the boot partition and use a bootloader variable to chose the right one. >> I am totally against this (sorry Sascha..). Let's put some effort into >> fixing the bootloaders rather than trying to use the device tree to >> enforce the ridiculous assumption that "Linux kernel does not trust >> the bootloader". Why is this "rediculous" IMHO the kernel shouldn't trust the bootloader, beyond having setting up the hardware sufficiently to reliably and safely execute code. >> Once the bindings and trees are out of the kernel >> source, you're going to HAVE to trust what the bootloader passes, be >> it pregenerated compiled blob (which needs to be written to match the >> hardware state the bootloader finishes up at) or dynamically generated >> at runtime during the boot process (which can describe to the bit what >> the hardware is doing). You have to trust the DTB yes but that is not the same as trusting the bootloader to have setup the hardware. I fail to see what difference it makes if the DTS is inside or outside the kernel source. Even today you can compile a DTB from out of tree DTS and pass it to a mainline kernel. Regards, Martin
next prev parent reply other threads:[~2013-04-06 17:51 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-19 17:09 [RFC PATCH] CLK: Allow parent clock and rate to be configured in DT Martin Fuzzey 2013-03-19 17:09 ` Martin Fuzzey 2013-03-25 10:17 ` Sascha Hauer 2013-03-25 10:17 ` Sascha Hauer [not found] ` <20130325101707.GZ1906-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2013-03-25 11:07 ` Martin Fuzzey 2013-03-25 11:07 ` Martin Fuzzey [not found] ` <51503007.5020403-mB3Nsq4MPf1BDgjK7y7TUQ@public.gmane.org> 2013-03-25 13:29 ` Sascha Hauer 2013-03-25 13:29 ` Sascha Hauer [not found] ` <20130325132935.GE1906-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2013-03-26 11:12 ` Martin Fuzzey 2013-03-26 11:12 ` Martin Fuzzey [not found] ` <51518296.7000500-mB3Nsq4MPf1BDgjK7y7TUQ@public.gmane.org> 2013-03-27 8:59 ` Sascha Hauer 2013-03-27 8:59 ` Sascha Hauer 2013-04-04 23:08 ` Fabio Estevam 2013-04-04 23:08 ` Fabio Estevam 2013-04-06 1:07 ` Matt Sealey 2013-04-06 1:07 ` Matt Sealey 2013-04-06 1:33 ` Matt Sealey 2013-04-06 1:33 ` Matt Sealey 2013-04-06 13:21 ` Tomasz Figa 2013-04-06 13:21 ` Tomasz Figa 2013-04-06 13:31 ` Tomasz Figa 2013-04-06 13:31 ` Tomasz Figa 2013-04-06 17:51 ` Martin Fuzzey [this message] 2013-04-06 17:51 ` Martin Fuzzey [not found] ` <CALBypN4mHwWZNiAQqErh1bL1sPHNuRbO5-yxzY+R1enQqEJOSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-04-06 19:24 ` Matt Sealey 2013-04-06 19:24 ` Matt Sealey [not found] ` <CAKGA1b=Z4M6t4BVFyfqxq=iZ6MHGbgHf5WodGbTCSaC7E_b7FA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-04-06 19:40 ` Fabio Estevam 2013-04-06 19:40 ` Fabio Estevam 2013-04-07 13:26 ` Sascha Hauer 2013-04-07 13:26 ` Sascha Hauer [not found] ` <20130407132623.GP1906-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2013-04-07 15:50 ` Matt Sealey 2013-04-07 15:50 ` Matt Sealey [not found] ` <CAKGA1b=AcQsA-P-pR+in+9CzqW=XfEBhdoR+AC7QCLYfUhQqJg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-04-07 16:00 ` Fabio Estevam 2013-04-07 16:00 ` Fabio Estevam [not found] ` <CAOMZO5ARwOLdSg4Np_HB2m7zvTNE94bJBUh3R-oG=xcP4R6Y-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-04-07 16:23 ` Matt Sealey 2013-04-07 16:23 ` Matt Sealey [not found] ` <CAKGA1bnt_wrNPg2JdAu=ac+WiUm8pVaGh3Tjrt3NvgdFeLxB8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-04-07 16:34 ` Matt Sealey 2013-04-07 16:34 ` Matt Sealey [not found] ` <CAKGA1bnhMz-18RvUq1Bx-b_AztwspYC+Q+3QGYf=kBtMe1nq2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-04-07 21:14 ` Tomasz Figa 2013-04-07 21:14 ` Tomasz Figa 2013-04-08 9:35 ` Martin Fuzzey 2013-04-08 9:35 ` Martin Fuzzey 2013-04-08 20:00 ` Sascha Hauer 2013-04-08 20:00 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CALBypN4mHwWZNiAQqErh1bL1sPHNuRbO5-yxzY+R1enQqEJOSQ@mail.gmail.com \ --to=mfuzzey-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \ --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=mfuzzey-mB3Nsq4MPf1BDgjK7y7TUQ@public.gmane.org \ --cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.