All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Christoph Lameter <cl@linux.com>,
	Serge Hallyn <serge.hallyn@ubuntu.com>,
	Serge Hallyn <serge.hallyn@canonical.com>,
	Aaron Jones <aaronmdjones@gmail.com>, "Ted Ts'o" <tytso@mit.edu>,
	LSM List <linux-security-module@vger.kernel.org>,
	Andrew Morton <akpm@linuxfoundation.org>,
	"Andrew G. Morgan" <morgan@kernel.org>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Austin S Hemmelgarn <ahferroin7@gmail.com>,
	Markku Savela <msa@moth.iki.fi>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux API <linux-api@vger.kernel.org>,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] capabilities: Ambient capability set V1
Date: Thu, 26 Feb 2015 11:38:01 -0800	[thread overview]
Message-ID: <CALCETrWpKiurZEEOT25i_xrtQyk5dht+wjUO4+tGs+N_7JCdYA@mail.gmail.com> (raw)
In-Reply-To: <20150226193200.GA17709@mail.hallyn.com>

On Thu, Feb 26, 2015 at 11:32 AM, Serge E. Hallyn <serge@hallyn.com> wrote:
> On Thu, Feb 26, 2015 at 12:28:30PM -0600, Christoph Lameter wrote:
>> On Thu, 26 Feb 2015, Serge E. Hallyn wrote:
>>
>> > > Well doing that breaks su.
>> >
>> > Don't what exactly?  You're saying that doing
>> >
>> > pI' = pI
>> > pA' = pA  (pA is ambient)
>> > pP' = (X & fP) | (pI & (fI | pA))
>> > pE' = pP' & (fE | pA)
>> >
>> > stopped su from having CAP_SETGID while
>> >
>> > pI' = pI
>> > pA' = pA  (pA is ambient)
>> > pP' = (X & fP) | (pI & (fI | pA))
>> > pE' = pP' & fE
>> >
>> > worked?  I'll hope you're saying both "fail", in which case
>>
>> fE does not exist in cpu_vfs_cap_data. We only get fI and fP. Why in the
>> world does setcap allow setting fE?
>
> It sets a bit in the magic_etc.  So fE is either all on or all off.
>
>> V1 does not use fE. In my newer attempt, I seemed to have worked
>> with zeroed field that I assumed was filled in.
>>
>> I will just do
>>
>> pE' = pP'
>>
>> Ok?
>
> Andrew Morgan was against that.  What if we changed
>
> pE' = pP' & (fE | pA)
>
> to
>
>         if (pA)
>                 pE' = pP' & fE
>         else
>                 pE' = pP'
>

Is this backwards?

Also, on further bikeshedding consideration, I think I like the name
"persistent" much better than "ambient".  Alas, "persistent" starts
with a P.

--Andy

  reply	other threads:[~2015-02-26 19:38 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 21:56 [PATCH] capabilities: Ambient capability set V1 Christoph Lameter
2015-02-05 21:56 ` Christoph Lameter
2015-02-23 14:58 ` Christoph Lameter
2015-02-23 14:58   ` Christoph Lameter
2015-02-23 15:44   ` Andy Lutomirski
2015-02-23 15:53     ` Christoph Lameter
2015-02-23 15:53       ` Christoph Lameter
2015-02-23 15:59       ` Andy Lutomirski
2015-02-23 16:41         ` Christoph Lameter
2015-02-23 23:51           ` Andy Lutomirski
2015-02-24 15:48             ` Christoph Lameter
2015-02-23 16:16   ` Serge Hallyn
2015-02-23 16:33     ` Andy Lutomirski
2015-02-23 16:45       ` Serge E. Hallyn
2015-02-23 16:45         ` Serge E. Hallyn
2015-02-23 16:47       ` Christoph Lameter
2015-02-23 16:44     ` Christoph Lameter
2015-02-23 16:44       ` Christoph Lameter
2015-02-23 16:46       ` Serge E. Hallyn
2015-02-23 16:50         ` Christoph Lameter
2015-02-23 18:15           ` Serge Hallyn
2015-02-23 18:27             ` Christoph Lameter
2015-02-24  5:19             ` Serge E. Hallyn
2015-02-24 15:47               ` Serge E. Hallyn
2015-02-24 15:47                 ` Serge E. Hallyn
2015-02-24 15:58                 ` Christoph Lameter
2015-02-24 16:44                   ` Serge Hallyn
2015-02-24 17:28                     ` Christoph Lameter
2015-02-25  3:32                       ` Serge Hallyn
2015-02-25 20:25                         ` Christoph Lameter
2015-02-25 20:25                           ` Christoph Lameter
2015-02-26 15:35                           ` Serge E. Hallyn
2015-02-26 18:28                             ` Christoph Lameter
2015-02-26 18:28                               ` Christoph Lameter
2015-02-26 19:32                               ` Serge E. Hallyn
2015-02-26 19:38                                 ` Andy Lutomirski [this message]
2015-02-26 20:16                                   ` Christoph Lameter
2015-02-26 20:16                                     ` Christoph Lameter
2015-02-26 20:33                                   ` Serge E. Hallyn
2015-02-26 20:13                                 ` Christoph Lameter
2015-02-26 20:13                                   ` Christoph Lameter
2015-02-26 20:34                                   ` Serge E. Hallyn
2015-02-26 20:51                                     ` Andy Lutomirski
2015-02-26 20:55                                       ` Serge E. Hallyn
2015-02-26 20:58                                         ` Andy Lutomirski
2015-02-26 20:58                                           ` Andy Lutomirski
2015-02-26 21:19                                           ` Serge E. Hallyn
2015-02-26 21:29                                           ` Christoph Lameter
2015-02-26 21:09                                     ` Christoph Lameter
2015-02-26 21:13                                       ` Serge E. Hallyn
2015-02-26 21:13                                         ` Serge E. Hallyn
2015-02-26 21:23                                         ` Christoph Lameter
2015-02-26 21:32                                           ` Serge E. Hallyn
2015-02-26 21:37                                             ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALCETrWpKiurZEEOT25i_xrtQyk5dht+wjUO4+tGs+N_7JCdYA@mail.gmail.com \
    --to=luto@amacapital.net \
    --cc=aaronmdjones@gmail.com \
    --cc=ahferroin7@gmail.com \
    --cc=akpm@linuxfoundation.org \
    --cc=cl@linux.com \
    --cc=corbet@lwn.net \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=morgan@kernel.org \
    --cc=msa@moth.iki.fi \
    --cc=mtk.manpages@gmail.com \
    --cc=serge.hallyn@canonical.com \
    --cc=serge.hallyn@ubuntu.com \
    --cc=serge@hallyn.com \
    --cc=tytso@mit.edu \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.