From: Andy Lutomirski <luto@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, Deep Shah <sdeep@vmware.com>,
"VMware, Inc." <pv-drivers@vmware.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 3/4] x86/pv: switch SWAPGS to ALTERNATIVE
Date: Mon, 16 Nov 2020 08:17:29 -0800 [thread overview]
Message-ID: <CALCETrWwnK1AwrGRn8Kuin-23NOG31LrWBO7w=T2QE+EJW=f-w@mail.gmail.com> (raw)
In-Reply-To: <20201116152301.24558-4-jgross@suse.com>
On Mon, Nov 16, 2020 at 7:23 AM Juergen Gross <jgross@suse.com> wrote:
>
> SWAPGS is used only for interrupts coming from user mode or for
> returning to user mode. So there is no reason to use the PARAVIRT
> framework, as it can easily be replaced by an ALTERNATIVE depending
> on X86_FEATURE_XENPV.
>
> There are several instances using the PV-aware SWAPGS macro in paths
> which are never executed in a Xen PV guest. Replace those with the
> plain swapgs instruction. For SWAPGS_UNSAFE_STACK the same applies.
Acked-by: Andy Lutomirski <luto@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Andy Lutomirski <luto@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
"VMware, Inc." <pv-drivers@vmware.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Thomas Gleixner <tglx@linutronix.de>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 3/4] x86/pv: switch SWAPGS to ALTERNATIVE
Date: Mon, 16 Nov 2020 08:17:29 -0800 [thread overview]
Message-ID: <CALCETrWwnK1AwrGRn8Kuin-23NOG31LrWBO7w=T2QE+EJW=f-w@mail.gmail.com> (raw)
In-Reply-To: <20201116152301.24558-4-jgross@suse.com>
On Mon, Nov 16, 2020 at 7:23 AM Juergen Gross <jgross@suse.com> wrote:
>
> SWAPGS is used only for interrupts coming from user mode or for
> returning to user mode. So there is no reason to use the PARAVIRT
> framework, as it can easily be replaced by an ALTERNATIVE depending
> on X86_FEATURE_XENPV.
>
> There are several instances using the PV-aware SWAPGS macro in paths
> which are never executed in a Xen PV guest. Replace those with the
> plain swapgs instruction. For SWAPGS_UNSAFE_STACK the same applies.
Acked-by: Andy Lutomirski <luto@kernel.org>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-11-16 16:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 15:22 [PATCH 0/4] x86/xen: do some paravirt cleanup Juergen Gross
2020-11-16 15:22 ` Juergen Gross via Virtualization
2020-11-16 15:22 ` [PATCH 1/4] x86/xen: use specific Xen pv interrupt entry for MCE Juergen Gross
2020-11-16 15:22 ` [PATCH 2/4] x86/xen: use specific Xen pv interrupt entry for DF Juergen Gross
2020-11-16 16:12 ` Andy Lutomirski
2020-11-16 16:12 ` Andy Lutomirski
2020-11-16 16:14 ` Jürgen Groß
2020-11-16 15:23 ` [PATCH 3/4] x86/pv: switch SWAPGS to ALTERNATIVE Juergen Gross
2020-11-16 15:23 ` Juergen Gross via Virtualization
2020-11-16 16:17 ` Andy Lutomirski [this message]
2020-11-16 16:17 ` Andy Lutomirski
2020-11-16 16:17 ` Andy Lutomirski
2020-11-16 15:23 ` [PATCH 4/4] x86/xen: drop USERGS_SYSRET64 paravirt call Juergen Gross
2020-11-16 15:23 ` Juergen Gross via Virtualization
2020-11-16 16:28 ` Andy Lutomirski
2020-11-16 16:28 ` Andy Lutomirski
2020-11-16 16:28 ` Andy Lutomirski
2020-11-17 8:19 ` Jürgen Groß
2020-11-17 8:19 ` Jürgen Groß via Virtualization
2020-11-16 16:30 ` Andy Lutomirski
2020-11-16 16:30 ` Andy Lutomirski
2020-11-16 16:30 ` Andy Lutomirski
2020-11-17 10:00 ` [PATCH 0/4] x86/xen: do some paravirt cleanup Peter Zijlstra
2020-11-17 10:00 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALCETrWwnK1AwrGRn8Kuin-23NOG31LrWBO7w=T2QE+EJW=f-w@mail.gmail.com' \
--to=luto@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=sdeep@vmware.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.