From: Andy Lutomirski <luto@amacapital.net> To: Tyler Baker <tyler.baker@linaro.org> Cc: Shuah Khan <shuahkh@osg.samsung.com>, Kevin Hilman <khilman@kernel.org>, John Stultz <john.stultz@linaro.org>, Darren Hart <dvhart@infradead.org>, David Herrmann <dh.herrmann@gmail.com>, Michael Ellerman <mpe@ellerman.id.au>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 5/8] selftest/x86: build both bitnesses Date: Mon, 20 Apr 2015 16:21:54 -0700 [thread overview] Message-ID: <CALCETrX7x8k35Hza04dzSRguWSAFp0XGu__USZM5off1=Y9_wA@mail.gmail.com> (raw) In-Reply-To: <1429571717-27338-1-git-send-email-tyler.baker@linaro.org> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote: > Using uname with the processor flag option in some cases can yield 'unknown' > so lets use the machine flag option as it is deterministic. Add a dependency > for all_32 when building on a x86 64 bit host so that both bitnesses are > built in this case. > Acked-by: Andy Lutomirski <luto@kernel.org> > Cc: Andy Lutomirski <luto@amacapital.net> > Signed-off-by: Tyler Baker <tyler.baker@linaro.org> > --- > tools/testing/selftests/x86/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile > index ddf6356..be93945 100644 > --- a/tools/testing/selftests/x86/Makefile > +++ b/tools/testing/selftests/x86/Makefile > @@ -7,13 +7,13 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64) > > CFLAGS := -O2 -g -std=gnu99 -pthread -Wall > > -UNAME_P := $(shell uname -p) > +UNAME_M := $(shell uname -m) > > # Always build 32-bit tests > all: all_32 > > # If we're on a 64-bit host, build 64-bit tests as well > -ifeq ($(shell uname -p),x86_64) > +ifeq ($(UNAME_M),x86_64) > all: all_64 > endif > > -- > 2.1.4 > -- Andy Lutomirski AMA Capital Management, LLC
WARNING: multiple messages have this Message-ID (diff)
From: luto@amacapital.net (Andy Lutomirski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 5/8] selftest/x86: build both bitnesses Date: Mon, 20 Apr 2015 16:21:54 -0700 [thread overview] Message-ID: <CALCETrX7x8k35Hza04dzSRguWSAFp0XGu__USZM5off1=Y9_wA@mail.gmail.com> (raw) In-Reply-To: <1429571717-27338-1-git-send-email-tyler.baker@linaro.org> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote: > Using uname with the processor flag option in some cases can yield 'unknown' > so lets use the machine flag option as it is deterministic. Add a dependency > for all_32 when building on a x86 64 bit host so that both bitnesses are > built in this case. > Acked-by: Andy Lutomirski <luto@kernel.org> > Cc: Andy Lutomirski <luto@amacapital.net> > Signed-off-by: Tyler Baker <tyler.baker@linaro.org> > --- > tools/testing/selftests/x86/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile > index ddf6356..be93945 100644 > --- a/tools/testing/selftests/x86/Makefile > +++ b/tools/testing/selftests/x86/Makefile > @@ -7,13 +7,13 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64) > > CFLAGS := -O2 -g -std=gnu99 -pthread -Wall > > -UNAME_P := $(shell uname -p) > +UNAME_M := $(shell uname -m) > > # Always build 32-bit tests > all: all_32 > > # If we're on a 64-bit host, build 64-bit tests as well > -ifeq ($(shell uname -p),x86_64) > +ifeq ($(UNAME_M),x86_64) > all: all_64 > endif > > -- > 2.1.4 > -- Andy Lutomirski AMA Capital Management, LLC
next prev parent reply other threads:[~2015-04-20 23:22 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-20 23:15 [PATCH v3 5/8] selftest/x86: build both bitnesses Tyler Baker 2015-04-20 23:15 ` Tyler Baker 2015-04-20 23:21 ` Andy Lutomirski [this message] 2015-04-20 23:21 ` Andy Lutomirski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CALCETrX7x8k35Hza04dzSRguWSAFp0XGu__USZM5off1=Y9_wA@mail.gmail.com' \ --to=luto@amacapital.net \ --cc=dh.herrmann@gmail.com \ --cc=dvhart@infradead.org \ --cc=john.stultz@linaro.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mpe@ellerman.id.au \ --cc=shuahkh@osg.samsung.com \ --cc=tyler.baker@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.