All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Tu <u9012063@gmail.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>
Cc: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
	"Björn Töpel" <bjorn.topel@intel.com>,
	"Karlsson, Magnus" <magnus.karlsson@intel.com>,
	"Magnus Karlsson" <magnus.karlsson@gmail.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Linux Kernel Network Developers" <netdev@vger.kernel.org>,
	"Jesper Dangaard Brouer" <brouer@redhat.com>,
	Test <tuc@vmware.com>,
	"Jakub Kicinski" <jakub.kicinski@netronome.com>
Subject: Re: [PATCH v2 5/5] ixgbe: add AF_XDP zero-copy Tx support
Date: Tue, 2 Oct 2018 11:26:50 -0700	[thread overview]
Message-ID: <CALDO+SY20B0q7F2C_A9AO=woukFqCHRe0+hFEYU0beqYfW_O2Q@mail.gmail.com> (raw)
In-Reply-To: <20181002080034.11754-6-bjorn.topel@gmail.com>

On Tue, Oct 2, 2018 at 1:01 AM Björn Töpel <bjorn.topel@gmail.com> wrote:
>
> From: Björn Töpel <bjorn.topel@intel.com>
>
> This patch adds zero-copy Tx support for AF_XDP sockets. It implements
> the ndo_xsk_async_xmit netdev ndo and performs all the Tx logic from a
> NAPI context. This means pulling egress packets from the Tx ring,
> placing the frames on the NIC HW descriptor ring and completing sent
> frames back to the application via the completion ring.
>
> The regular XDP Tx ring is used for AF_XDP as well. This rationale for
> this is as follows: XDP_REDIRECT guarantees mutual exclusion between
> different NAPI contexts based on CPU id. In other words, a netdev can
> XDP_REDIRECT to another netdev with a different NAPI context, since
> the operation is bound to a specific core and each core has its own
> hardware ring.
>
> As the AF_XDP Tx action is running in the same NAPI context and using
> the same ring, it will also be protected from XDP_REDIRECT actions
> with the exact same mechanism.
>
> As with AF_XDP Rx, all AF_XDP Tx specific functions are added to
> ixgbe_xsk.c.
>
> Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
> ---

Thanks!
Tested-by: William Tu <u9012063@gmail.com>

WARNING: multiple messages have this Message-ID (diff)
From: William Tu <u9012063@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 5/5] ixgbe: add AF_XDP zero-copy Tx support
Date: Tue, 2 Oct 2018 11:26:50 -0700	[thread overview]
Message-ID: <CALDO+SY20B0q7F2C_A9AO=woukFqCHRe0+hFEYU0beqYfW_O2Q@mail.gmail.com> (raw)
In-Reply-To: <20181002080034.11754-6-bjorn.topel@gmail.com>

On Tue, Oct 2, 2018 at 1:01 AM Bj?rn T?pel <bjorn.topel@gmail.com> wrote:
>
> From: Bj?rn T?pel <bjorn.topel@intel.com>
>
> This patch adds zero-copy Tx support for AF_XDP sockets. It implements
> the ndo_xsk_async_xmit netdev ndo and performs all the Tx logic from a
> NAPI context. This means pulling egress packets from the Tx ring,
> placing the frames on the NIC HW descriptor ring and completing sent
> frames back to the application via the completion ring.
>
> The regular XDP Tx ring is used for AF_XDP as well. This rationale for
> this is as follows: XDP_REDIRECT guarantees mutual exclusion between
> different NAPI contexts based on CPU id. In other words, a netdev can
> XDP_REDIRECT to another netdev with a different NAPI context, since
> the operation is bound to a specific core and each core has its own
> hardware ring.
>
> As the AF_XDP Tx action is running in the same NAPI context and using
> the same ring, it will also be protected from XDP_REDIRECT actions
> with the exact same mechanism.
>
> As with AF_XDP Rx, all AF_XDP Tx specific functions are added to
> ixgbe_xsk.c.
>
> Signed-off-by: Bj?rn T?pel <bjorn.topel@intel.com>
> ---

Thanks!
Tested-by: William Tu <u9012063@gmail.com>

  reply	other threads:[~2018-10-03  1:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02  8:00 [PATCH v2 0/5] Introducing ixgbe AF_XDP ZC support Björn Töpel
2018-10-02  8:00 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2018-10-02  8:00 ` [PATCH v2 1/5] ixgbe: added Rx/Tx ring disable/enable functions Björn Töpel
2018-10-02  8:00   ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2018-10-02 18:25   ` William Tu
2018-10-02 18:25     ` [Intel-wired-lan] " William Tu
2018-10-02  8:00 ` [PATCH v2 2/5] ixgbe: move common Rx functions to ixgbe_txrx_common.h Björn Töpel
2018-10-02  8:00   ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2018-10-02 18:27   ` William Tu
2018-10-02 18:27     ` [Intel-wired-lan] " William Tu
2018-10-02  8:00 ` [PATCH v2 3/5] ixgbe: add AF_XDP zero-copy Rx support Björn Töpel
2018-10-02  8:00   ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2018-10-02 18:26   ` William Tu
2018-10-02 18:26     ` [Intel-wired-lan] " William Tu
2018-10-02  8:00 ` [PATCH v2 4/5] ixgbe: move common Tx functions to ixgbe_txrx_common.h Björn Töpel
2018-10-02  8:00   ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2018-10-02 18:28   ` William Tu
2018-10-02 18:28     ` [Intel-wired-lan] " William Tu
2018-10-02  8:00 ` [PATCH v2 5/5] ixgbe: add AF_XDP zero-copy Tx support Björn Töpel
2018-10-02  8:00   ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2018-10-02 18:26   ` William Tu [this message]
2018-10-02 18:26     ` William Tu
2018-10-02 18:23 ` [PATCH v2 0/5] Introducing ixgbe AF_XDP ZC support William Tu
2018-10-02 18:23   ` [Intel-wired-lan] " William Tu
2018-10-02 18:39   ` Björn Töpel
2018-10-02 18:39     ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2018-10-02 18:43     ` William Tu
2018-10-02 18:43       ` [Intel-wired-lan] " William Tu
2018-10-04 21:18 ` Jesper Dangaard Brouer
2018-10-04 21:18   ` [Intel-wired-lan] " Jesper Dangaard Brouer
2018-10-05  4:59   ` Björn Töpel
2018-10-05  4:59     ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2018-10-05 11:30     ` Björn Töpel
2018-10-05 11:30       ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALDO+SY20B0q7F2C_A9AO=woukFqCHRe0+hFEYU0beqYfW_O2Q@mail.gmail.com' \
    --to=u9012063@gmail.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@gmail.com \
    --cc=bjorn.topel@intel.com \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jakub.kicinski@netronome.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=magnus.karlsson@gmail.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=tuc@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.