[v4l-utils] Add configure option to allow qv4l2 disable

[v4l-utils] Add configure option to allow qv4l2 disable

[Ezequiel Garcia]

This patch could ease the job of a few people, 
by providing an option they actually need. 
OpenWRT [1] and Openembedded [2] are already disabling 
qv4l2 by applying ugly patches.

[1] https://dev.openwrt.org/browser/packages/libs/libv4l/patches/004-disable-qv4l2.patch
[2] http://patches.openembedded.org/patch/21469/

Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
---
 configure.ac |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 98fad38..92ee050 100644
--- a/configure.ac
+++ b/configure.ac
@@ -83,8 +83,17 @@ AS_IF([test "x$with_jpeg" != xno],
 
 AM_CONDITIONAL([HAVE_JPEG], [$have_jpeg])
 
+AC_ARG_ENABLE(qv4l2,
+  [  --disable-qv4l2         disable qv4l2 compilation],
+  [case "${enableval}" in
+     yes | no ) with_qv4l2="${enableval}" ;;
+     *) AC_MSG_ERROR(bad value ${enableval} for --disable-qv4l2) ;;
+   esac],
+  [with_qv4l2="yes"]
+)
+
 PKG_CHECK_MODULES(QT, [QtCore >= 4.4 QtGui >= 4.4], [qt_pkgconfig=true], [qt_pkgconfig=false])
-if test "x$qt_pkgconfig" = "xtrue"; then
+if test "x$qt_pkgconfig" = "xtrue" && test "x$with_qv4l2" = "xyes"; then
    AC_SUBST(QT_CFLAGS)
    AC_SUBST(QT_LIBS)
    MOC=`$PKG_CONFIG --variable=moc_location QtCore`
-- 
1.7.3.4

Re: [v4l-utils] Add configure option to allow qv4l2 disable

[Gregor Jasny]

Hello,

On 5/30/12 3:42 PM, Ezequiel Garcia wrote:
> This patch could ease the job of a few people,
> by providing an option they actually need.
> OpenWRT [1] and Openembedded [2] are already disabling
> qv4l2 by applying ugly patches.
>
> [1] https://dev.openwrt.org/browser/packages/libs/libv4l/patches/004-disable-qv4l2.patch
> [2] http://patches.openembedded.org/patch/21469/

What's the purpose of this patch? As far as I can see it saves compile 
time if Qt4 development stuff is installed. Otherwise building qv4l 
should be skipped.

But it also does not hurt to make building qv4l2 optional.

Thanks,
Gregor

Re: [v4l-utils] Add configure option to allow qv4l2 disable

[Ezequiel Garcia]

Hi Gregor,

On Thu, May 31, 2012 at 4:07 AM, Gregor Jasny <gjasny@googlemail.com> wrote:
> Hello,
>
>
> On 5/30/12 3:42 PM, Ezequiel Garcia wrote:
>>
>> This patch could ease the job of a few people,
>> by providing an option they actually need.
>> OpenWRT [1] and Openembedded [2] are already disabling
>> qv4l2 by applying ugly patches.
>>
>> [1]
>> https://dev.openwrt.org/browser/packages/libs/libv4l/patches/004-disable-qv4l2.patch
>> [2] http://patches.openembedded.org/patch/21469/
>
>
> What's the purpose of this patch? As far as I can see it saves compile time
> if Qt4 development stuff is installed. Otherwise building qv4l should be
> skipped.

I just found that people were applying patches to disable qv4l2 compilation.
In [2] you'll find this message: "The makefiles in the project attempt
to use the hosts' compilers if
qmake is installed." Perhaps, this was due to an old bug that's already solved.

So: I'm not sure if patch is useful, but I thought I could send it
anyway and let you decide ;)

Hope it helps,
Ezequiel.

Re: [v4l-utils] Add configure option to allow qv4l2 disable

[Mauro Carvalho Chehab]

Em 31-05-2012 13:29, Ezequiel Garcia escreveu:
> Hi Gregor,
> 
> On Thu, May 31, 2012 at 4:07 AM, Gregor Jasny <gjasny@googlemail.com> wrote:
>> Hello,
>>
>>
>> On 5/30/12 3:42 PM, Ezequiel Garcia wrote:
>>>
>>> This patch could ease the job of a few people,
>>> by providing an option they actually need.
>>> OpenWRT [1] and Openembedded [2] are already disabling
>>> qv4l2 by applying ugly patches.
>>>
>>> [1]
>>> https://dev.openwrt.org/browser/packages/libs/libv4l/patches/004-disable-qv4l2.patch
>>> [2] http://patches.openembedded.org/patch/21469/
>>
>>
>> What's the purpose of this patch? As far as I can see it saves compile time
>> if Qt4 development stuff is installed. Otherwise building qv4l should be
>> skipped.
> 
> I just found that people were applying patches to disable qv4l2 compilation.
> In [2] you'll find this message: "The makefiles in the project attempt
> to use the hosts' compilers if
> qmake is installed." Perhaps, this was due to an old bug that's already solved.
> 
> So: I'm not sure if patch is useful, but I thought I could send it
> anyway and let you decide ;)

Yeah, compiling qv4l2 on embedded distros may be hard.
I'll apply it.

Regards,
Mauro

Re: [v4l-utils] Add configure option to allow qv4l2 disable

[Ezequiel Garcia]

Hi Mauro,

On Mon, Jun 18, 2012 at 7:01 PM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> Em 31-05-2012 13:29, Ezequiel Garcia escreveu:
>> Hi Gregor,
>>
>> On Thu, May 31, 2012 at 4:07 AM, Gregor Jasny <gjasny@googlemail.com> wrote:
>>> Hello,
>>>
>>>
>>> On 5/30/12 3:42 PM, Ezequiel Garcia wrote:
>>>>
>>>> This patch could ease the job of a few people,
>>>> by providing an option they actually need.
>>>> OpenWRT [1] and Openembedded [2] are already disabling
>>>> qv4l2 by applying ugly patches.
>>>>
>>>> [1]
>>>> https://dev.openwrt.org/browser/packages/libs/libv4l/patches/004-disable-qv4l2.patch
>>>> [2] http://patches.openembedded.org/patch/21469/
>>>
>>>
>>> What's the purpose of this patch? As far as I can see it saves compile time
>>> if Qt4 development stuff is installed. Otherwise building qv4l should be
>>> skipped.
>>
>> I just found that people were applying patches to disable qv4l2 compilation.
>> In [2] you'll find this message: "The makefiles in the project attempt
>> to use the hosts' compilers if
>> qmake is installed." Perhaps, this was due to an old bug that's already solved.
>>
>> So: I'm not sure if patch is useful, but I thought I could send it
>> anyway and let you decide ;)
>
> Yeah, compiling qv4l2 on embedded distros may be hard.
> I'll apply it.
>

Gregory already applied this patch, and it seems you have now
over applied it in the same tree:

http://git.linuxtv.org/v4l-utils.git/commit/7fc9fa40e7fd1a72688c6f43fc11e085079b3f0c

http://git.linuxtv.org/v4l-utils.git/commit/06e5235b4e1514f9234a21942261ba417deb106c

Also Gregory cleaned a bit the patch
(mine was very basic, since I'm not autoconf-friendly).

So, could you revert the one you've committed?

Thanks,
Ezequiel.

Re: [v4l-utils] Add configure option to allow qv4l2 disable

[Gregor Jasny]

On 6/19/12 2:46 PM, Ezequiel Garcia wrote:
> Gregory already applied this patch, and it seems you have now
> over applied it in the same tree:

I reverted the second patch.

Thanks,
Gregor

Re: [v4l-utils] Add configure option to allow qv4l2 disable

[Mauro Carvalho Chehab]

Em 20-06-2012 12:35, Gregor Jasny escreveu:
> On 6/19/12 2:46 PM, Ezequiel Garcia wrote:
>> Gregory already applied this patch, and it seems you have now
>> over applied it in the same tree:
> 
> I reverted the second patch.

Thanks. Sorry for the mess.
> 
> Thanks,
> Gregor
>