Fixing symlinks of some intel firmware.

Fixing symlinks of some intel firmware.

[Sasa Ostrouska]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

Hi, in the last few updates of linux-firmware I saw there are some
wrong symlinks created
since the parent directory name is also in the link section.

The attached patch should fix the wrongly created symlinks.

Please cc me as I am not subscribed on this mailing list.

Rgds
Sasa

[-- Attachment #2: linux-firmware-intel-symlinks-fix.patch --]
[-- Type: text/x-patch, Size: 1425 bytes --]

diff --git a/WHENCE b/WHENCE
index e957cc9..fdb5f1d 100644
--- a/WHENCE
+++ b/WHENCE
@@ -4072,7 +4072,7 @@ Driver: snd_soc_catpt -- Intel AudioDSP driver for HSW/BDW platforms
 
 File: intel/catpt/bdw/dsp_basefw.bin
 Version: 44b81c4d5397a63108356f58f036953d9b288c4e
-Link: intel/IntcSST2.bin -> intel/catpt/bdw/dsp_basefw.bin
+Link: intel/IntcSST2.bin -> catpt/bdw/dsp_basefw.bin
 
 License: Redistributable. See LICENCE.IntcSST2 for details
 
@@ -4083,15 +4083,15 @@ Driver: snd_soc_avs -- Intel AudioDSP driver for cAVS platforms
 File: intel/avs/skl/dsp_basefw.bin
 File: intel/avs/skl/dsp_mod_7CAD0808-AB10-CD23-EF45-12AB34CD56EF.bin
 Version: 9.21.00.4899
-Link: intel/dsp_fw_release.bin -> intel/avs/skl/dsp_basefw.bin
-Link: intel/dsp_fw_kbl.bin -> intel/avs/skl/dsp_basefw.bin
+Link: intel/dsp_fw_release.bin -> avs/skl/dsp_basefw.bin
+Link: intel/dsp_fw_kbl.bin -> avs/skl/dsp_basefw.bin
 File: intel/avs/apl/dsp_basefw.bin
 Version: 9.22.01.4908
-Link: intel/dsp_fw_bxtn.bin -> intel/avs/apl/dsp_basefw.bin
-Link: intel/dsp_fw_glk.bin -> intel/avs/apl/dsp_basefw.bin
+Link: intel/dsp_fw_bxtn.bin -> avs/apl/dsp_basefw.bin
+Link: intel/dsp_fw_glk.bin -> avs/apl/dsp_basefw.bin
 File: intel/avs/cnl/dsp_basefw.bin
 Version: 10.23.00.8551
-Link: intel/dsp_fw_cnl.bin -> intel/avs/cnl/dsp_basefw.bin
+Link: intel/dsp_fw_cnl.bin -> avs/cnl/dsp_basefw.bin
 
 License: Redistributable. See LICENCE.adsp_sst for details
 

Re: Fixing symlinks of some intel firmware.

[Josh Boyer]

The patch itself isn't in the correct format, but I've included a
commit that fixes the issue and credits you with reporting the
problem.

Thanks.

josh

On Sat, Mar 4, 2023 at 7:30 PM Sasa Ostrouska <casaxa@gmail.com> wrote:
>
> Hi, in the last few updates of linux-firmware I saw there are some
> wrong symlinks created
> since the parent directory name is also in the link section.
>
> The attached patch should fix the wrongly created symlinks.
>
> Please cc me as I am not subscribed on this mailing list.
>
> Rgds
> Sasa

Re: Fixing symlinks of some intel firmware.

[Sasa Ostrouska]

On Tue, Mar 7, 2023 at 3:47 PM Josh Boyer <jwboyer@kernel.org> wrote:
>
> The patch itself isn't in the correct format, but I've included a
> commit that fixes the issue and credits you with reporting the
> problem.
>
> Thanks.
>
> josh

Dear Josh, many thanks for applying the patch. I will try to learn
better how to create a correct patch for the future.
Important is it is fixed now :) thanks again.

Rgds
Sasa
>
> On Sat, Mar 4, 2023 at 7:30 PM Sasa Ostrouska <casaxa@gmail.com> wrote:
> >
> > Hi, in the last few updates of linux-firmware I saw there are some
> > wrong symlinks created
> > since the parent directory name is also in the link section.
> >
> > The attached patch should fix the wrongly created symlinks.
> >
> > Please cc me as I am not subscribed on this mailing list.
> >
> > Rgds
> > Sasa