All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dariusz Marcinkiewicz <darekm@google.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Cheng-yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCHv8 02/13] cec: add struct cec_connector_info support
Date: Tue, 25 Jun 2019 15:19:37 +0200	[thread overview]
Message-ID: <CALFZZQGuAB9rt4Px0VXPwRE1HOipxmT7q1tF890bMBiNw2JLgA@mail.gmail.com> (raw)
In-Reply-To: <20190624160330.38048-3-hverkuil-cisco@xs4all.nl>

Hi Hans.

Patches 1 and 2 look good to me. There is one comment here that I
forgot to update as the code evolved.

On Mon, Jun 24, 2019 at 6:03 PM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
...
> +/**
> + * struct cec_event_connector - tells if and which connector is associated
> + * with the CEC adapter.
> + * @card_no: drm card number
> + * @connector_id: drm connector ID
> + */
> +struct cec_drm_connector_info {
> +       __u32 card_no;
> +       __u32 connector_id;
> +};
> +
The comment for the above struct is now appropriate for the struct below.

> +#define CEC_CONNECTOR_TYPE_NO_CONNECTOR        0
> +#define CEC_CONNECTOR_TYPE_DRM         1
> +struct cec_connector_info {
> +       __u32 type;
> +       union {
> +               struct cec_drm_connector_info drm;
> +               __u32 raw[16];
> +       };
> +};
> +

Best regards.

WARNING: multiple messages have this Message-ID (diff)
From: Dariusz Marcinkiewicz <darekm@google.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Cheng-yi Chiang <cychiang@chromium.org>,
	dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Subject: Re: [PATCHv8 02/13] cec: add struct cec_connector_info support
Date: Tue, 25 Jun 2019 15:19:37 +0200	[thread overview]
Message-ID: <CALFZZQGuAB9rt4Px0VXPwRE1HOipxmT7q1tF890bMBiNw2JLgA@mail.gmail.com> (raw)
In-Reply-To: <20190624160330.38048-3-hverkuil-cisco@xs4all.nl>

Hi Hans.

Patches 1 and 2 look good to me. There is one comment here that I
forgot to update as the code evolved.

On Mon, Jun 24, 2019 at 6:03 PM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
...
> +/**
> + * struct cec_event_connector - tells if and which connector is associated
> + * with the CEC adapter.
> + * @card_no: drm card number
> + * @connector_id: drm connector ID
> + */
> +struct cec_drm_connector_info {
> +       __u32 card_no;
> +       __u32 connector_id;
> +};
> +
The comment for the above struct is now appropriate for the struct below.

> +#define CEC_CONNECTOR_TYPE_NO_CONNECTOR        0
> +#define CEC_CONNECTOR_TYPE_DRM         1
> +struct cec_connector_info {
> +       __u32 type;
> +       union {
> +               struct cec_drm_connector_info drm;
> +               __u32 raw[16];
> +       };
> +};
> +

Best regards.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-06-25 13:19 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-24 16:03 [PATCHv8 00/13] cec: improve notifier support, add connector info Hans Verkuil
2019-06-24 16:03 ` Hans Verkuil
2019-06-24 16:03 ` [PATCHv8 01/13] cec-notifier: rename variable, check kstrdup Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-25  7:07   ` [PATCHv8.1 01/13] cec-notifier: rename variables, check kstrdup and n->conn_name Hans Verkuil
2019-06-25  7:07     ` Hans Verkuil
2019-06-24 16:03 ` [PATCHv8 02/13] cec: add struct cec_connector_info support Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-25  6:28   ` Hans Verkuil
2019-06-25  6:28     ` Hans Verkuil
2019-06-25 13:19   ` Dariusz Marcinkiewicz [this message]
2019-06-25 13:19     ` Dariusz Marcinkiewicz
2019-06-24 16:03 ` [PATCHv8 03/13] cec: add new notifier functions Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-25 13:48   ` Dariusz Marcinkiewicz
2019-06-25 13:48     ` Dariusz Marcinkiewicz
2019-06-25 14:26     ` Hans Verkuil
2019-06-25 14:26       ` Hans Verkuil
2019-06-24 16:03 ` [PATCHv8 04/13] cec: expose the new connector info API Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-25 13:59   ` Dariusz Marcinkiewicz
2019-06-25 13:59     ` Dariusz Marcinkiewicz
2019-06-25 14:28     ` Hans Verkuil
2019-06-25 14:28       ` Hans Verkuil
2019-06-24 16:03 ` [PATCHv8 05/13] cec: document CEC_ADAP_G_CONNECTOR_INFO Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-24 16:03 ` [PATCHv8 06/13] drm_dp_cec: add connector info support Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-24 16:03 ` [PATCHv8 07/13] drm/i915/intel_hdmi: use cec_notifier_conn_(un)register Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-24 16:03 ` [PATCHv8 08/13] dw-hdmi-cec: use cec_notifier_cec_adap_(un)register Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-24 16:03 ` [PATCHv8 09/13] dw-hdmi: use cec_notifier_conn_(un)register Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-25  0:43   ` kbuild test robot
2019-06-25  0:43     ` kbuild test robot
2019-06-24 16:03 ` [PATCHv8 10/13] meson/ao-cec: use cec_notifier_cec_adap_(un)register Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-24 16:03 ` [PATCHv8 11/13] tda9950: " Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-24 16:03 ` [PATCHv8 12/13] tda998x: use cec_notifier_conn_(un)register Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil
2019-06-24 22:37   ` kbuild test robot
2019-06-24 22:37     ` kbuild test robot
2019-06-24 16:03 ` [PATCHv8 13/13] drm/vc4/vc4_hdmi: fill in connector info Hans Verkuil
2019-06-24 16:03   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALFZZQGuAB9rt4Px0VXPwRE1HOipxmT7q1tF890bMBiNw2JLgA@mail.gmail.com \
    --to=darekm@google.com \
    --cc=cychiang@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.