All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] brcm-patchram-plus: new package
@ 2017-07-21 14:45 Alexey Roslyakov
  2017-07-22 13:25 ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Alexey Roslyakov @ 2017-07-21 14:45 UTC (permalink / raw)
  To: buildroot

Many of Broadcom BCM43XX WiFi/Bluetooth combo chips have pretty tricky initialization.
Broadcom patchram utility has been released to address the issue.

Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com>
---
 DEVELOPERS                                         |  3 +++
 package/Config.in                                  |  1 +
 package/brcm-patchram-plus/Config.in               |  6 ++++++
 package/brcm-patchram-plus/brcm-patchram-plus.hash |  2 ++
 package/brcm-patchram-plus/brcm-patchram-plus.mk   | 20 ++++++++++++++++++++
 5 files changed, 32 insertions(+)
 create mode 100644 package/brcm-patchram-plus/Config.in
 create mode 100644 package/brcm-patchram-plus/brcm-patchram-plus.hash
 create mode 100644 package/brcm-patchram-plus/brcm-patchram-plus.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 7b7c5ab4e6..45466591da 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -73,6 +73,9 @@ N:	Alexandre Esse <alexandre.esse.dev@gmail.com>
 F:	package/kvazaar/
 F:	package/v4l2loopback/
 
+N:	Alexey Roslyakov <alexey.roslyakov@gmail.com>
+F:	package/brcm-patchram-plus
+
 N:	Alistair Francis <alistair.francis@xilinx.com>
 F:	package/xen/
 
diff --git a/package/Config.in b/package/Config.in
index 7bb9471670..254bb540be 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -372,6 +372,7 @@ endmenu
 	source "package/avrdude/Config.in"
 	source "package/bcache-tools/Config.in"
 	source "package/biosdevname/Config.in"
+	source "package/brcm-patchram-plus/Config.in"
 	source "package/cbootimage/Config.in"
 	source "package/cc-tool/Config.in"
 	source "package/cdrkit/Config.in"
diff --git a/package/brcm-patchram-plus/Config.in b/package/brcm-patchram-plus/Config.in
new file mode 100644
index 0000000000..f7df21d2b2
--- /dev/null
+++ b/package/brcm-patchram-plus/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_BRCM_PATCHRAM_PLUS
+	bool "brcm-patchram-plus"
+	help
+		Utility's to configure and test Broadcom Bluetooth chips on Linux.
+
+		https://code.google.com/archive/p/broadcom-bluetooth/
diff --git a/package/brcm-patchram-plus/brcm-patchram-plus.hash b/package/brcm-patchram-plus/brcm-patchram-plus.hash
new file mode 100644
index 0000000000..2ecb1d72bc
--- /dev/null
+++ b/package/brcm-patchram-plus/brcm-patchram-plus.hash
@@ -0,0 +1,2 @@
+locally computed hash
+sha256	b80ea97f6ab96b68a54c7ae855c43544dcdfee501b4741de8fdfebe1c322ba53 brcm-patchram-plus_0.1.1.tar.gz
diff --git a/package/brcm-patchram-plus/brcm-patchram-plus.mk b/package/brcm-patchram-plus/brcm-patchram-plus.mk
new file mode 100644
index 0000000000..903910db71
--- /dev/null
+++ b/package/brcm-patchram-plus/brcm-patchram-plus.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+# brcm_patchram_plus tool
+#
+################################################################################
+
+BRCM_PATCHRAM_PLUS_VERSION = 0.1.1
+BRCM_PATCHRAM_PLUS_SOURCE = brcm-patchram-plus_$(BRCM_PATCHRAM_PLUS_VERSION).tar.gz
+BRCM_PATCHRAM_PLUS_SITE = https://launchpad.net/ubuntu/+archive/primary/+files
+BRCM_PATCHRAM_PLUS_LICENSE = Apache-2.0
+
+define BRCM_PATCHRAM_PLUS_BUILD_CMDS
+	$(TARGET_CC) -o $(@D)/brcm_patchram_plus $(@D)/brcm_patchram_plus.c
+endef
+
+define BRCM_PATCHRAM_PLUS_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/brcm_patchram_plus $(TARGET_DIR)/usr/bin/brcm_patchram_plus
+endef
+
+$(eval $(generic-package))
-- 
2.13.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] brcm-patchram-plus: new package
  2017-07-21 14:45 [Buildroot] [PATCH 1/1] brcm-patchram-plus: new package Alexey Roslyakov
@ 2017-07-22 13:25 ` Thomas Petazzoni
  2017-07-22 19:34   ` Arnout Vandecappelle
  2017-07-28  6:39   ` Alexey Roslyakov
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-07-22 13:25 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 21 Jul 2017 21:45:20 +0700, Alexey Roslyakov wrote:
> Many of Broadcom BCM43XX WiFi/Bluetooth combo chips have pretty tricky initialization.
> Broadcom patchram utility has been released to address the issue.
> 
> Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com>

Thanks for this contribution! See a few comments below.

> diff --git a/DEVELOPERS b/DEVELOPERS
> index 7b7c5ab4e6..45466591da 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -73,6 +73,9 @@ N:	Alexandre Esse <alexandre.esse.dev@gmail.com>
>  F:	package/kvazaar/
>  F:	package/v4l2loopback/
>  
> +N:	Alexey Roslyakov <alexey.roslyakov@gmail.com>
> +F:	package/brcm-patchram-plus

Please end the package path with a /, like all other entries in the
DEVELOPERS file.

> diff --git a/package/brcm-patchram-plus/Config.in b/package/brcm-patchram-plus/Config.in
> new file mode 100644
> index 0000000000..f7df21d2b2
> --- /dev/null
> +++ b/package/brcm-patchram-plus/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_BRCM_PATCHRAM_PLUS
> +	bool "brcm-patchram-plus"
> +	help
> +		Utility's to configure and test Broadcom Bluetooth chips on Linux.
> +
> +		https://code.google.com/archive/p/broadcom-bluetooth/

Indentation for the help text is one tab + two spaces. I would
recommend you to run utils/check-package on your new package to catch
such coding style issues.

> +BRCM_PATCHRAM_PLUS_VERSION = 0.1.1
> +BRCM_PATCHRAM_PLUS_SOURCE = brcm-patchram-plus_$(BRCM_PATCHRAM_PLUS_VERSION).tar.gz
> +BRCM_PATCHRAM_PLUS_SITE = https://launchpad.net/ubuntu/+archive/primary/+files

Perhaps using the git repository at
https://chromium.googlesource.com/chromiumos/third_party/broadcom would
be a more "official" upstream ?

> +define BRCM_PATCHRAM_PLUS_BUILD_CMDS
> +	$(TARGET_CC) -o $(@D)/brcm_patchram_plus $(@D)/brcm_patchram_plus.c
> +endef
> +
> +define BRCM_PATCHRAM_PLUS_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/brcm_patchram_plus $(TARGET_DIR)/usr/bin/brcm_patchram_plus
> +endef

What about using the Makefile that comes inside the package ? At least
in the Git repository I pointed to, there is a Makefile that seems
suitable.

Thanks!

Thoma
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] brcm-patchram-plus: new package
  2017-07-22 13:25 ` Thomas Petazzoni
@ 2017-07-22 19:34   ` Arnout Vandecappelle
  2017-07-28  6:39   ` Alexey Roslyakov
  1 sibling, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2017-07-22 19:34 UTC (permalink / raw)
  To: buildroot



On 22-07-17 15:25, Thomas Petazzoni wrote:
> Hello,
> 
> On Fri, 21 Jul 2017 21:45:20 +0700, Alexey Roslyakov wrote:
[snip]
>> +config BR2_PACKAGE_BRCM_PATCHRAM_PLUS
>> +	bool "brcm-patchram-plus"
>> +	help
>> +		Utility's to configure and test Broadcom Bluetooth chips on Linux.
                Utilities

 As I understand it, recent kernels should be able to load the firmware directly
from the driver, and recent bluez should be able to issue the other HCI
commands. Is that correct or not?

>> +
>> +		https://code.google.com/archive/p/broadcom-bluetooth/
> 
> Indentation for the help text is one tab + two spaces. I would
> recommend you to run utils/check-package on your new package to catch
> such coding style issues.
> 
>> +BRCM_PATCHRAM_PLUS_VERSION = 0.1.1
>> +BRCM_PATCHRAM_PLUS_SOURCE = brcm-patchram-plus_$(BRCM_PATCHRAM_PLUS_VERSION).tar.gz
>> +BRCM_PATCHRAM_PLUS_SITE = https://launchpad.net/ubuntu/+archive/primary/+files
> 
> Perhaps using the git repository at
> https://chromium.googlesource.com/chromiumos/third_party/broadcom would
> be a more "official" upstream ?

 Indeed, that's what's used by openembedded. It also has an additional feature
--enable_bt_rfkill.

 There is also https://github.com/MarkMendelsohn/brcm_patchram - certainly less
official, but possibly better maintained. Well, it doesn't have --enable_bt_rfkill.


 Regards,
 Arnout

>> +define BRCM_PATCHRAM_PLUS_BUILD_CMDS
>> +	$(TARGET_CC) -o $(@D)/brcm_patchram_plus $(@D)/brcm_patchram_plus.c
>> +endef
>> +
>> +define BRCM_PATCHRAM_PLUS_INSTALL_TARGET_CMDS
>> +	$(INSTALL) -D -m 0755 $(@D)/brcm_patchram_plus $(TARGET_DIR)/usr/bin/brcm_patchram_plus
>> +endef
> 
> What about using the Makefile that comes inside the package ? At least
> in the Git repository I pointed to, there is a Makefile that seems
> suitable.
> 
> Thanks!
> 
> Thoma
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] brcm-patchram-plus: new package
  2017-07-22 13:25 ` Thomas Petazzoni
  2017-07-22 19:34   ` Arnout Vandecappelle
@ 2017-07-28  6:39   ` Alexey Roslyakov
  1 sibling, 0 replies; 4+ messages in thread
From: Alexey Roslyakov @ 2017-07-28  6:39 UTC (permalink / raw)
  To: buildroot

Thomas,
thank you for your suggestions.
Actually, it was confusing me (what to use as upstream) and I wished to
write my concerns in the cover letter. But forgot to write it.

I'll send updated patch later today.

On 22 July 2017 at 20:25, Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:

> Hello,
>
> On Fri, 21 Jul 2017 21:45:20 +0700, Alexey Roslyakov wrote:
> > Many of Broadcom BCM43XX WiFi/Bluetooth combo chips have pretty tricky
> initialization.
> > Broadcom patchram utility has been released to address the issue.
> >
> > Signed-off-by: Alexey Roslyakov <alexey.roslyakov@gmail.com>
>
> Thanks for this contribution! See a few comments below.
>
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 7b7c5ab4e6..45466591da 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -73,6 +73,9 @@ N:  Alexandre Esse <alexandre.esse.dev@gmail.com>
> >  F:   package/kvazaar/
> >  F:   package/v4l2loopback/
> >
> > +N:   Alexey Roslyakov <alexey.roslyakov@gmail.com>
> > +F:   package/brcm-patchram-plus
>
> Please end the package path with a /, like all other entries in the
> DEVELOPERS file.
>
> > diff --git a/package/brcm-patchram-plus/Config.in
> b/package/brcm-patchram-plus/Config.in
> > new file mode 100644
> > index 0000000000..f7df21d2b2
> > --- /dev/null
> > +++ b/package/brcm-patchram-plus/Config.in
> > @@ -0,0 +1,6 @@
> > +config BR2_PACKAGE_BRCM_PATCHRAM_PLUS
> > +     bool "brcm-patchram-plus"
> > +     help
> > +             Utility's to configure and test Broadcom Bluetooth chips
> on Linux.
> > +
> > +             https://code.google.com/archive/p/broadcom-bluetooth/
>
> Indentation for the help text is one tab + two spaces. I would
> recommend you to run utils/check-package on your new package to catch
> such coding style issues.
>
> > +BRCM_PATCHRAM_PLUS_VERSION = 0.1.1
> > +BRCM_PATCHRAM_PLUS_SOURCE = brcm-patchram-plus_$(BRCM_
> PATCHRAM_PLUS_VERSION).tar.gz
> > +BRCM_PATCHRAM_PLUS_SITE = https://launchpad.net/ubuntu/+
> archive/primary/+files
>
> Perhaps using the git repository at
> https://chromium.googlesource.com/chromiumos/third_party/broadcom would
> be a more "official" upstream ?
>
> > +define BRCM_PATCHRAM_PLUS_BUILD_CMDS
> > +     $(TARGET_CC) -o $(@D)/brcm_patchram_plus $(@D)/brcm_patchram_plus.c
> > +endef
> > +
> > +define BRCM_PATCHRAM_PLUS_INSTALL_TARGET_CMDS
> > +     $(INSTALL) -D -m 0755 $(@D)/brcm_patchram_plus
> $(TARGET_DIR)/usr/bin/brcm_patchram_plus
> > +endef
>
> What about using the Makefile that comes inside the package ? At least
> in the Git repository I pointed to, there is a Makefile that seems
> suitable.
>
> Thanks!
>
> Thoma
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>



-- 
With best regards,
  Alexey Roslyakov
Email: alexey.roslyakov at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170728/a1e4dd26/attachment.html>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-28  6:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-21 14:45 [Buildroot] [PATCH 1/1] brcm-patchram-plus: new package Alexey Roslyakov
2017-07-22 13:25 ` Thomas Petazzoni
2017-07-22 19:34   ` Arnout Vandecappelle
2017-07-28  6:39   ` Alexey Roslyakov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.