* [Buildroot] [PATCH 1/1] package/python-attrs: depends on python3
@ 2021-09-24 17:00 Asaf Kahlon
2021-09-25 16:33 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Asaf Kahlon @ 2021-09-24 17:00 UTC (permalink / raw)
To: buildroot; +Cc: Thomas Petazzoni, Asaf Kahlon
python-attrs contains a file with API for python 3.6+.
Although we can make a "tweak" and remove this specific file
for python2, we prefer to make this package available only for
python3, because the day this package (and many others) will drop
support for python2 is probably very close.
In addition, update python-attrs recursive dependencies to
depend on python3 too (python-automat is the only one left).
Fixes:
- http://autobuild.buildroot.net/results/aa6/aa6889bc254eaa93adb4fc1a71bcee9f2f23cb33/
Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
package/python-attrs/Config.in | 1 +
package/python-automat/Config.in | 1 +
2 files changed, 2 insertions(+)
diff --git a/package/python-attrs/Config.in b/package/python-attrs/Config.in
index fb0ab248fa..b658d20ec9 100644
--- a/package/python-attrs/Config.in
+++ b/package/python-attrs/Config.in
@@ -1,4 +1,5 @@
config BR2_PACKAGE_PYTHON_ATTRS
+ depends on BR2_PACKAGE_PYTHON3
bool "python-attrs"
help
attrs is the Python package that will bring back the joy of
diff --git a/package/python-automat/Config.in b/package/python-automat/Config.in
index ee02d22b5b..9d22276c2c 100644
--- a/package/python-automat/Config.in
+++ b/package/python-automat/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_PYTHON_AUTOMAT
bool "python-automat"
+ depends on BR2_PACKAGE_PYTHON3 # python-attrs
select BR2_PACKAGE_PYTHON_ATTRS # runtime
select BR2_PACKAGE_PYTHON_SIX # runtime
help
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-attrs: depends on python3
2021-09-24 17:00 [Buildroot] [PATCH 1/1] package/python-attrs: depends on python3 Asaf Kahlon
@ 2021-09-25 16:33 ` Yann E. MORIN
2021-09-26 12:55 ` Romain Naour
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2021-09-25 16:33 UTC (permalink / raw)
To: Asaf Kahlon; +Cc: Thomas Petazzoni, buildroot
Asaf, All,
On 2021-09-24 20:00 +0300, Asaf Kahlon spake thusly:
> python-attrs contains a file with API for python 3.6+.
> Although we can make a "tweak" and remove this specific file
> for python2, we prefer to make this package available only for
> python3, because the day this package (and many others) will drop
> support for python2 is probably very close.
>
> In addition, update python-attrs recursive dependencies to
> depend on python3 too (python-automat is the only one left).
>
> Fixes:
> - http://autobuild.buildroot.net/results/aa6/aa6889bc254eaa93adb4fc1a71bcee9f2f23cb33/
>
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
> package/python-attrs/Config.in | 1 +
> package/python-automat/Config.in | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/package/python-attrs/Config.in b/package/python-attrs/Config.in
> index fb0ab248fa..b658d20ec9 100644
> --- a/package/python-attrs/Config.in
> +++ b/package/python-attrs/Config.in
> @@ -1,4 +1,5 @@
> config BR2_PACKAGE_PYTHON_ATTRS
> + depends on BR2_PACKAGE_PYTHON3
$ make check-package
package/python-attrs/Config.in:3: attributes order: type, default,
depends on, select, help (http://nightly.buildroot.org/#_config_files)
Applied to master with the above fixed, thanks.
Regards,
Yann E. MORIN.
> bool "python-attrs"
> help
> attrs is the Python package that will bring back the joy of
> diff --git a/package/python-automat/Config.in b/package/python-automat/Config.in
> index ee02d22b5b..9d22276c2c 100644
> --- a/package/python-automat/Config.in
> +++ b/package/python-automat/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_PYTHON_AUTOMAT
> bool "python-automat"
> + depends on BR2_PACKAGE_PYTHON3 # python-attrs
> select BR2_PACKAGE_PYTHON_ATTRS # runtime
> select BR2_PACKAGE_PYTHON_SIX # runtime
> help
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-attrs: depends on python3
2021-09-25 16:33 ` Yann E. MORIN
@ 2021-09-26 12:55 ` Romain Naour
2021-09-26 13:11 ` Asaf Kahlon
0 siblings, 1 reply; 4+ messages in thread
From: Romain Naour @ 2021-09-26 12:55 UTC (permalink / raw)
To: Yann E. MORIN, Asaf Kahlon; +Cc: Thomas Petazzoni, buildroot
Asaf, All,
Le 25/09/2021 à 18:33, Yann E. MORIN a écrit :
> Asaf, All,
>
> On 2021-09-24 20:00 +0300, Asaf Kahlon spake thusly:
>> python-attrs contains a file with API for python 3.6+.
>> Although we can make a "tweak" and remove this specific file
>> for python2, we prefer to make this package available only for
>> python3, because the day this package (and many others) will drop
>> support for python2 is probably very close.
>>
>> In addition, update python-attrs recursive dependencies to
>> depend on python3 too (python-automat is the only one left).
Please Asaf, take care of python tests in the Buildroot testsuite.
Since python-attrs is now python3 only we can remove (at least) two tests:
TestPythonPy2Attrs
TestPythonPy2Automat
Best regards,
Romain
>>
>> Fixes:
>> - http://autobuild.buildroot.net/results/aa6/aa6889bc254eaa93adb4fc1a71bcee9f2f23cb33/
>>
>> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
>> ---
>> package/python-attrs/Config.in | 1 +
>> package/python-automat/Config.in | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/package/python-attrs/Config.in b/package/python-attrs/Config.in
>> index fb0ab248fa..b658d20ec9 100644
>> --- a/package/python-attrs/Config.in
>> +++ b/package/python-attrs/Config.in
>> @@ -1,4 +1,5 @@
>> config BR2_PACKAGE_PYTHON_ATTRS
>> + depends on BR2_PACKAGE_PYTHON3
>
> $ make check-package
> package/python-attrs/Config.in:3: attributes order: type, default,
> depends on, select, help (http://nightly.buildroot.org/#_config_files)
>
> Applied to master with the above fixed, thanks.
>
> Regards,
> Yann E. MORIN.
>
>> bool "python-attrs"
>> help
>> attrs is the Python package that will bring back the joy of
>> diff --git a/package/python-automat/Config.in b/package/python-automat/Config.in
>> index ee02d22b5b..9d22276c2c 100644
>> --- a/package/python-automat/Config.in
>> +++ b/package/python-automat/Config.in
>> @@ -1,5 +1,6 @@
>> config BR2_PACKAGE_PYTHON_AUTOMAT
>> bool "python-automat"
>> + depends on BR2_PACKAGE_PYTHON3 # python-attrs
>> select BR2_PACKAGE_PYTHON_ATTRS # runtime
>> select BR2_PACKAGE_PYTHON_SIX # runtime
>> help
>> --
>> 2.30.2
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@lists.buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-attrs: depends on python3
2021-09-26 12:55 ` Romain Naour
@ 2021-09-26 13:11 ` Asaf Kahlon
0 siblings, 0 replies; 4+ messages in thread
From: Asaf Kahlon @ 2021-09-26 13:11 UTC (permalink / raw)
To: Romain Naour; +Cc: Yann E. MORIN, Thomas Petazzoni, buildroot
Ramain,
On Sun, Sep 26, 2021 at 3:55 PM Romain Naour <romain.naour@gmail.com> wrote:
>
> Asaf, All,
>
> Le 25/09/2021 à 18:33, Yann E. MORIN a écrit :
> > Asaf, All,
> >
> > On 2021-09-24 20:00 +0300, Asaf Kahlon spake thusly:
> >> python-attrs contains a file with API for python 3.6+.
> >> Although we can make a "tweak" and remove this specific file
> >> for python2, we prefer to make this package available only for
> >> python3, because the day this package (and many others) will drop
> >> support for python2 is probably very close.
> >>
> >> In addition, update python-attrs recursive dependencies to
> >> depend on python3 too (python-automat is the only one left).
>
> Please Asaf, take care of python tests in the Buildroot testsuite.
>
> Since python-attrs is now python3 only we can remove (at least) two tests:
>
> TestPythonPy2Attrs
> TestPythonPy2Automat
You're right, thanks.
I'll take a look and send a proper patch.
>
> Best regards,
> Romain
>
>
> >>
> >> Fixes:
> >> - http://autobuild.buildroot.net/results/aa6/aa6889bc254eaa93adb4fc1a71bcee9f2f23cb33/
> >>
> >> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> >> ---
> >> package/python-attrs/Config.in | 1 +
> >> package/python-automat/Config.in | 1 +
> >> 2 files changed, 2 insertions(+)
> >>
> >> diff --git a/package/python-attrs/Config.in b/package/python-attrs/Config.in
> >> index fb0ab248fa..b658d20ec9 100644
> >> --- a/package/python-attrs/Config.in
> >> +++ b/package/python-attrs/Config.in
> >> @@ -1,4 +1,5 @@
> >> config BR2_PACKAGE_PYTHON_ATTRS
> >> + depends on BR2_PACKAGE_PYTHON3
> >
> > $ make check-package
> > package/python-attrs/Config.in:3: attributes order: type, default,
> > depends on, select, help (http://nightly.buildroot.org/#_config_files)
> >
> > Applied to master with the above fixed, thanks.
> >
> > Regards,
> > Yann E. MORIN.
> >
> >> bool "python-attrs"
> >> help
> >> attrs is the Python package that will bring back the joy of
> >> diff --git a/package/python-automat/Config.in b/package/python-automat/Config.in
> >> index ee02d22b5b..9d22276c2c 100644
> >> --- a/package/python-automat/Config.in
> >> +++ b/package/python-automat/Config.in
> >> @@ -1,5 +1,6 @@
> >> config BR2_PACKAGE_PYTHON_AUTOMAT
> >> bool "python-automat"
> >> + depends on BR2_PACKAGE_PYTHON3 # python-attrs
> >> select BR2_PACKAGE_PYTHON_ATTRS # runtime
> >> select BR2_PACKAGE_PYTHON_SIX # runtime
> >> help
> >> --
> >> 2.30.2
> >>
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot@lists.buildroot.org
> >> https://lists.buildroot.org/mailman/listinfo/buildroot
> >
>
Thanks,
Asaf
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-26 13:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 17:00 [Buildroot] [PATCH 1/1] package/python-attrs: depends on python3 Asaf Kahlon
2021-09-25 16:33 ` Yann E. MORIN
2021-09-26 12:55 ` Romain Naour
2021-09-26 13:11 ` Asaf Kahlon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.