All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
@ 2018-04-09 18:04 Asaf Kahlon
  2018-04-09 19:01 ` Thomas Petazzoni
  2018-10-20 18:54 ` Thomas Petazzoni
  0 siblings, 2 replies; 14+ messages in thread
From: Asaf Kahlon @ 2018-04-09 18:04 UTC (permalink / raw)
  To: buildroot

host-package that is able to shorten the load time of entry_points declared
in setup.py of python packages.

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
 DEVELOPERS                                         |  1 +
 package/Config.in.host                             |  1 +
 package/python-fastentrypoints/Config.in.host      |  6 ++++++
 .../python-fastentrypoints.hash                    |  4 ++++
 .../python-fastentrypoints.mk                      | 14 ++++++++++++++
 5 files changed, 26 insertions(+)
 create mode 100644 package/python-fastentrypoints/Config.in.host
 create mode 100644 package/python-fastentrypoints/python-fastentrypoints.hash
 create mode 100644 package/python-fastentrypoints/python-fastentrypoints.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index b797087191..ac0bab8c47 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -189,6 +189,7 @@ F:	package/sqlcipher/
 F:	package/stress/
 
 N:	Asaf Kahlon <asafka7@gmail.com>
+F:	package/python-fastentrypoints/
 F:	package/python-jsonmodels/
 F:	package/python-yieldfrom/
 
diff --git a/package/Config.in.host b/package/Config.in.host
index 563a277795..8cf8106895 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -42,6 +42,7 @@ menu "Host utilities"
 	source "package/pkgconf/Config.in.host"
 	source "package/pru-software-support/Config.in.host"
 	source "package/pwgen/Config.in.host"
+	source "package/python-fastentrypoints/Config.in.host"
 	source "package/python-lxml/Config.in.host"
 	source "package/python-six/Config.in.host"
 	source "package/python-xlrd/Config.in.host"
diff --git a/package/python-fastentrypoints/Config.in.host b/package/python-fastentrypoints/Config.in.host
new file mode 100644
index 0000000000..91605509ab
--- /dev/null
+++ b/package/python-fastentrypoints/Config.in.host
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_HOST_PYTHON_FASTENTRYPOINTS
+	bool "host python-fastentrypoints"
+	help
+	  Makes entry_points specified in setup.py load more quickly.
+
+	  https://github.com/ninjaaron/fast-entry_points
diff --git a/package/python-fastentrypoints/python-fastentrypoints.hash b/package/python-fastentrypoints/python-fastentrypoints.hash
new file mode 100644
index 0000000000..84e9b78287
--- /dev/null
+++ b/package/python-fastentrypoints/python-fastentrypoints.hash
@@ -0,0 +1,4 @@
+# md5 from https://pypi.python.org/pypi/fastentrypoints/json, sha256 locally computed
+md5	9bd2a34697eb8279d87e7b927f4f7e85  fastentrypoints-0.10.tar.gz
+sha256	ed418146ed87230694ec2d8890b9b3e2967e95d857e5ce933cafecb1067cca82  fastentrypoints-0.10.tar.gz
+sha256	2da210da31c033faa270503884a3ac9058874543e6fdd0b094000720bf2ffb66  fastentrypoints.py
diff --git a/package/python-fastentrypoints/python-fastentrypoints.mk b/package/python-fastentrypoints/python-fastentrypoints.mk
new file mode 100644
index 0000000000..c4eb3e862f
--- /dev/null
+++ b/package/python-fastentrypoints/python-fastentrypoints.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-fastentrypoints
+#
+################################################################################
+
+PYTHON_FASTENTRYPOINTS_VERSION = 0.10
+PYTHON_FASTENTRYPOINTS_SOURCE = fastentrypoints-$(PYTHON_FASTENTRYPOINTS_VERSION).tar.gz
+PYTHON_FASTENTRYPOINTS_SITE = https://pypi.python.org/packages/e8/c8/c2902c9c9da43d8be8c75a730f15f0c51933c42c39b91d1d7b605a88e907
+PYTHON_FASTENTRYPOINTS_SETUP_TYPE = setuptools
+PYTHON_FASTENTRYPOINTS_LICENSE = BSD-2-Clause
+PYTHON_FASTENTRYPOINTS_LICENSE_FILES = fastentrypoints.py
+
+$(eval $(host-python-package))
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-09 18:04 [Buildroot] [PATCH 1/1] python-fastentrypoints: new package Asaf Kahlon
@ 2018-04-09 19:01 ` Thomas Petazzoni
  2018-04-09 19:47   ` Asaf Kahlon
  2018-10-20 18:54 ` Thomas Petazzoni
  1 sibling, 1 reply; 14+ messages in thread
From: Thomas Petazzoni @ 2018-04-09 19:01 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon,  9 Apr 2018 21:04:03 +0300, Asaf Kahlon wrote:
> host-package that is able to shorten the load time of entry_points declared
> in setup.py of python packages.
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>

Thanks for this new version. Could you give some details on how you're
using this host package ? I.e what you are doing with it exactly ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-09 19:01 ` Thomas Petazzoni
@ 2018-04-09 19:47   ` Asaf Kahlon
  2018-04-10 20:02     ` Asaf Kahlon
  0 siblings, 1 reply; 14+ messages in thread
From: Asaf Kahlon @ 2018-04-09 19:47 UTC (permalink / raw)
  To: buildroot

Yes, of course.

After the compilation of this package, you'll have an executable called
fastep under $(HOST_DIR)/usr/bin.
Then you can run fastep on a directory of a python package, and it'll speed
up the console_scripts declared on your setup.py.
What it really does is copying fastentrypoints,py to the directory, adding
it to MANIFEST.in, and adding an import on setup.py, which is actually a
monkey-patch.

It can be very useful on systems with limited resources where importing
pkg_resources can take a long time.
If you want, you can even take it further and write pkg-fastep.mk. Then you
can use it for the relevant python packages. It will add the needed
dependency and run fastep on the package directory.

Asaf.

On Mon, Apr 9, 2018 at 10:01 PM, Thomas Petazzoni <
thomas.petazzoni@bootlin.com> wrote:

> Hello,
>
> On Mon,  9 Apr 2018 21:04:03 +0300, Asaf Kahlon wrote:
> > host-package that is able to shorten the load time of entry_points
> declared
> > in setup.py of python packages.
> >
> > Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
>
> Thanks for this new version. Could you give some details on how you're
> using this host package ? I.e what you are doing with it exactly ?
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180409/231ac644/attachment.html>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-09 19:47   ` Asaf Kahlon
@ 2018-04-10 20:02     ` Asaf Kahlon
  2018-04-28 13:09       ` Thomas Petazzoni
  0 siblings, 1 reply; 14+ messages in thread
From: Asaf Kahlon @ 2018-04-10 20:02 UTC (permalink / raw)
  To: buildroot

Hello,

Is there anything new with my patch? Should I add/change something?

Thanks,
Asaf.

On Mon, Apr 9, 2018 at 10:47 PM, Asaf Kahlon <asafka7@gmail.com> wrote:

> Yes, of course.
>
> After the compilation of this package, you'll have an executable called
> fastep under $(HOST_DIR)/usr/bin.
> Then you can run fastep on a directory of a python package, and it'll
> speed up the console_scripts declared on your setup.py.
> What it really does is copying fastentrypoints,py to the directory, adding
> it to MANIFEST.in, and adding an import on setup.py, which is actually a
> monkey-patch.
>
> It can be very useful on systems with limited resources where importing
> pkg_resources can take a long time.
> If you want, you can even take it further and write pkg-fastep.mk. Then
> you can use it for the relevant python packages. It will add the needed
> dependency and run fastep on the package directory.
>
> Asaf.
>
> On Mon, Apr 9, 2018 at 10:01 PM, Thomas Petazzoni <
> thomas.petazzoni at bootlin.com> wrote:
>
>> Hello,
>>
>> On Mon,  9 Apr 2018 21:04:03 +0300, Asaf Kahlon wrote:
>> > host-package that is able to shorten the load time of entry_points
>> declared
>> > in setup.py of python packages.
>> >
>> > Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
>>
>> Thanks for this new version. Could you give some details on how you're
>> using this host package ? I.e what you are doing with it exactly ?
>>
>> Thanks,
>>
>> Thomas
>> --
>> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
>> Embedded Linux and Kernel engineering
>> https://bootlin.com
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180410/d91ba32e/attachment.html>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-10 20:02     ` Asaf Kahlon
@ 2018-04-28 13:09       ` Thomas Petazzoni
  2018-04-28 18:58         ` Yegor Yefremov
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Petazzoni @ 2018-04-28 13:09 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 10 Apr 2018 23:02:12 +0300, Asaf Kahlon wrote:

> Is there anything new with my patch? Should I add/change something?

I'd like to hear from Yegor about this patch. Yegor, could you comment
on this patch ?

Thanks!!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-28 13:09       ` Thomas Petazzoni
@ 2018-04-28 18:58         ` Yegor Yefremov
  2018-07-14  8:09           ` Asaf Kahlon
  0 siblings, 1 reply; 14+ messages in thread
From: Yegor Yefremov @ 2018-04-28 18:58 UTC (permalink / raw)
  To: buildroot

On Sat, Apr 28, 2018 at 3:09 PM, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> Hello,
>
> On Tue, 10 Apr 2018 23:02:12 +0300, Asaf Kahlon wrote:
>
>> Is there anything new with my patch? Should I add/change something?
>
> I'd like to hear from Yegor about this patch. Yegor, could you comment
> on this patch ?

I'm OK with this patch. This package could be helpful for the
python-crossbar testing as it takes ages to start crossbar script.

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

Yegor

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-28 18:58         ` Yegor Yefremov
@ 2018-07-14  8:09           ` Asaf Kahlon
  0 siblings, 0 replies; 14+ messages in thread
From: Asaf Kahlon @ 2018-07-14  8:09 UTC (permalink / raw)
  To: buildroot

ping

On Sat, Apr 28, 2018 at 9:58 PM Yegor Yefremov <yegorslists@googlemail.com>
wrote:

> On Sat, Apr 28, 2018 at 3:09 PM, Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> > Hello,
> >
> > On Tue, 10 Apr 2018 23:02:12 +0300, Asaf Kahlon wrote:
> >
> >> Is there anything new with my patch? Should I add/change something?
> >
> > I'd like to hear from Yegor about this patch. Yegor, could you comment
> > on this patch ?
>
> I'm OK with this patch. This package could be helpful for the
> python-crossbar testing as it takes ages to start crossbar script.
>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> Yegor
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180714/40f8bd4f/attachment.html>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-09 18:04 [Buildroot] [PATCH 1/1] python-fastentrypoints: new package Asaf Kahlon
  2018-04-09 19:01 ` Thomas Petazzoni
@ 2018-10-20 18:54 ` Thomas Petazzoni
  1 sibling, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2018-10-20 18:54 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon,  9 Apr 2018 21:04:03 +0300, Asaf Kahlon wrote:
> host-package that is able to shorten the load time of entry_points declared
> in setup.py of python packages.
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
>  DEVELOPERS                                         |  1 +
>  package/Config.in.host                             |  1 +
>  package/python-fastentrypoints/Config.in.host      |  6 ++++++
>  .../python-fastentrypoints.hash                    |  4 ++++
>  .../python-fastentrypoints.mk                      | 14 ++++++++++++++
>  5 files changed, 26 insertions(+)
>  create mode 100644 package/python-fastentrypoints/Config.in.host
>  create mode 100644 package/python-fastentrypoints/python-fastentrypoints.hash
>  create mode 100644 package/python-fastentrypoints/python-fastentrypoints.mk

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-09 16:47       ` Yegor Yefremov
@ 2018-04-09 18:02         ` Asaf Kahlon
  0 siblings, 0 replies; 14+ messages in thread
From: Asaf Kahlon @ 2018-04-09 18:02 UTC (permalink / raw)
  To: buildroot

OK, I'll keep an eye on this package and when it updates I'll send a patch.
Meantime, I'll put fastentrypoints.py as license file.

Thanks!

On Mon, Apr 9, 2018 at 7:47 PM, Yegor Yefremov <yegorslists@googlemail.com>
wrote:

> Hi Asaf,
>
> On Mon, Apr 9, 2018 at 5:54 PM, Asaf Kahlon <asafka7@gmail.com> wrote:
> > Yegor, Thomas,
> >
> > Indeed this is a host package. After you compile it, it can be used to
> speed
> > up entry points.
> > I now see Buildroot uses Config.in.host for this kind of packages, so I
> can
> > fix this on a new patch.
> >
> > About the license - I saw the license file on the Github repository, but
> > this license is not provided on the tar.gz archive downloaded from pypi,
> so
> > how can I add the licence information?
>
> Just use fastentrypoints.py as license file. I've asked maintainer to
> add license file to the PyPI's archive. So perhaps the new version
> would already have it.
>
> Yegor
>
> > On Mon, Apr 9, 2018, 10:14 Thomas Petazzoni <
> thomas.petazzoni at bootlin.com>
> > wrote:
> >>
> >> Hello,
> >>
> >> On Sun, 8 Apr 2018 22:59:32 +0200, Yegor Yefremov wrote:
> >>
> >> > On Sun, Apr 8, 2018 at 7:48 PM, Asaf Kahlon <asafka7@gmail.com>
> wrote:
> >> > > host-package that is able to shorten the load time of entry_points
> >> > > declared
> >> > > in setup.py of python packages.
> >> > >
> >> > > Unfortunately, license file was not found.
> >> >
> >> > This comment shouldn't be part of the commit log.
> >>
> >> I disagree, this comment makes sense in a commit log.
> >>
> >>
> >> > > diff --git a/package/python-fastentrypoints/Config.in
> >> > > b/package/python-fastentrypoints/Config.in
> >> > > new file mode 100644
> >> > > index 0000000000..d2c86dbc5e
> >> > > --- /dev/null
> >> > > +++ b/package/python-fastentrypoints/Config.in
> >> > > @@ -0,0 +1,6 @@
> >> > > +config BR2_PACKAGE_PYTHON_FASTENTRYPOINTS
> >> > > +       bool "python-fastentrypoints"
> >> > > +       help
> >> > > +         Makes entry_points specified in setup.py load more
> quickly.
> >> > > +
> >> > > +         https://github.com/ninjaaron/fast-entry_points
> >>
> >> So we have a Config.in option for a target package.
> >>
> >> > > +PYTHON_FASTENTRYPOINTS_VERSION = 0.10
> >> > > +PYTHON_FASTENTRYPOINTS_SOURCE =
> >> > > fastentrypoints-$(PYTHON_FASTENTRYPOINTS_VERSION).tar.gz
> >> > > +PYTHON_FASTENTRYPOINTS_SITE =
> >> > > https://pypi.python.org/packages/e8/c8/
> c2902c9c9da43d8be8c75a730f15f0c51933c42c39b91d1d7b605a88e907
> >> > > +PYTHON_FASTENTRYPOINTS_SETUP_TYPE = setuptools
> >> >
> >> > The license file can be found on github and seems to be BSD-2c [1]
> >> >
> >> > With these changes applied you can add my: Reviewed-by: Yegor Yefremov
> >> > <yegorslists@googlemail.com>
> >> >
> >> > [1] https://github.com/ninjaaron/fast-entry_points/blob/master/
> LICENSE
> >> >
> >> > Yegor
> >> >
> >> > > +
> >> > > +$(eval $(host-python-package))
> >>
> >> But this is a host only package ?
> >>
> >> I don't see how this can work. Am I missing something ?
> >>
> >> Best regards,
> >>
> >> Thomas
> >> --
> >> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> >> Embedded Linux and Kernel engineering
> >> https://bootlin.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180409/81a46784/attachment.html>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-09 15:54     ` Asaf Kahlon
@ 2018-04-09 16:47       ` Yegor Yefremov
  2018-04-09 18:02         ` Asaf Kahlon
  0 siblings, 1 reply; 14+ messages in thread
From: Yegor Yefremov @ 2018-04-09 16:47 UTC (permalink / raw)
  To: buildroot

Hi Asaf,

On Mon, Apr 9, 2018 at 5:54 PM, Asaf Kahlon <asafka7@gmail.com> wrote:
> Yegor, Thomas,
>
> Indeed this is a host package. After you compile it, it can be used to speed
> up entry points.
> I now see Buildroot uses Config.in.host for this kind of packages, so I can
> fix this on a new patch.
>
> About the license - I saw the license file on the Github repository, but
> this license is not provided on the tar.gz archive downloaded from pypi, so
> how can I add the licence information?

Just use fastentrypoints.py as license file. I've asked maintainer to
add license file to the PyPI's archive. So perhaps the new version
would already have it.

Yegor

> On Mon, Apr 9, 2018, 10:14 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> wrote:
>>
>> Hello,
>>
>> On Sun, 8 Apr 2018 22:59:32 +0200, Yegor Yefremov wrote:
>>
>> > On Sun, Apr 8, 2018 at 7:48 PM, Asaf Kahlon <asafka7@gmail.com> wrote:
>> > > host-package that is able to shorten the load time of entry_points
>> > > declared
>> > > in setup.py of python packages.
>> > >
>> > > Unfortunately, license file was not found.
>> >
>> > This comment shouldn't be part of the commit log.
>>
>> I disagree, this comment makes sense in a commit log.
>>
>>
>> > > diff --git a/package/python-fastentrypoints/Config.in
>> > > b/package/python-fastentrypoints/Config.in
>> > > new file mode 100644
>> > > index 0000000000..d2c86dbc5e
>> > > --- /dev/null
>> > > +++ b/package/python-fastentrypoints/Config.in
>> > > @@ -0,0 +1,6 @@
>> > > +config BR2_PACKAGE_PYTHON_FASTENTRYPOINTS
>> > > +       bool "python-fastentrypoints"
>> > > +       help
>> > > +         Makes entry_points specified in setup.py load more quickly.
>> > > +
>> > > +         https://github.com/ninjaaron/fast-entry_points
>>
>> So we have a Config.in option for a target package.
>>
>> > > +PYTHON_FASTENTRYPOINTS_VERSION = 0.10
>> > > +PYTHON_FASTENTRYPOINTS_SOURCE =
>> > > fastentrypoints-$(PYTHON_FASTENTRYPOINTS_VERSION).tar.gz
>> > > +PYTHON_FASTENTRYPOINTS_SITE =
>> > > https://pypi.python.org/packages/e8/c8/c2902c9c9da43d8be8c75a730f15f0c51933c42c39b91d1d7b605a88e907
>> > > +PYTHON_FASTENTRYPOINTS_SETUP_TYPE = setuptools
>> >
>> > The license file can be found on github and seems to be BSD-2c [1]
>> >
>> > With these changes applied you can add my: Reviewed-by: Yegor Yefremov
>> > <yegorslists@googlemail.com>
>> >
>> > [1] https://github.com/ninjaaron/fast-entry_points/blob/master/LICENSE
>> >
>> > Yegor
>> >
>> > > +
>> > > +$(eval $(host-python-package))
>>
>> But this is a host only package ?
>>
>> I don't see how this can work. Am I missing something ?
>>
>> Best regards,
>>
>> Thomas
>> --
>> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
>> Embedded Linux and Kernel engineering
>> https://bootlin.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-09  7:14   ` Thomas Petazzoni
@ 2018-04-09 15:54     ` Asaf Kahlon
  2018-04-09 16:47       ` Yegor Yefremov
  0 siblings, 1 reply; 14+ messages in thread
From: Asaf Kahlon @ 2018-04-09 15:54 UTC (permalink / raw)
  To: buildroot

Yegor, Thomas,

Indeed this is a host package. After you compile it, it can be used to
speed up entry points.
I now see Buildroot uses Config.in.host for this kind of packages, so I can
fix this on a new patch.

About the license - I saw the license file on the Github repository, but
this license is not provided on the tar.gz archive downloaded from pypi, so
how can I add the licence information?

Regards,
Asaf.

On Mon, Apr 9, 2018, 10:14 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
wrote:

> Hello,
>
> On Sun, 8 Apr 2018 22:59:32 +0200, Yegor Yefremov wrote:
>
> > On Sun, Apr 8, 2018 at 7:48 PM, Asaf Kahlon <asafka7@gmail.com> wrote:
> > > host-package that is able to shorten the load time of entry_points
> declared
> > > in setup.py of python packages.
> > >
> > > Unfortunately, license file was not found.
> >
> > This comment shouldn't be part of the commit log.
>
> I disagree, this comment makes sense in a commit log.
>
>
> > > diff --git a/package/python-fastentrypoints/Config.in
> b/package/python-fastentrypoints/Config.in
> > > new file mode 100644
> > > index 0000000000..d2c86dbc5e
> > > --- /dev/null
> > > +++ b/package/python-fastentrypoints/Config.in
> > > @@ -0,0 +1,6 @@
> > > +config BR2_PACKAGE_PYTHON_FASTENTRYPOINTS
> > > +       bool "python-fastentrypoints"
> > > +       help
> > > +         Makes entry_points specified in setup.py load more quickly.
> > > +
> > > +         https://github.com/ninjaaron/fast-entry_points
>
> So we have a Config.in option for a target package.
>
> > > +PYTHON_FASTENTRYPOINTS_VERSION = 0.10
> > > +PYTHON_FASTENTRYPOINTS_SOURCE =
> fastentrypoints-$(PYTHON_FASTENTRYPOINTS_VERSION).tar.gz
> > > +PYTHON_FASTENTRYPOINTS_SITE =
> https://pypi.python.org/packages/e8/c8/c2902c9c9da43d8be8c75a730f15f0c51933c42c39b91d1d7b605a88e907
> > > +PYTHON_FASTENTRYPOINTS_SETUP_TYPE = setuptools
> >
> > The license file can be found on github and seems to be BSD-2c [1]
> >
> > With these changes applied you can add my: Reviewed-by: Yegor Yefremov
> > <yegorslists@googlemail.com>
> >
> > [1] https://github.com/ninjaaron/fast-entry_points/blob/master/LICENSE
> >
> > Yegor
> >
> > > +
> > > +$(eval $(host-python-package))
>
> But this is a host only package ?
>
> I don't see how this can work. Am I missing something ?
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180409/0bf6f86f/attachment.html>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-08 20:59 ` Yegor Yefremov
@ 2018-04-09  7:14   ` Thomas Petazzoni
  2018-04-09 15:54     ` Asaf Kahlon
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Petazzoni @ 2018-04-09  7:14 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 8 Apr 2018 22:59:32 +0200, Yegor Yefremov wrote:

> On Sun, Apr 8, 2018 at 7:48 PM, Asaf Kahlon <asafka7@gmail.com> wrote:
> > host-package that is able to shorten the load time of entry_points declared
> > in setup.py of python packages.
> >
> > Unfortunately, license file was not found.  
> 
> This comment shouldn't be part of the commit log.

I disagree, this comment makes sense in a commit log.


> > diff --git a/package/python-fastentrypoints/Config.in b/package/python-fastentrypoints/Config.in
> > new file mode 100644
> > index 0000000000..d2c86dbc5e
> > --- /dev/null
> > +++ b/package/python-fastentrypoints/Config.in
> > @@ -0,0 +1,6 @@
> > +config BR2_PACKAGE_PYTHON_FASTENTRYPOINTS
> > +       bool "python-fastentrypoints"
> > +       help
> > +         Makes entry_points specified in setup.py load more quickly.
> > +
> > +         https://github.com/ninjaaron/fast-entry_points

So we have a Config.in option for a target package.

> > +PYTHON_FASTENTRYPOINTS_VERSION = 0.10
> > +PYTHON_FASTENTRYPOINTS_SOURCE = fastentrypoints-$(PYTHON_FASTENTRYPOINTS_VERSION).tar.gz
> > +PYTHON_FASTENTRYPOINTS_SITE = https://pypi.python.org/packages/e8/c8/c2902c9c9da43d8be8c75a730f15f0c51933c42c39b91d1d7b605a88e907
> > +PYTHON_FASTENTRYPOINTS_SETUP_TYPE = setuptools  
> 
> The license file can be found on github and seems to be BSD-2c [1]
> 
> With these changes applied you can add my: Reviewed-by: Yegor Yefremov
> <yegorslists@googlemail.com>
> 
> [1] https://github.com/ninjaaron/fast-entry_points/blob/master/LICENSE
> 
> Yegor
> 
> > +
> > +$(eval $(host-python-package))

But this is a host only package ?

I don't see how this can work. Am I missing something ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
  2018-04-08 17:48 Asaf Kahlon
@ 2018-04-08 20:59 ` Yegor Yefremov
  2018-04-09  7:14   ` Thomas Petazzoni
  0 siblings, 1 reply; 14+ messages in thread
From: Yegor Yefremov @ 2018-04-08 20:59 UTC (permalink / raw)
  To: buildroot

Hi Asaf,

On Sun, Apr 8, 2018 at 7:48 PM, Asaf Kahlon <asafka7@gmail.com> wrote:
> host-package that is able to shorten the load time of entry_points declared
> in setup.py of python packages.
>
> Unfortunately, license file was not found.

This comment shouldn't be part of the commit log.

> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
>  DEVELOPERS                                           |  1 +
>  package/Config.in                                    |  1 +
>  package/python-fastentrypoints/Config.in             |  6 ++++++
>  .../python-fastentrypoints.hash                      |  3 +++
>  .../python-fastentrypoints/python-fastentrypoints.mk | 12 ++++++++++++
>  5 files changed, 23 insertions(+)
>  create mode 100644 package/python-fastentrypoints/Config.in
>  create mode 100644 package/python-fastentrypoints/python-fastentrypoints.hash
>  create mode 100644 package/python-fastentrypoints/python-fastentrypoints.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 10b20c259b..ea33d5e730 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -189,6 +189,7 @@ F:  package/sqlcipher/
>  F:     package/stress/
>
>  N:     Asaf Kahlon <asafka7@gmail.com>
> +F:     package/python-fastentrypoints/
>  F:     package/python-jsonmodels/
>  F:     package/python-yieldfrom/
>
> diff --git a/package/Config.in b/package/Config.in
> index 5e798a4f14..d7e51b203c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -778,6 +778,7 @@ menu "External python modules"
>         source "package/python-engineio/Config.in"
>         source "package/python-enum/Config.in"
>         source "package/python-enum34/Config.in"
> +       source "package/python-fastentrypoints/Config.in"
>         source "package/python-flask/Config.in"
>         source "package/python-flask-cors/Config.in"
>         source "package/python-flask-babel/Config.in"
> diff --git a/package/python-fastentrypoints/Config.in b/package/python-fastentrypoints/Config.in
> new file mode 100644
> index 0000000000..d2c86dbc5e
> --- /dev/null
> +++ b/package/python-fastentrypoints/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_PYTHON_FASTENTRYPOINTS
> +       bool "python-fastentrypoints"
> +       help
> +         Makes entry_points specified in setup.py load more quickly.
> +
> +         https://github.com/ninjaaron/fast-entry_points
> diff --git a/package/python-fastentrypoints/python-fastentrypoints.hash b/package/python-fastentrypoints/python-fastentrypoints.hash
> new file mode 100644
> index 0000000000..da6e2ae9d8
> --- /dev/null
> +++ b/package/python-fastentrypoints/python-fastentrypoints.hash
> @@ -0,0 +1,3 @@
> +# md5 from https://pypi.python.org/pypi/fastentrypoints/json, sha256 locally computed
> +md5    9bd2a34697eb8279d87e7b927f4f7e85  fastentrypoints-0.10.tar.gz
> +sha256 ed418146ed87230694ec2d8890b9b3e2967e95d857e5ce933cafecb1067cca82  fastentrypoints-0.10.tar.gz
> diff --git a/package/python-fastentrypoints/python-fastentrypoints.mk b/package/python-fastentrypoints/python-fastentrypoints.mk
> new file mode 100644
> index 0000000000..455cfe8319
> --- /dev/null
> +++ b/package/python-fastentrypoints/python-fastentrypoints.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# python-fastentrypoints
> +#
> +################################################################################
> +
> +PYTHON_FASTENTRYPOINTS_VERSION = 0.10
> +PYTHON_FASTENTRYPOINTS_SOURCE = fastentrypoints-$(PYTHON_FASTENTRYPOINTS_VERSION).tar.gz
> +PYTHON_FASTENTRYPOINTS_SITE = https://pypi.python.org/packages/e8/c8/c2902c9c9da43d8be8c75a730f15f0c51933c42c39b91d1d7b605a88e907
> +PYTHON_FASTENTRYPOINTS_SETUP_TYPE = setuptools

The license file can be found on github and seems to be BSD-2c [1]

With these changes applied you can add my: Reviewed-by: Yegor Yefremov
<yegorslists@googlemail.com>

[1] https://github.com/ninjaaron/fast-entry_points/blob/master/LICENSE

Yegor

> +
> +$(eval $(host-python-package))
> --
> 2.17.0
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/1] python-fastentrypoints: new package
@ 2018-04-08 17:48 Asaf Kahlon
  2018-04-08 20:59 ` Yegor Yefremov
  0 siblings, 1 reply; 14+ messages in thread
From: Asaf Kahlon @ 2018-04-08 17:48 UTC (permalink / raw)
  To: buildroot

host-package that is able to shorten the load time of entry_points declared
in setup.py of python packages.

Unfortunately, license file was not found.

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
 DEVELOPERS                                           |  1 +
 package/Config.in                                    |  1 +
 package/python-fastentrypoints/Config.in             |  6 ++++++
 .../python-fastentrypoints.hash                      |  3 +++
 .../python-fastentrypoints/python-fastentrypoints.mk | 12 ++++++++++++
 5 files changed, 23 insertions(+)
 create mode 100644 package/python-fastentrypoints/Config.in
 create mode 100644 package/python-fastentrypoints/python-fastentrypoints.hash
 create mode 100644 package/python-fastentrypoints/python-fastentrypoints.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 10b20c259b..ea33d5e730 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -189,6 +189,7 @@ F:	package/sqlcipher/
 F:	package/stress/
 
 N:	Asaf Kahlon <asafka7@gmail.com>
+F:	package/python-fastentrypoints/
 F:	package/python-jsonmodels/
 F:	package/python-yieldfrom/
 
diff --git a/package/Config.in b/package/Config.in
index 5e798a4f14..d7e51b203c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -778,6 +778,7 @@ menu "External python modules"
 	source "package/python-engineio/Config.in"
 	source "package/python-enum/Config.in"
 	source "package/python-enum34/Config.in"
+	source "package/python-fastentrypoints/Config.in"
 	source "package/python-flask/Config.in"
 	source "package/python-flask-cors/Config.in"
 	source "package/python-flask-babel/Config.in"
diff --git a/package/python-fastentrypoints/Config.in b/package/python-fastentrypoints/Config.in
new file mode 100644
index 0000000000..d2c86dbc5e
--- /dev/null
+++ b/package/python-fastentrypoints/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_FASTENTRYPOINTS
+	bool "python-fastentrypoints"
+	help
+	  Makes entry_points specified in setup.py load more quickly.
+
+	  https://github.com/ninjaaron/fast-entry_points
diff --git a/package/python-fastentrypoints/python-fastentrypoints.hash b/package/python-fastentrypoints/python-fastentrypoints.hash
new file mode 100644
index 0000000000..da6e2ae9d8
--- /dev/null
+++ b/package/python-fastentrypoints/python-fastentrypoints.hash
@@ -0,0 +1,3 @@
+# md5 from https://pypi.python.org/pypi/fastentrypoints/json, sha256 locally computed
+md5	9bd2a34697eb8279d87e7b927f4f7e85  fastentrypoints-0.10.tar.gz
+sha256	ed418146ed87230694ec2d8890b9b3e2967e95d857e5ce933cafecb1067cca82  fastentrypoints-0.10.tar.gz
diff --git a/package/python-fastentrypoints/python-fastentrypoints.mk b/package/python-fastentrypoints/python-fastentrypoints.mk
new file mode 100644
index 0000000000..455cfe8319
--- /dev/null
+++ b/package/python-fastentrypoints/python-fastentrypoints.mk
@@ -0,0 +1,12 @@
+################################################################################
+#
+# python-fastentrypoints
+#
+################################################################################
+
+PYTHON_FASTENTRYPOINTS_VERSION = 0.10
+PYTHON_FASTENTRYPOINTS_SOURCE = fastentrypoints-$(PYTHON_FASTENTRYPOINTS_VERSION).tar.gz
+PYTHON_FASTENTRYPOINTS_SITE = https://pypi.python.org/packages/e8/c8/c2902c9c9da43d8be8c75a730f15f0c51933c42c39b91d1d7b605a88e907
+PYTHON_FASTENTRYPOINTS_SETUP_TYPE = setuptools
+
+$(eval $(host-python-package))
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2018-10-20 18:54 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09 18:04 [Buildroot] [PATCH 1/1] python-fastentrypoints: new package Asaf Kahlon
2018-04-09 19:01 ` Thomas Petazzoni
2018-04-09 19:47   ` Asaf Kahlon
2018-04-10 20:02     ` Asaf Kahlon
2018-04-28 13:09       ` Thomas Petazzoni
2018-04-28 18:58         ` Yegor Yefremov
2018-07-14  8:09           ` Asaf Kahlon
2018-10-20 18:54 ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2018-04-08 17:48 Asaf Kahlon
2018-04-08 20:59 ` Yegor Yefremov
2018-04-09  7:14   ` Thomas Petazzoni
2018-04-09 15:54     ` Asaf Kahlon
2018-04-09 16:47       ` Yegor Yefremov
2018-04-09 18:02         ` Asaf Kahlon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.