OpenBMC helper scripts repositories

OpenBMC helper scripts repositories

[Andrew Jeffery]

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

Hello,

I've noticed that we've grown several helper script repositories, with
a mix of intents.

So far we have:

https://github.com/williamspatrick/openbmc-events

and the seemingly more active fork:

https://github.com/geissonator/openbmc-events

Along with something Joel cooked up a while back:

https://github.com/shenki/obmc-ctrl

and some scripts that I've written:

https://github.com/amboar/obmc-scripts/

Is it worth consolidating these efforts? If we do I think the result
should be low friction wrt merging changes, and some hacking should
always be expected if you're going to use the repository. Consolidating
might help avoid duplicate effort.

Cheers,

Andrew

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: OpenBMC helper scripts repositories

[Chris Austen]

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

Mine too... https://github.com/causten/openbmc-tutorials


"openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org> wrote on
10/05/2017 08:55:40 PM:

> From: Andrew Jeffery <andrew@aj.id.au>
> To: OpenBMC <openbmc@lists.ozlabs.org>
> Date: 10/05/2017 08:56 PM
> Subject: OpenBMC helper scripts repositories
> Sent by: "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org>
>
> Hello,
>
> I've noticed that we've grown several helper script repositories, with
> a mix of intents.
>
> So far we have:
>
> https://github.com/williamspatrick/openbmc-events
>
> and the seemingly more active fork:
>
> https://github.com/geissonator/openbmc-events
>
> Along with something Joel cooked up a while back:
>
> https://github.com/shenki/obmc-ctrl
>
> and some scripts that I've written:
>
> https://github.com/amboar/obmc-scripts/
>
> Is it worth consolidating these efforts? If we do I think the result
> should be low friction wrt merging changes, and some hacking should
> always be expected if you're going to use the repository. Consolidating
> might help avoid duplicate effort.
>
> Cheers,
>
> Andrew[attachment "signature.asc" deleted by Chris Austen/Austin/IBM]

[-- Attachment #2: Type: text/html, Size: 2042 bytes --]

Re: OpenBMC helper scripts repositories

[Andrew Jeffery]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

On Thu, 2017-10-05 at 21:52 -0500, Chris Austen wrote:
> Mine too... https://github.com/causten/openbmc-tutorials
> 

That's some handy content! Probably not quite what I'd expect for a
random utils repository, but we should work out what to do with this as
well. Certainly could feature on a website when we get one...

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: OpenBMC helper scripts repositories

[Chris Austen]

[-- Attachment #1: Type: text/plain, Size: 2045 bytes --]




https://github.com/causten/tools/tree/master/obmc  I've also got those
files.  things have evolved and I not kept the error logging or code update
refreshed to any of the new xyz paths.  However, leds.py still can toggle
the LEDS on a system and obmcrequests.py (my library for bmc communication)
can work offline if the data has been captured.

"openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org> wrote on
10/05/2017 09:52:43 PM:

> From: "Chris Austen" <austenc@us.ibm.com>
> To: Andrew Jeffery <andrew@aj.id.au>
> Cc: OpenBMC <openbmc@lists.ozlabs.org>
> Date: 10/05/2017 09:53 PM
> Subject: Re: OpenBMC helper scripts repositories
> Sent by: "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org>
>
> Mine too... https://github.com/causten/openbmc-tutorials
>
>
> "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org>
> wrote on 10/05/2017 08:55:40 PM:
>
> > From: Andrew Jeffery <andrew@aj.id.au>
> > To: OpenBMC <openbmc@lists.ozlabs.org>
> > Date: 10/05/2017 08:56 PM
> > Subject: OpenBMC helper scripts repositories
> > Sent by: "openbmc" <openbmc-bounces
+austenc=us.ibm.com@lists.ozlabs.org>
> >
> > Hello,
> >
> > I've noticed that we've grown several helper script repositories, with
> > a mix of intents.
> >
> > So far we have:
> >
> > https://github.com/williamspatrick/openbmc-events
> >
> > and the seemingly more active fork:
> >
> > https://github.com/geissonator/openbmc-events
> >
> > Along with something Joel cooked up a while back:
> >
> > https://github.com/shenki/obmc-ctrl
> >
> > and some scripts that I've written:
> >
> > https://github.com/amboar/obmc-scripts/
> >
> > Is it worth consolidating these efforts? If we do I think the result
> > should be low friction wrt merging changes, and some hacking should
> > always be expected if you're going to use the repository. Consolidating
> > might help avoid duplicate effort.
> >
> > Cheers,
> >
> > Andrew[attachment "signature.asc" deleted by Chris Austen/Austin/IBM]

[-- Attachment #2: Type: text/html, Size: 3189 bytes --]

Re: OpenBMC helper scripts repositories

[Andrew Geissler]

Brad, Patrick, and I were also tossing around a misc tools repo under
the openbmc umbrella a few weeks back.

I definitely vote for one!  I think the main concern was support, it
would def be a "use at your own risk" and "patches preferred over bug
reports" type repo.

I know George also has a collection of tools he uses for REST
operations as well.

With https://github.com/geissonator/openbmc-events, I was looking to
build a bunch of small tools, that had similar command line interfaces
to interact with the different REST api's in openbmc.

Andrew

On Thu, Oct 5, 2017 at 10:54 PM, Chris Austen <austenc@us.ibm.com> wrote:
>
> https://github.com/causten/tools/tree/master/obmc I've also got those files.
> things have evolved and I not kept the error logging or code update
> refreshed to any of the new xyz paths. However, leds.py still can toggle the
> LEDS on a system and obmcrequests.py (my library for bmc communication) can
> work offline if the data has been captured.
>
> "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org> wrote on
> 10/05/2017 09:52:43 PM:
>
>> From: "Chris Austen" <austenc@us.ibm.com>
>> To: Andrew Jeffery <andrew@aj.id.au>
>> Cc: OpenBMC <openbmc@lists.ozlabs.org>
>> Date: 10/05/2017 09:53 PM
>> Subject: Re: OpenBMC helper scripts repositories
>> Sent by: "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org>
>>
>> Mine too... https://github.com/causten/openbmc-tutorials
>>
>>
>> "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org>
>> wrote on 10/05/2017 08:55:40 PM:
>>
>> > From: Andrew Jeffery <andrew@aj.id.au>
>> > To: OpenBMC <openbmc@lists.ozlabs.org>
>> > Date: 10/05/2017 08:56 PM
>> > Subject: OpenBMC helper scripts repositories
>> > Sent by: "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org>
>> >
>
>> > Hello,
>> >
>> > I've noticed that we've grown several helper script repositories, with
>> > a mix of intents.
>> >
>> > So far we have:
>> >
>> > https://github.com/williamspatrick/openbmc-events
>> >
>> > and the seemingly more active fork:
>> >
>> > https://github.com/geissonator/openbmc-events
>> >
>> > Along with something Joel cooked up a while back:
>> >
>> > https://github.com/shenki/obmc-ctrl
>> >
>> > and some scripts that I've written:
>> >
>> > https://github.com/amboar/obmc-scripts/
>> >
>> > Is it worth consolidating these efforts? If we do I think the result
>> > should be low friction wrt merging changes, and some hacking should
>> > always be expected if you're going to use the repository. Consolidating
>> > might help avoid duplicate effort.
>> >
>> > Cheers,
>> >
>> > Andrew[attachment "signature.asc" deleted by Chris Austen/Austin/IBM]

Re: OpenBMC helper scripts repositories

[Lei YU]

Vote+1

I always wanted such a repo to put common/shared scripts together.

And even more, what about a repo that collects the common/shared code (C/C++)?

Quite a lot of repos are having the same/similar functions like
getting a service
via mapper call.
Is it better to collect such code, make sure they are well-tested,
and put them in a shared repo (e.g. in SDK)?

--
BRs,
Lei YU

On Tue, Oct 10, 2017 at 2:00 AM, Andrew Geissler <geissonator@gmail.com> wrote:
> Brad, Patrick, and I were also tossing around a misc tools repo under
> the openbmc umbrella a few weeks back.
>
> I definitely vote for one!  I think the main concern was support, it
> would def be a "use at your own risk" and "patches preferred over bug
> reports" type repo.
>
> I know George also has a collection of tools he uses for REST
> operations as well.
>
> With https://github.com/geissonator/openbmc-events, I was looking to
> build a bunch of small tools, that had similar command line interfaces
> to interact with the different REST api's in openbmc.
>
> Andrew
>
> On Thu, Oct 5, 2017 at 10:54 PM, Chris Austen <austenc@us.ibm.com> wrote:
>>
>> https://github.com/causten/tools/tree/master/obmc I've also got those files.
>> things have evolved and I not kept the error logging or code update
>> refreshed to any of the new xyz paths. However, leds.py still can toggle the
>> LEDS on a system and obmcrequests.py (my library for bmc communication) can
>> work offline if the data has been captured.
>>
>> "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org> wrote on
>> 10/05/2017 09:52:43 PM:
>>
>>> From: "Chris Austen" <austenc@us.ibm.com>
>>> To: Andrew Jeffery <andrew@aj.id.au>
>>> Cc: OpenBMC <openbmc@lists.ozlabs.org>
>>> Date: 10/05/2017 09:53 PM
>>> Subject: Re: OpenBMC helper scripts repositories
>>> Sent by: "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org>
>>>
>>> Mine too... https://github.com/causten/openbmc-tutorials
>>>
>>>
>>> "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org>
>>> wrote on 10/05/2017 08:55:40 PM:
>>>
>>> > From: Andrew Jeffery <andrew@aj.id.au>
>>> > To: OpenBMC <openbmc@lists.ozlabs.org>
>>> > Date: 10/05/2017 08:56 PM
>>> > Subject: OpenBMC helper scripts repositories
>>> > Sent by: "openbmc" <openbmc-bounces+austenc=us.ibm.com@lists.ozlabs.org>
>>> >
>>
>>> > Hello,
>>> >
>>> > I've noticed that we've grown several helper script repositories, with
>>> > a mix of intents.
>>> >
>>> > So far we have:
>>> >
>>> > https://github.com/williamspatrick/openbmc-events
>>> >
>>> > and the seemingly more active fork:
>>> >
>>> > https://github.com/geissonator/openbmc-events
>>> >
>>> > Along with something Joel cooked up a while back:
>>> >
>>> > https://github.com/shenki/obmc-ctrl
>>> >
>>> > and some scripts that I've written:
>>> >
>>> > https://github.com/amboar/obmc-scripts/
>>> >
>>> > Is it worth consolidating these efforts? If we do I think the result
>>> > should be low friction wrt merging changes, and some hacking should
>>> > always be expected if you're going to use the repository. Consolidating
>>> > might help avoid duplicate effort.
>>> >
>>> > Cheers,
>>> >
>>> > Andrew[attachment "signature.asc" deleted by Chris Austen/Austin/IBM]

Re: OpenBMC helper scripts repositories

[Andrew Jeffery]

[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]

On Mon, 2017-10-09 at 13:00 -0500, Andrew Geissler wrote:
> Brad, Patrick, and I were also tossing around a misc tools repo under
> the openbmc umbrella a few weeks back.

Interesting, glad to hear it's already got some attention.

> 
> I definitely vote for one!  I think the main concern was support, it
> would def be a "use at your own risk" and "patches preferred over bug
> reports" type repo.

Yeah, absolutely. This is what I was looking for as well, as a means to
merge code as quickly as possible to minimise the fragmentation. This
means things will probably be broken, but maybe we can look at
hardening the process against breakage after we've got something in
place (and are sick of it breaking).

> 
> I know George also has a collection of tools he uses for REST
> operations as well.

Right, these would be good to include.

> 
> > With https://github.com/geissonator/openbmc-events, I was looking to
> build a bunch of small tools, that had similar command line interfaces
> to interact with the different REST api's in openbmc.

Consistency is good (especially with respect to the REST API) if it's
easy to achieve, but I think we shouldn't get too hung up about it in
general (i.e. for tools operating outside the REST context).

What if we git-subtree the existing repos into mine? I'm happy to
maintain it.

Thanks for your thoughts!

Andrew

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: OpenBMC helper scripts repositories

[Andrew Jeffery]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

On Tue, 2017-10-10 at 09:55 +0800, Lei YU wrote:
> Vote+1
> 
> I always wanted such a repo to put common/shared scripts together.

Great, it seems there's a fair bit of consensus on this. Did you have
any scripts of your own that we could pull in?

> 
> And even more, what about a repo that collects the common/shared code
> (C/C++)?

I feel this is a different undertaking, something that should be
addressed separately from what I'm proposing. My move-fast-and-break-
things model doesn't really gel with developing the low-level libraries
you're talking about here.

Cheers,

Andrew

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: OpenBMC helper scripts repositories

[Lei YU]

On Wed, Oct 11, 2017 at 11:12 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
> On Tue, 2017-10-10 at 09:55 +0800, Lei YU wrote:
>> Vote+1
>>
>> I always wanted such a repo to put common/shared scripts together.
>
> Great, it seems there's a fair bit of consensus on this. Did you have
> any scripts of your own that we could pull in?

Yup, I have "upload_and_update.py" that do the code upload/update.
Though it only works on non-ubi-fs systems.
https://gist.github.com/mine260309/21ceff0f69b42df0ef12a85c83ec01c3

>
>>
>> And even more, what about a repo that collects the common/shared code
>> (C/C++)?
>
> I feel this is a different undertaking, something that should be
> addressed separately from what I'm proposing. My move-fast-and-break-
> things model doesn't really gel with developing the low-level libraries
> you're talking about here.

Sure, let's focus on the scripts for now.

>
> Cheers,
>
> Andrew

Re: OpenBMC helper scripts repositories

[Andrew Geissler]

Lets do this!  Any proposal on the repo name Andrew J?  openbmc-tools?

Andrew

On Thu, Oct 12, 2017 at 1:34 AM, Lei YU <mine260309@gmail.com> wrote:
> On Wed, Oct 11, 2017 at 11:12 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
>> On Tue, 2017-10-10 at 09:55 +0800, Lei YU wrote:
>>> Vote+1
>>>
>>> I always wanted such a repo to put common/shared scripts together.
>>
>> Great, it seems there's a fair bit of consensus on this. Did you have
>> any scripts of your own that we could pull in?
>
> Yup, I have "upload_and_update.py" that do the code upload/update.
> Though it only works on non-ubi-fs systems.
> https://gist.github.com/mine260309/21ceff0f69b42df0ef12a85c83ec01c3
>
>>
>>>
>>> And even more, what about a repo that collects the common/shared code
>>> (C/C++)?
>>
>> I feel this is a different undertaking, something that should be
>> addressed separately from what I'm proposing. My move-fast-and-break-
>> things model doesn't really gel with developing the low-level libraries
>> you're talking about here.
>
> Sure, let's focus on the scripts for now.
>
>>
>> Cheers,
>>
>> Andrew

Re: OpenBMC helper scripts repositories

[Andrew Jeffery]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

On Thu, 2017-10-12 at 12:52 -0500, Andrew Geissler wrote:
> Lets do this!  Any proposal on the repo name Andrew J?  openbmc-tools?

Sounds reasonable to me, can you create it?

Cheers,

Andrew

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: OpenBMC helper scripts repositories

[Andrew Geissler]

On Thu, Oct 12, 2017 at 4:32 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> On Thu, 2017-10-12 at 12:52 -0500, Andrew Geissler wrote:
>> Lets do this!  Any proposal on the repo name Andrew J?  openbmc-tools?
>
> Sounds reasonable to me, can you create it?
>
> Cheers,
>
> Andrew

https://github.com/openbmc/openbmc-tools created.

Thanks Andrew J!

Re: OpenBMC helper scripts repositories

[Andrew Jeffery]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

On Thu, 2017-10-12 at 14:34 +0800, Lei YU wrote:
> On Wed, Oct 11, 2017 at 11:12 AM, Andrew Jeffery <andrew@aj.id.au>
> wrote:
> > On Tue, 2017-10-10 at 09:55 +0800, Lei YU wrote:
> > > Vote+1
> > > 
> > > I always wanted such a repo to put common/shared scripts
> > > together.
> > 
> > Great, it seems there's a fair bit of consensus on this. Did you
> > have
> > any scripts of your own that we could pull in?
> 
> Yup, I have "upload_and_update.py" that do the code upload/update.
> Though it only works on non-ubi-fs systems.
> https://gist.github.com/mine260309/21ceff0f69b42df0ef12a85c83ec01c3

Can you please license this under Apache 2.0 and submit it to 
https://github.com/openbmc/openbmc-tools ?

Cheers,

Andrew

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: OpenBMC helper scripts repositories

[Andrew Jeffery]

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

Hey Chris,

On Thu, 2017-10-05 at 22:54 -0500, Chris Austen wrote:
> 
> https://github.com/causten/tools/tree/master/obmc I've also got those
> files. things have evolved and I not kept the error logging or code
> update refreshed to any of the new xyz paths. However, leds.py still
> can toggle the LEDS on a system and obmcrequests.py (my library for
> bmc communication) can work offline if the data has been captured.
> 

I took a quick look at the history of the repository and I'm hesitant
to pull it in right away. We need to sort out Signed-off-by tags for it
and fix your name (to be your actual name and not 'causten') in the
commits. Once that's done though I'll pull it in.

Cheers,

Andrew

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: OpenBMC helper scripts repositories

[Andrew Jeffery]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

On Mon, 2017-10-09 at 13:00 -0500, Andrew Geissler wrote:
> With https://github.com/geissonator/openbmc-events, I was looking to
> build a bunch of small tools, that had similar command line interfaces
> to interact with the different REST api's in openbmc.

I've pulled this into openbmc/openbmc-tools.

Cheers,

Andrew

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: OpenBMC helper scripts repositories

[Lei YU]

On Fri, Oct 13, 2017 at 7:48 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> On Thu, 2017-10-12 at 14:34 +0800, Lei YU wrote:
>> On Wed, Oct 11, 2017 at 11:12 AM, Andrew Jeffery <andrew@aj.id.au>
>> wrote:
>> > On Tue, 2017-10-10 at 09:55 +0800, Lei YU wrote:
>> > > Vote+1
>> > >
>> > > I always wanted such a repo to put common/shared scripts
>> > > together.
>> >
>> > Great, it seems there's a fair bit of consensus on this. Did you
>> > have
>> > any scripts of your own that we could pull in?
>>
>> Yup, I have "upload_and_update.py" that do the code upload/update.
>> Though it only works on non-ubi-fs systems.
>> https://gist.github.com/mine260309/21ceff0f69b42df0ef12a85c83ec01c3
>
> Can you please license this under Apache 2.0 and submit it to
> https://github.com/openbmc/openbmc-tools ?

Created pull request.
Thanks!

>
> Cheers,
>
> Andrew