All of lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Ramirez Luna <omar.luna@linaro.org>
To: Paul Walmsley <paul@pwsan.com>
Cc: Benoit Cousson <b-cousson@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <linux@arm.linux.org.uk>,
	Kevin Hilman <khilman@ti.com>, Ohad Ben-Cohen <ohad@wizery.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: OMAP: omap_device: expose hwmod assert/deassert to omap devices
Date: Thu, 2 Aug 2012 12:56:37 -0500	[thread overview]
Message-ID: <CALLhW=7JL64qaXKSTFsyR8sXPe-PSMZp=d2Rrkno_peSYGyvEg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1208020141140.4177@utopia.booyaka.com>

On 2 August 2012 02:43, Paul Walmsley <paul@pwsan.com> wrote:
>> This APIs are meant to be an interface to hwmod assert/deassert
>> function, omap devices can call them through their platform data
>> to control their reset lines, they are expected to know the name
>> of the reset line they are trying to control.
>>
>> Signed-off-by: Omar Ramirez Luna <omar.luna@linaro.org>
>
> This one has been queued for 3.7 with a few changes. Some more detail was
> added to the function documentationrovement.  Also the multiple
> assignments were removed per Documentation/CodingStyle chapter 1:
>
> "Don't put multiple assignments on a single line either."
>
> Please let me know if you have any comments.

Agree.

Thanks,

Omar

WARNING: multiple messages have this Message-ID (diff)
From: omar.luna@linaro.org (Omar Ramirez Luna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: OMAP: omap_device: expose hwmod assert/deassert to omap devices
Date: Thu, 2 Aug 2012 12:56:37 -0500	[thread overview]
Message-ID: <CALLhW=7JL64qaXKSTFsyR8sXPe-PSMZp=d2Rrkno_peSYGyvEg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1208020141140.4177@utopia.booyaka.com>

On 2 August 2012 02:43, Paul Walmsley <paul@pwsan.com> wrote:
>> This APIs are meant to be an interface to hwmod assert/deassert
>> function, omap devices can call them through their platform data
>> to control their reset lines, they are expected to know the name
>> of the reset line they are trying to control.
>>
>> Signed-off-by: Omar Ramirez Luna <omar.luna@linaro.org>
>
> This one has been queued for 3.7 with a few changes. Some more detail was
> added to the function documentationrovement.  Also the multiple
> assignments were removed per Documentation/CodingStyle chapter 1:
>
> "Don't put multiple assignments on a single line either."
>
> Please let me know if you have any comments.

Agree.

Thanks,

Omar

  reply	other threads:[~2012-08-02 17:56 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-16 19:21 [PATCH 0/3] OMAP: hwmod: reset API proposal Omar Ramirez Luna
2012-07-16 19:21 ` Omar Ramirez Luna
2012-07-16 19:21 ` [PATCH 1/3] ARM: OMAP: hwmod: partially un-reset hwmods might not be properly enabled Omar Ramirez Luna
2012-07-16 19:21   ` Omar Ramirez Luna
2012-08-20 14:49   ` Benoit Cousson
2012-08-20 14:49     ` Benoit Cousson
2012-08-20 14:49     ` Benoit Cousson
2012-08-21  1:13     ` Omar Ramirez Luna
2012-08-21  1:13       ` Omar Ramirez Luna
2012-08-21 17:48     ` Omar Ramirez Luna
2012-08-21 17:48       ` Omar Ramirez Luna
2012-07-16 19:21 ` [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence Omar Ramirez Luna
2012-07-16 19:21   ` Omar Ramirez Luna
2012-08-02  7:52   ` Paul Walmsley
2012-08-02  7:52     ` Paul Walmsley
2012-08-02 22:20     ` Omar Ramirez Luna
2012-08-02 22:20       ` Omar Ramirez Luna
2012-08-03  5:24       ` Vaibhav Hiremath
2012-08-03  5:24         ` Vaibhav Hiremath
2012-08-03  5:24         ` Vaibhav Hiremath
2012-08-03 15:52         ` Omar Ramirez Luna
2012-08-03 15:52           ` Omar Ramirez Luna
2012-08-20 10:21           ` Benoit Cousson
2012-08-20 10:21             ` Benoit Cousson
2012-08-20 10:21             ` Benoit Cousson
2012-08-21  1:15             ` Omar Ramirez Luna
2012-08-21  1:15               ` Omar Ramirez Luna
2012-07-16 19:21 ` [PATCH 3/3] ARM: OMAP: omap_device: expose hwmod assert/deassert to omap devices Omar Ramirez Luna
2012-07-16 19:21   ` Omar Ramirez Luna
2012-08-02  7:43   ` Paul Walmsley
2012-08-02  7:43     ` Paul Walmsley
2012-08-02 17:56     ` Omar Ramirez Luna [this message]
2012-08-02 17:56       ` Omar Ramirez Luna
  -- strict thread matches above, loose matches on Subject: below --
2012-06-16  1:54 [PATCH 0/3] OMAP: hwmod: reset API proposal Omar Ramirez Luna
2012-06-16  1:54 ` [PATCH 3/3] ARM: OMAP: omap_device: expose hwmod assert/deassert to omap devices Omar Ramirez Luna
2012-06-16  1:54   ` Omar Ramirez Luna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALLhW=7JL64qaXKSTFsyR8sXPe-PSMZp=d2Rrkno_peSYGyvEg@mail.gmail.com' \
    --to=omar.luna@linaro.org \
    --cc=b-cousson@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=ohad@wizery.com \
    --cc=paul@pwsan.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.